Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <db1b593a-41d9-444a-b3f4-f6bffe98634b@bytedance.com>
Date:   Tue, 28 Nov 2023 11:18:46 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v1 0/4] hugetlb: parallelize hugetlb page allocation
 on boot
Content-Language: en-US
To:     David Rientjes <rientjes@google.com>,
        David Hildenbrand <david@redhat.com>
Cc:     Gang Li <gang.li@linux.dev>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20231123133036.68540-1-gang.li@linux.dev>
 <5c0e27f2-5826-4537-a1ab-1debfab65b9a@redhat.com>
 <28e28c2a-e72d-a181-e87a-39cecc8c3c76@google.com>
 <9d5de524-28ee-4d71-9493-f77967ea213c@redhat.com>
 <783f8bac-55b8-5b95-eb6a-11a583675000@google.com>
From:   Gang Li <ligang.bdlg@bytedance.com>
In-Reply-To: <783f8bac-55b8-5b95-eb6a-11a583675000@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/11/25 04:00, David Rientjes wrote:
> On Fri, 24 Nov 2023, David Hildenbrand wrote:
> 
>> And there, the 65.2s won't be noise because that 12TB system is up by a snap
>> of a finger? :)
>>
> 
> In this single boot test, total boot time was 373.78s, so 1GB hugetlb
> allocation is 17.4% of that.

Thank you for sharing these data. Currently, I don't have access to a 
machine of such large capacity, so the benefits in my tests are not as 
pronounced.

I believe testing on a system of this scale would yield significant 
benefits.

> 
> Would love to see what the numbers would look like if 1GB pages were
> supported.
> 

Support for 1GB hugetlb is not yet perfect, so it wasn't included in v1. 
But I'm happy to refine and introduce 1GB hugetlb support in future 
versions.