Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3582924rdh; Mon, 27 Nov 2023 19:27:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBfwKpKBc6+3t6G1wT6X5jvzxeD/lLY/eULvWbKonYDsJT+l+4ZvMTMggOiquNDp1X/6Z9 X-Received: by 2002:a9d:7b4f:0:b0:6cd:896:e363 with SMTP id f15-20020a9d7b4f000000b006cd0896e363mr13579311oto.37.1701142052825; Mon, 27 Nov 2023 19:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701142052; cv=none; d=google.com; s=arc-20160816; b=kYOMrpLBuoLxb/2CcVpGpj1++7A5bxbAhB6wyIu9QyJ79oV8ey7tQtuUchdHryhvOZ FUwJ7ZMSRGODXHOKnNn6YTpEyZbZsF/7qFUfWD+7trZCqvxYYY26eJN+7k+Tj4BTfR50 TifFjsSeZKY+tfJQYXffHIfVPUzga7SGk3ARgNTiRf4NHmiVdqFs9A83/l1HK9xA6vsf 3e7pJeI9a7TUa9nnuCYw1ZtViuaQVGbqKKB/bd1rrqAPQk3TSGNpNrE4D5uo2dDwlkYX T5Xd/HQ+t2Ub99IdIkjbXxukwJvQakIZzbo24vACWt3b2q3+W3djkePLD7pN98d2nc5M QWoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dymokLtc+Ixha61+4f7cZK1W1d0w612OLAA0dg5oPzE=; fh=D/EUJnYzmyA4XYOizQR86Wv4rh6+JaS8QYdwnc0ECKE=; b=q4UWNC5WKLexcwoVu98152OEQfjrCw4gd2zURAnzr19knhS5Q/UUMvMkYtE3GH015o cCSbEyzrHuaOyH0wzb3WhiDxvtT60BOXy9mRmLmietG5S6VrB1xDc19B/xbOS8ULmb5O mZhmuUoX6UMv6G8RgMaBdCxerlpZEaHib6+/Nd6gwSDUgALAKSXWmOboc3DbjgUUxaVl erEyYCE+WFPea6o19grImeq5lXKP6e51QIqqflh8rHBVL6Aoj67I7zSbaaECppvEqgKz VDqu2B90HovEDpk2QtG9RvxJjAelh3ZnsDFeamnCW7Ewd0o5HyQSYU8/t07GaEZX3ft6 jwHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CyN9BibC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u2-20020a63d342000000b005be327e08afsi11575478pgi.224.2023.11.27.19.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 19:27:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CyN9BibC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 3FC87807C863; Mon, 27 Nov 2023 19:26:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232694AbjK1D0D (ORCPT + 99 others); Mon, 27 Nov 2023 22:26:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234529AbjK1D0B (ORCPT ); Mon, 27 Nov 2023 22:26:01 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55B661A7 for ; Mon, 27 Nov 2023 19:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701141964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dymokLtc+Ixha61+4f7cZK1W1d0w612OLAA0dg5oPzE=; b=CyN9BibCviQ7ZSskR12WrFIBs/H4w/U+5KGHK3GpZpN20iRVoGtKr3k2X86h03IBm9IGc0 lBS7fEBIjCwmCmx+jiJCvzMJViQNSs/r4UXsT0CHOfVE2YPYCO3eCtIZVi7a+oMakskN6K EshQ5az7J+R4wkP5xOn9gkBuFOUxmiw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-WLJMPzMwPQKD8zSJIA65RQ-1; Mon, 27 Nov 2023 22:26:00 -0500 X-MC-Unique: WLJMPzMwPQKD8zSJIA65RQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5490485A5BD; Tue, 28 Nov 2023 03:26:00 +0000 (UTC) Received: from localhost (unknown [10.72.112.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64EDD1121307; Tue, 28 Nov 2023 03:25:59 +0000 (UTC) Date: Tue, 28 Nov 2023 11:25:56 +0800 From: Baoquan He To: Shijie Huang Cc: Huang Shijie , k-hagio-ab@nec.com, lijiang@redhat.com, akpm@linux-foundation.org, vgoyal@redhat.com, dyoung@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, patches@amperecomputing.com Subject: Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled Message-ID: References: <20231127020727.25296-1-shijie@os.amperecomputing.com> <33021b87-4c6a-45fc-a6ae-265765cfcd78@amperemail.onmicrosoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33021b87-4c6a-45fc-a6ae-265765cfcd78@amperemail.onmicrosoft.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 27 Nov 2023 19:26:28 -0800 (PST) On 11/27/23 at 11:18am, Shijie Huang wrote: > > 在 2023/11/27 10:51, Baoquan He 写道: > > Hi, > > > > On 11/27/23 at 10:07am, Huang Shijie wrote: > > > In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed, > > > kernel will use vmemmap to do the __pfn_to_page/page_to_pfn, > > > and kernel will not use the "classic sparse" to do the > > > __pfn_to_page/page_to_pfn. > > > > > > So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed. > > > This makes the user applications (crash, etc) get faster > > > pfn_to_page/page_to_pfn operations too. > > Are there Crash or makedupfile patches posted yet to make use of this? > > I have patches for Crash to use the 'vmemmap', but after this patch is > merged, I will send it out. > > (I think Kazu will not merge a crash patch which depends on a kernel patch > which is not merged.) Maybe post these userspace patches too so that Kazu can evaluat if those improvement is necessary?