Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <a7d85fee-23cd-4b85-adc6-16980b6e5e02@amperemail.onmicrosoft.com>
Date:   Tue, 28 Nov 2023 11:31:42 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP
 is enabled
To:     Baoquan He <bhe@redhat.com>
Cc:     Huang Shijie <shijie@os.amperecomputing.com>, k-hagio-ab@nec.com,
        lijiang@redhat.com, akpm@linux-foundation.org, vgoyal@redhat.com,
        dyoung@redhat.com, kexec@lists.infradead.org,
        linux-kernel@vger.kernel.org, patches@amperecomputing.com
References: <20231127020727.25296-1-shijie@os.amperecomputing.com>
 <ZWQEP4SczFh+GUHq@MiWiFi-R3L-srv>
 <33021b87-4c6a-45fc-a6ae-265765cfcd78@amperemail.onmicrosoft.com>
 <ZWVdxAv/PPHY3Ndl@MiWiFi-R3L-srv>
From:   Shijie Huang <shijie@amperemail.onmicrosoft.com>
In-Reply-To: <ZWVdxAv/PPHY3Ndl@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3VmcVQwMlBsdDVldGJZTUhFZERDT3R2aU4xSTZYK1VPRVgwSC81OXRwOTFl?=
 =?utf-8?B?NXhBaGp3Tjd3RlNUaXd2MlpPUTlObHNaSEx0VGR3cWlqWU9SakNkRjZYZEt4?=
 =?utf-8?B?RkZyQkhaU1pxaW0wWU5hQlJ2WjZISTlpK1diY09JcUJVTlRoTlA0SlBmb1Zn?=
 =?utf-8?B?SHhYTy8ya0FVWDM5b1hmVDgvcjZJWVZOb2hYR0pTb1ozTjgyYUdIaGVOMVdR?=
 =?utf-8?B?ZEl6QTNZT3drMXd6dCtNNVhUNmFWVXc3d1QycEVTMXBqWW1tSnMwUVhYMXVp?=
 =?utf-8?B?R0JhY2dYY2RnWHhOS1EzWEdhdHlxb1crak9oVURjSXk3UGJtUXZMQTdGUndl?=
 =?utf-8?B?UzcvMFAzbGdkZGpDc2JQRUFIZWVVVGM0M1VCU1dscjlKNy94SEVGbWx1WGJw?=
 =?utf-8?B?NlZMVm5IMldVQW9BdUZuS09NV2tBTGZUTVowcFlPSWduUHNKZ0hZcHoyMkRM?=
 =?utf-8?B?dUE2b1pyVE5HdlBQcStlbVlEaVhhY1loTVJ6RVRUNHRNSHVqWWx6bzN1ekVz?=
 =?utf-8?B?QnJxNmRKWTM5V0g1Z0FKV29MYlQyTG5YMVRIeENraHROS3ZGMU1tTHE4dUZp?=
 =?utf-8?B?RnJubWpHRWF0NnpLUjE1RXVMRG14WVRwcDRxNnZpWXJJV2YrK2NOQzFGUDI0?=
 =?utf-8?B?bitSbGEwdHpMdnFab0wyaTE1bk5JUHdERHVCUDNWUlhDdUptdS9DZXdQS203?=
 =?utf-8?B?NFJHcVpPa0V2aGxSaFU0ejJ5cWRBR1JORk9adWQwZ2V2T05uYmJHSWdkdFNz?=
 =?utf-8?B?MStOaGFwd3BNNGdIclI2RWlzeHM3dllRQWdVUDl5OUZXWDZiVDVQRHl2QUNv?=
 =?utf-8?B?ZVl3UkFoVXJvQnNMVXBtLzdVZktHTlJNd1hwL3pmcEFpQTVneHVaRERrSk90?=
 =?utf-8?B?dXR0aHhWSmloWjArc2JRSjNoenVWRStFNC9hVUhPRkJjaEdIR0JTZ25JcW5w?=
 =?utf-8?B?UEtWSjNNZXU4ZENscmVKQk5MRkYvaHhqbmMrY3RNV3dVYzhUZUxqY2kzM3hM?=
 =?utf-8?B?NXZmVHBFd2Y0aGU2WkJFMGVoVXU5RFEzeVZMQzZBU0RnNjdSTWEvMnR4eHAz?=
 =?utf-8?B?WkxIanBKcWtmdEVVSzVSWlE3N0xXQVh6dnhLWEZYdytib25YUFBjNTVhekVM?=
 =?utf-8?B?YURwaXVmdjczc2tMUnhvYUp1K1RrZE44czZvRXBZb2VyWFBJM21rVVF0TWRX?=
 =?utf-8?B?K3k3aUU0OFdsRjNOdFlaWVVZd2R0WWhqNDlJVHlZc3l4KzVyQUhzd3l6TGNv?=
 =?utf-8?B?bStrcWJVa2xoTHFNektGN1I2VDdySDlERTVMWHptMjJ4VGROOUMxNzFPUjdj?=
 =?utf-8?B?WjlMU3hGRHRSZUpoUENZclpTWFkvSVQ1S0FESEROR2xZbmEwMHR3K0pNczYx?=
 =?utf-8?B?am8yclNqTUVCejBGNEhGajFiYTFmTmN6eEdWcXhaS2VDbm5jUVdGYWlIZVRC?=
 =?utf-8?B?aXVCR3VRbHlzVHlwdjg4aUJsVFAvNHhLeElCcGtoVXFCR0k2c2hmYThFSHcw?=
 =?utf-8?B?L1pjZEIwK3ZEL3p3UXJTeG55TlQ3b3Z0d3Q2L0xpQVJJRmgwWFFJcm1hYUx4?=
 =?utf-8?B?UHk2ZDlveDV1OHFRMkpYNFBvczkxM1lyQ2YyaHA1UEVYYVpqVUpieUVrOW9C?=
 =?utf-8?B?TWVZc2ZvNTZpN3lDcWtmLzBLUTRKNndDYW9UK0o1a01RNWNwaFFYUkF3Z0l0?=
 =?utf-8?B?bkg2M1l1c3F3bEFNOHBmYTYrMExjSHBKSjJWdTNXbjVoTG9HNmhuN21UeUZ0?=
 =?utf-8?B?WW5QZzlIWEIxd2NLSURvWFVBQjhTMEFsV1hQRmVBaEhFZnJvNExMbTlMN1lt?=
 =?utf-8?B?QmlmMXpTeXdPMlU0RmVOdFUvY2YvYlcwKzMxZ3d3RXViYytKb0RTd2YwZThl?=
 =?utf-8?B?dXVBakIrZDBscS9ZZUZJNVVadGRZRTE3R3k2SkxoQmpGczlXM1BCbVpDODVG?=
 =?utf-8?B?TDZJYUdlTDBPZ0YxMFFWZkFlakxGUVpSVFNtQW5ZVk5SWGZRWWwrNDRKblpN?=
 =?utf-8?B?ZzhyWjhxa3pOMDJZVEFVSWZCWTAzbG90Vm01aTl2SHB4akJvVjUwdjdlR3Fy?=
 =?utf-8?B?WitON0N6VS9najVZMEZwRWZZS0hTTVhtY0RidnljLzZmRXMrSjFTNE02cW02?=
 =?utf-8?B?VkllZ2tWQkFWNzJRYmR6KzAwQUs2TVpCR0REbXpGZllzeHVkZTAwWFZmbUly?=
 =?utf-8?B?SVE9PQ==?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22b1b539-dd3c-44d0-287c-08dbefc29e9e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 03:32:17.0066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l4zsEAGED2WSBkuKXo+YjBysRV0jvNfkDvcakTfQDCQWNlUaTERsL8shR10LkqUYDWe/h6/jwb9HNP+oUmZgDj+mEZoY73aLNGJWbl4Z+8ZwRF1sh/nNd/a25/NU7L92
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR01MB6641
X-Spam-Status: No, score=-0.3 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 19:32:36 -0800 (PST)


在 2023/11/28 11:25, Baoquan He 写道:
> On 11/27/23 at 11:18am, Shijie Huang wrote:
>> 在 2023/11/27 10:51, Baoquan He 写道:
>>> Hi,
>>>
>>> On 11/27/23 at 10:07am, Huang Shijie wrote:
>>>> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
>>>> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
>>>> and kernel will not use the "classic sparse" to do the
>>>> __pfn_to_page/page_to_pfn.
>>>>
>>>> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
>>>> This makes the user applications (crash, etc) get faster
>>>> pfn_to_page/page_to_pfn operations too.
>>> Are there Crash or makedupfile patches posted yet to make use of this?
>> I have patches for Crash to use the 'vmemmap', but after this patch is
>> merged, I will send it out.
>>
>> (I think Kazu will not merge a crash patch which depends on a kernel patch
>> which is not merged.)
> Maybe post these userspace patches too so that Kazu can evaluat if those
> improvement is necessary?

No problem.  I will send out them later.


Thanks

Huang Shijie