Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
References: <20231124075953.1932764-1-yukuai1@huaweicloud.com>
 <20231124075953.1932764-2-yukuai1@huaweicloud.com> <CAPhsuW5mjvpMmEN5g_-ADQgJKZ1=QyNxxSw-7kq-W2jww09Aag@mail.gmail.com>
 <e3b8298c-1154-c5ce-d025-b9346a6cd2ab@huaweicloud.com>
In-Reply-To: <e3b8298c-1154-c5ce-d025-b9346a6cd2ab@huaweicloud.com>
From:   Song Liu <song@kernel.org>
Date:   Mon, 27 Nov 2023 19:48:45 -0800
Message-ID: <CAPhsuW65mcz3xLH7FH+ZceLmuMx9uLqKr7a3d9LB=nHgEJkWsg@mail.gmail.com>
Subject: Re: [PATCH v2 1/6] md: fix missing flush of sync_work
To:     Yu Kuai <yukuai1@huaweicloud.com>
Cc:     xni@redhat.com, linux-kernel@vger.kernel.org,
        linux-raid@vger.kernel.org, yi.zhang@huawei.com,
        yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 27, 2023 at 6:07=E2=80=AFPM Yu Kuai <yukuai1@huaweicloud.com> w=
rote:
>
> Hi,
>
> =E5=9C=A8 2023/11/28 8:02, Song Liu =E5=86=99=E9=81=93:
> > On Fri, Nov 24, 2023 at 12:00=E2=80=AFAM Yu Kuai <yukuai1@huaweicloud.c=
om> wrote:
> >>
> >> From: Yu Kuai <yukuai3@huawei.com>
> >>
> >> Commit ac619781967b ("md: use separate work_struct for md_start_sync()=
")
> >> use a new sync_work to replace del_work, however, stop_sync_thread() a=
nd
> >> __md_stop_writes() was trying to wait for sync_thread to be done, henc=
e
> >> they should switch to use sync_work as well.
> >>
> >> Noted that md_start_sync() from sync_work will grab 'reconfig_mutex',
> >> hence other contex can't held the same lock to flush work, and this wi=
ll
> >> be fixed in later patches.
> >>
> >> Fixes: ac619781967b ("md: use separate work_struct for md_start_sync()=
")
> >
> > This fix should go via md-fixes branch. Please send it separately.
>
> This patch alone is not good, there are follow up problems to be fixed
> completely after patch 5. Can this patchset applied to md-fixes?
>
> Or I can split patch 1,4 and 5 for md-fixes, and keep others to md-next.

Yes, please split the patches into two sets.

Thanks,
Song