Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <91e61165-6695-4948-9a38-79c1b1e6305c@intel.com>
Date:   Tue, 28 Nov 2023 13:54:45 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 2/6] iommufd: Add IOMMU_HWPT_INVALIDATE
Content-Language: en-US
To:     Nicolin Chen <nicolinc@nvidia.com>,
        Baolu Lu <baolu.lu@linux.intel.com>
CC:     <joro@8bytes.org>, <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <cohuck@redhat.com>, <eric.auger@redhat.com>,
        <kvm@vger.kernel.org>, <mjrosato@linux.ibm.com>,
        <chao.p.peng@linux.intel.com>, <yi.y.sun@linux.intel.com>,
        <peterx@redhat.com>, <jasowang@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>, <lulu@redhat.com>,
        <suravee.suthikulpanit@amd.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <zhenzhong.duan@intel.com>, <joao.m.martins@oracle.com>,
        <xin.zeng@intel.com>, <yan.y.zhao@intel.com>
References: <20231117130717.19875-1-yi.l.liu@intel.com>
 <20231117130717.19875-3-yi.l.liu@intel.com>
 <e36e856a-8d4c-4cc2-a5db-cf00673a9bf7@linux.intel.com>
 <ZVw90r3/dvgMg94Z@Asurada-Nvidia>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <ZVw90r3/dvgMg94Z@Asurada-Nvidia>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alFETTRhYksxKy80RjhpQWFHRTdPaG55Mzg5ZnNKR280cUMyMmdUVnFlNHA3?=
 =?utf-8?B?ajZoWVVhWitDZnJwZXEyZlp2ckcrNzB3TGpYVHpRL2ZEODlCK2wrWkJabVN0?=
 =?utf-8?B?cGlTZlE1bENuTE03ajhRTVk0SGxRTG41Qm1vQkhOWVY4TVVack5Odi9xcnhk?=
 =?utf-8?B?cGFNWlNiaVF2clpxbzZPQ3pKb1BDZEFVdHBGc3FZVld2cXRhTFR2R21pc1BZ?=
 =?utf-8?B?WFdvRlY4TmRBR2NiODVNQzlxMWFjQkVqQkxsbDFOQ21BMEtOU3ZwQVkyY2Ri?=
 =?utf-8?B?czVHMTZ2MlExK2RIR2kwejkzRkNlczdnT1YyZVpTL1dTYzliTG0wZStVcGpS?=
 =?utf-8?B?SDJyZDFPc0J0OCtRbGdXK0lUWmluYXR3VTdMSHZWN1NmbFoxaysxWWRoRi9U?=
 =?utf-8?B?a1dIcStYNEY0U1RBSmtld0FNMlJuYndQUUVXaUpISTFsUnNFWG9BYjh1UStQ?=
 =?utf-8?B?emdGVTlBTGtabTlmaHNMZFlnSEVsTHFZZCtmcnkwK0JZaGdsb1UvYy9JUHpO?=
 =?utf-8?B?aHlnYnVRZkNhdEFUdnBoNkVlUHVYS042cWc5b25uM1FLYjEwWWxDaEJuK2xI?=
 =?utf-8?B?SDlmUzJzQTFYbUdjUE5acm5BV2JYSnlTZVlQUTJqNG1WZGE0cGRYZGo5KzBh?=
 =?utf-8?B?MEM2WHZFcW5mWmdaWGVTcmhyK2ZOdVhTc1d1RUlPTnhnS2dzcGYxbFZLWEpm?=
 =?utf-8?B?ZVZ0R3RTdHhIdnBLNU5QVnNldC83RzNpWUxkMnJIbnZaMyswV1pvTUZFdnB0?=
 =?utf-8?B?VzE1QS9SVW1nSUlEL3FvZmlFZGtaQ3NDRlAwMFZGRzBJaTYxYnVuZEhhRWhj?=
 =?utf-8?B?V2xKSzVWOWxwTFFMa05KczluYi9ESjczNGI2K083dFd2UThNL1VBNmNERC9R?=
 =?utf-8?B?U3JLL2pBNDJUNVRjbEQvczN1Q0NrS2l4d0xNbjVQTFZCYzRVTU1vUjBpZyt1?=
 =?utf-8?B?L3RQQzRJVVNESGtPdE0xT3NDNmYrcUpJVmUyejVtVFNyZUZ0QmlGNFJhTFlP?=
 =?utf-8?B?UmJmbEJONHhkMDFkN1BFYXhUSlpPc1RFcGE5OU80bkIrVkp6S0NOT3hZUTJ1?=
 =?utf-8?B?UTR1QzdCaFFoeG5ER2ZGeTAzN3dFdmhuSlEybE53clBYWndJTnpvNnJ0a2Vo?=
 =?utf-8?B?eUk5REVYN0piMkFqSkhEbE92Q1RyWnowVXM1TVlsdi9KNG1HOS80ajRDbW9G?=
 =?utf-8?B?bjNuZnhXQmMwNHBKbEsxTkJZQW5aMzYyUjBVbGRTL1NHODFIUk15cUt4eFBi?=
 =?utf-8?B?ZDdHQnlHcVJGZTdzTmtIeG1mWHA0ZjJDdnhEYlpDdkxUaXNBd2RoZElpNVB0?=
 =?utf-8?B?Ym1GL0F3N0cxTVVEb1J2ejZlVnFSRHlNVHhkTkxMYzQyY1dFU2pOMmF3VkRY?=
 =?utf-8?B?L1hJK1ZSMk1ZdWNkTlRUdlZWQklQN2djZDJQdVpJdnZJMG9nS0kwWndKVnAr?=
 =?utf-8?B?ZDBzcXROTXJUZ3Bzc0RJZEl0Q09HOWtoUUJkOEgva044VGVJZW1WSjNCbEJ4?=
 =?utf-8?B?TnRoQ21uRSs2VUxNZVA2YXh6blFCVmVFdVY5NzFidkRON2UzVk9qTTkrWU5I?=
 =?utf-8?B?aDdmZ0VvT3VGZVlvUENoc2VOWUdsdjJDVnRuR1BHZlBIRUpSWERoMW1XRFI5?=
 =?utf-8?B?TTBMdUR0Znl4Rm1Pb0hxdW1hckZoaFprdFF2b3BhMjVvYlIraVRMNWJmbWVP?=
 =?utf-8?B?dzdTckpzaFp0WTdOb2YwZzV1c1JTTThDZEhuakhrZ2xacDhGUjhDSmYzZ0w1?=
 =?utf-8?B?ak9pNWg3UUpKbWJYaG52VzBxSmcwU001Uit2RVpvWTlJVlNHTmZkVTFRc1VL?=
 =?utf-8?B?REd4UTBzRllGNUxyMWZCRWQ5R3ZFRWlNV3c1dmM2M1BOTTM4bmFCa0RaREFE?=
 =?utf-8?B?ektkZE1SMTlMeHY5R1YyclZmMVVlTzkxQVk3dkt0YWw0N3N1TndaQnJNcmlm?=
 =?utf-8?B?NXlDTW9pS2dXejVxWmVCTEhZTWpFRldVcjhvYTdHN0w3NHBRbC9EM091a1pQ?=
 =?utf-8?B?L2ZRa3k3QkY0YzNBR01sVmg2Yi91VW9IOUM1dXI2cmdKY21TMUN0d09jQklY?=
 =?utf-8?B?TzZFRW01V3ZHNWI2NVRrWG1GRStiRFpoMEdMVEtiM0JHK092UWxBQmdUcGh1?=
 =?utf-8?Q?RgSavYj6KPANaqXG3rDV7nrlo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9db3ceb9-6125-4307-081c-08dbefd62d4f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 05:52:17.9336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NMl0E317DecJm1XrBGZBS3u/vwEntmzzJo1IC430sp00zwjOBNskPEgzAv36AyM3eatg+WqPC2/TV12dGP3tEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6838
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 21:52:27 -0800 (PST)

On 2023/11/21 13:19, Nicolin Chen wrote:
> On Tue, Nov 21, 2023 at 01:02:49PM +0800, Baolu Lu wrote:
>> On 11/17/23 9:07 PM, Yi Liu wrote:
>>> In nested translation, the stage-1 page table is user-managed but cached
>>> by the IOMMU hardware, so an update on present page table entries in the
>>> stage-1 page table should be followed with a cache invalidation.
>>>
>>> Add an IOMMU_HWPT_INVALIDATE ioctl to support such a cache invalidation.
>>> It takes hwpt_id to specify the iommu_domain, and a multi-entry array to
>>> support multiple invalidation requests in one ioctl.
>>>
>>> Check cache_invalidate_user op in the iommufd_hw_pagetable_alloc_nested,
>>> since all nested domains need that.
>>>
>>> Co-developed-by: Nicolin Chen<nicolinc@nvidia.com>
>>> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
>>> Signed-off-by: Yi Liu<yi.l.liu@intel.com>
>>> ---
>>>    drivers/iommu/iommufd/hw_pagetable.c    | 35 +++++++++++++++++++++++++
>>>    drivers/iommu/iommufd/iommufd_private.h |  9 +++++++
>>>    drivers/iommu/iommufd/main.c            |  3 +++
>>>    include/uapi/linux/iommufd.h            | 35 +++++++++++++++++++++++++
>>>    4 files changed, 82 insertions(+)
>>>
>>> diff --git a/drivers/iommu/iommufd/hw_pagetable.c b/drivers/iommu/iommufd/hw_pagetable.c
>>> index 2abbeafdbd22..367459d92f69 100644
>>> --- a/drivers/iommu/iommufd/hw_pagetable.c
>>> +++ b/drivers/iommu/iommufd/hw_pagetable.c
>>> @@ -238,6 +238,11 @@ iommufd_hwpt_nested_alloc(struct iommufd_ctx *ictx,
>>>                rc = -EINVAL;
>>>                goto out_abort;
>>>        }
>>> +     /* Driver is buggy by missing cache_invalidate_user in domain_ops */
>>> +     if (WARN_ON_ONCE(!hwpt->domain->ops->cache_invalidate_user)) {
>>> +             rc = -EINVAL;
>>> +             goto out_abort;
>>> +     }
>>>        return hwpt_nested;
>>
>> The WARN message here may cause kernel regression when users bisect
>> issues. Till this patch, there are no drivers support the
>> cache_invalidation_user callback yet.
> 
> Ah, this is an unintended consequence from our uAPI bisect to
> merge the nesting alloc first...
> 
> Would removing the WARN_ON_ONCE be okay? Although having this
> WARN is actually the point here...

seems like we may need to remove it. how about your opinion, @Jason?

> Thanks
> Nic

-- 
Regards,
Yi Liu