Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   "Boyapally, Srikanth" <Srikanth.Boyapally@amd.com>
To:     Pratyush Yadav <pratyush@kernel.org>
CC:     "tudor.ambarus@linaro.org" <tudor.ambarus@linaro.org>,
        "michael@walle.cc" <michael@walle.cc>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "richard@nod.at" <richard@nod.at>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "git (AMD-Xilinx)" <git@amd.com>
Subject: RE: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g
Thread-Topic: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g
Thread-Index: AQHaHdCRoIA/OqSAv0G0P0pMPvY/Z7CJjvlXgAWzNsA=
Date:   Tue, 28 Nov 2023 06:02:59 +0000
Message-ID: <BN9PR12MB51966705C3E306502ABABA6E9EBCA@BN9PR12MB5196.namprd12.prod.outlook.com>
References: <20231123054713.361101-1-srikanth.boyapally@amd.com>
 <mafs0jzq7dx8l.fsf@kernel.org>
In-Reply-To: <mafs0jzq7dx8l.fsf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z2nTFeLlis3MQ5JK6W3QujmDhjgFi6USnhq0YhCiR6/jrHllYybWV6nQNOun?=
 =?us-ascii?Q?LUT0oGImEU1PEOq9ziR7NOJD+Wg7dlwbDKU/1VRTS/VUOyaxM7/O7Pm91l5R?=
 =?us-ascii?Q?kxFney8S/aU6BgLpUs7W/TcdDXoFdWFXBrmcmvOZioOlnMgs6Wl1SSc460J6?=
 =?us-ascii?Q?45HgDC/NsJYM9nhQMaNi6Ot5gG72I/sejN/PYXzPfgXrl9FEZBgEyQXDG4Zv?=
 =?us-ascii?Q?pHF8wSinE0A/QHsJt++Fhd3i/JeE4tLvVIvEgIlp+GkS1AbtQ7NK2j7Sq4gY?=
 =?us-ascii?Q?dm5Zt+Uez69hrs+eQpW1q/Jbbmy6OJRpASPXxDECkZ+ITUE0K1vfhNPOqbiw?=
 =?us-ascii?Q?Hh3qVEokWUU4SjxoXtpJv9uG4AASy51iaCblBSmey8mOaWCSJDD5UKIp+Onm?=
 =?us-ascii?Q?cNGCmG8/1hmIvqFGHxOZUc8vosUX4cYZFuGh0dTElzvaopajALhV3V4ID0RU?=
 =?us-ascii?Q?bjXwbhd4i+xJ+6ejgNmtFfuuUJekBKyZG86FQX3XBdk4c9GA4Wy1omwkXut1?=
 =?us-ascii?Q?quCgNlcCFUSVwRnwp36WhLk2SVmWs45AMqbXyR6HKx7cSw8Bby1cNXrHWrBl?=
 =?us-ascii?Q?pXSy/F065sU6SSVm6wSQ7ZNHZaKi9T6Wp2oFpj+1GselIKqy0kbVfAL+MCHZ?=
 =?us-ascii?Q?0ao6qWpKbhalm0Zs0DxVful5r8Uwi+tn6r6ny3NQJ83Ls6u+pzU7cTmRzl5x?=
 =?us-ascii?Q?aBwnnhQh8piSy3YaYk8W4R/r37BHyrv5BJBpcfKydyugbzs94fkEAH9R/D1o?=
 =?us-ascii?Q?65dFz1SPHzUxT2MVGKbJCYGozYP4gguZL3+095Vf8ii3hqhzbteqB+k02y0R?=
 =?us-ascii?Q?R5cYvaepy78M3fKqsZnVjxGZwJPef7AOUunxkq084n416Qu43NFWiTjV3A6V?=
 =?us-ascii?Q?YF3K01Sg/7I2tXFg1KJAsVMiYaT04a22gXYoMPi/IqAoch0SM0laZGwe/RZu?=
 =?us-ascii?Q?5Zi+7Z96461Ej5rIQRyQmBR7Vo18T9gM69QG780LwdckCq0q3FJVQim6KBx+?=
 =?us-ascii?Q?ibz7aV//e/1VF+B7Ha6GhVmMhLcQ/8lcdD7yvFRdYSIBXDtXmfReund/Kyhu?=
 =?us-ascii?Q?3G4Ms2BnHshPvCTIvvELerKfmtzXNxGmfba403KXu6p7sft7P+1cbvFi7T58?=
 =?us-ascii?Q?gW1dafhktKB9zWSOYTgTMoNxLnZ4p7INXQTGrnPsYIrSwezDnNcm60l0VO1W?=
 =?us-ascii?Q?2RWZICnQgndaTHVsgcUezb/lZgYM0yuvUvK741y8uHtnDFDxd3RBcFiOwBF4?=
 =?us-ascii?Q?TbUQE6ZYc/DnxwpETx3chH00m/29hX9UJYY0OP5XZ0RNTg9fvwnoYefqlROm?=
 =?us-ascii?Q?OUeR6L7/JzeFEgmDB+jkoaeDQ61KqtHwPUuZz3uZlauLBZyA36r+hKup5G18?=
 =?us-ascii?Q?wpjWJfuFJop1acRVzrXVDYm6YfKk2VAfO5S4fHuqgMgkiIkkw8Hl3pNNV+ZN?=
 =?us-ascii?Q?7S3cxR87tAo2dokwClJy4tL+y2b+hbhaicw/qG1gUE8btmtprnkFPpcgYme+?=
 =?us-ascii?Q?A6vhX/h2zcxeKOKIoUX0la/y82Ovo7olWT8/mSymUC/mujF8iDymU9WGcH4a?=
 =?us-ascii?Q?+0GgZFNNdrAPYjSEECs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5196.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e021c1a-e66d-42c5-00e0-08dbefd7ac6b
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 06:02:59.2654
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3sajArJJrlk9oH6UZJNeBlkcb7XHnpV1kLL9NAg7K3raao7sUjAZhHUj6M8MgB5uNf6uQYK3r98dig7Cd57MyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5818
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 22:03:07 -0800 (PST)

Hello Pratyush,

> -----Original Message-----
> From: Pratyush Yadav <pratyush@kernel.org>
> Sent: Friday, November 24, 2023 8:17 PM
> To: Boyapally, Srikanth <Srikanth.Boyapally@amd.com>
> Cc: tudor.ambarus@linaro.org; pratyush@kernel.org; michael@walle.cc;
> miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; linux-
> mtd@lists.infradead.org; linux-kernel@vger.kernel.org; git (AMD-Xilinx)
> <git@amd.com>
> Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g
>=20
> Caution: This message originated from an External Source. Use proper caut=
ion
> when opening attachments, clicking links, or responding.
>=20
>=20
> Hi,
>=20
> On Thu, Nov 23 2023, Srikanth Boyapally wrote:
>=20
> > Add support for issi is25lp02g.
> >
> > Verified on AMD-Xilinx versal platform and executed mtd_debug
> > read/write test.
> >
> > Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>
>=20
> Based on a datasheet [0] I found online, this flash seems to have SFDP.
> And since you do not add any flash specific fixups, it likely does not ne=
ed an entry
> and would work fine with the generic flash driver. Did you try using that=
? See [1]
> for more info on contribution guidelines.
>=20
> [0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf
> [1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2-
> tudor.ambarus@linaro.org/
>=20
I ran mtd_debug read/write tests on this flash, without adding flash
entry, it worked fine for me. Please ignore this patch.

Regards,
Srikanth B
> --
> Regards,
> Pratyush Yadav