Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3635773rdh; Mon, 27 Nov 2023 22:14:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IEIuNRvwHNHbNn04Kag/Rd022KXks0Y/axFfVVH+7mw1cIdkh/p/aRYWTP8aSlgrsejYFsB X-Received: by 2002:a17:902:db07:b0:1cf:c37f:7160 with SMTP id m7-20020a170902db0700b001cfc37f7160mr7589947plx.63.1701152081219; Mon, 27 Nov 2023 22:14:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701152081; cv=none; d=google.com; s=arc-20160816; b=RK8kBY9LUMGQ+dAzLwoCCOTbTlVd8zJn9jagPSTJbeO06jgplrNn6dhNBfXPFlk3Sd m8/7jhbOz/bxMbc8tZ1bx1krh1Y1fyl/36LJt5nLjqg/++skBxzOUpqwO4QvffpAAgj6 teLwc9Ddyb1q31hXwsETojqyqp5tprwYjkJeWn6vR6r5HdAclcOT/B1RZzet4wdIioyS PHrXnAEfKgisZHqKTQhfc0UTcegjCS1wu3XwzeXM9IeQ1/4XPwclTP379XWMvqC9HtdD EX2qJaFQpqJ/HoBclrnQePShU7o5+NAaCyHXKPlhniFnEasyTp/ytjoyZsuuFqsjZT9z c/6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=5WWuzqoK+EBN/AXYqZ4NmCQTMAj6jSR4XKXcveP/TXU=; fh=oOZ7Bd3vL3U2t0Udf9OkrOPovBEVVLv9qfTJ8trHJ0Q=; b=u5j26B03hRAhgHTLmwSxnohiW68ODC1WoDbMoq3gYkfDHDZq2oxpcFqJDru9cRnRGn zn2s8A0kiG6cU80R3o9iA0fyG/TzM1hFGvkdNjgDAcUkWkQlf+DB63uZe7WxUUKDVR5x I9ngqrq6t/xoZ5tGL9DJG7IwkdguQitKmJlWj0IOIZqNdFfdA91gC6FRoN+rsW4L+S9w krvN9yy7alqM65+AtO2UswgtChbfdCv71tEaBkBDl5L8vOfRYldaiQxwJnAMnqe5Rqlu +4q9rPKTen2RhxWXY15/pLKnMjkGsLsoMPG3lGGalZs8SBxr+wUTRJXMTuVOvwmdWPXi UY3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ARfjCT2z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id i11-20020a170902c94b00b001cfdb94ee48si2707288pla.376.2023.11.27.22.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 22:14:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ARfjCT2z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D4B1C80A265B; Mon, 27 Nov 2023 22:14:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343615AbjK1GOa (ORCPT + 99 others); Tue, 28 Nov 2023 01:14:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234613AbjK1GO3 (ORCPT ); Tue, 28 Nov 2023 01:14:29 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7815C4; Mon, 27 Nov 2023 22:14:35 -0800 (PST) Received: from [100.124.219.30] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: vignesh) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0511B66072A4; Tue, 28 Nov 2023 06:14:31 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701152073; bh=ZG0Tm8rmeYeyaVrNuXAmLFqred76mjRjFtnoj7e50pc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ARfjCT2z30i9fMFc6uRARQ/ghAqWw4A2tIgSIb9WZ6Tjo411B4URSZP0mgHsu/rdv iti4J2nZMLwPI1R4S8ZpuxTPMFs7LFlGn77OoxO5JQitCNI4VRKbho9RLqPN5eOpiH kkrj+7yDHLMydfsb6QfXuuGUBivkzDe1RuU7bcEKYPi+FFFqiM0A7TORq0WlqkMbFr KFyyMTKs97wP8t2fa3L/mItY5ZsmROhydQRASx4nh7Jr5YEXIfWi9ZbVcsM/oJvFkO 4lJGtp6uWQqY86UdD2EfTjIsiNGyhvnOT76+Csksn34xbEmzSC+cCuLlun0VGVp6rj cYBam44Q0sE8w== Message-ID: <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com> Date: Tue, 28 Nov 2023 11:44:26 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] PCI: qcom: Fix compile error To: Manivannan Sadhasivam Cc: intel-gfx@lists.freedesktop.org, helen.koike@collabora.com, daniels@collabora.com, linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20231128042026.130442-1-vignesh.raman@collabora.com> <20231128051456.GA3088@thinkpad> Content-Language: en-US From: Vignesh Raman In-Reply-To: <20231128051456.GA3088@thinkpad> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 22:14:40 -0800 (PST) Hi Mani, On 28/11/23 10:44, Manivannan Sadhasivam wrote: > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: >> Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument >> to acquire bus lock") has added an argument to acquire bus lock >> in pci_enable_link_state, but qcom_pcie_enable_aspm calls it >> without this argument, resulting in below build error. >> > > Where do you see this error? That patch is not even merged. Looks like you are > sending the patch against some downstream tree. I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip This commit is merged in drm-intel/topic/core-for-CI - https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI Regards, Vignesh