Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <5ab76c0c-6333-4452-ae51-9193926c802c@linux.alibaba.com>
Date:   Tue, 28 Nov 2023 14:22:47 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf: ignore exited thread when synthesize thread map
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     mingo@redhat.com, peterz@infradead.org, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        kprateek.nayak@amd.com, linux-kernel@vger.kernel.org
References: <20231122022154.12772-1-CruzZhao@linux.alibaba.com>
 <CAM9d7chVZRKUSmXmZS4OyokKfLKp4h8K8RLWehYRpAs5Z4jsbg@mail.gmail.com>
From:   cruzzhao <cruzzhao@linux.alibaba.com>
Content-Language: en-US
In-Reply-To: <CAM9d7chVZRKUSmXmZS4OyokKfLKp4h8K8RLWehYRpAs5Z4jsbg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/11/23 上午5:05, Namhyung Kim 写道:
> Hello,
> 
> On Tue, Nov 21, 2023 at 6:22 PM Cruz Zhao <CruzZhao@linux.alibaba.com> wrote:
>>
>> When synthesize thread map, some threads in thread map may have
>> already exited, so that __event__synthesize_thread() returns -1
>> and the synthesis breaks. However, It will not have any effect
>> if we just ignore the exited thread. So just ignore it and continue.
> 
> Looks ok.  But I guess you want to do the same for the leader
> thread below as well.
> 
> Thanks,
> Namhyung
> 

With my testcase, no error is returned even if we don't do the same for
the leader thread blow. Well, I'll check whether the logic is still
correct if we do so.

Many thanks for reviewing.

Best,
Cruz Zhao