Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <06719894-7acd-9bfb-bdf7-4aa9eba21f2f@collabora.com>
Date:   Tue, 28 Nov 2023 13:17:17 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] PCI: qcom: Fix compile error
Content-Language: en-US
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        jani.nikula@linux.intel.com
Cc:     intel-gfx@lists.freedesktop.org, helen.koike@collabora.com,
        daniels@collabora.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, david.e.box@linux.intel.com,
        swati2.sharma@intel.com
References: <20231128042026.130442-1-vignesh.raman@collabora.com>
 <20231128051456.GA3088@thinkpad>
 <50a9f061-e1d3-6aca-b528-56dbb6c729d9@collabora.com>
 <20231128065104.GK3088@thinkpad>
From:   Vignesh Raman <vignesh.raman@collabora.com>
In-Reply-To: <20231128065104.GK3088@thinkpad>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 28/11/23 12:21, Manivannan Sadhasivam wrote:
> On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote:
>> Hi Mani,
>>
>> On 28/11/23 10:44, Manivannan Sadhasivam wrote:
>>> On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote:
>>>> Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument
>>>> to acquire bus lock") has added an argument to acquire bus lock
>>>> in pci_enable_link_state, but qcom_pcie_enable_aspm calls it
>>>> without this argument, resulting in below build error.
>>>>
>>>
>>> Where do you see this error? That patch is not even merged. Looks like you are
>>> sending the patch against some downstream tree.
>>
>> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip
>>
>> This commit is merged in drm-intel/topic/core-for-CI -
>> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI
>>
> 
> Okay. Since this patch is just for CI, please do not CC linux-pci as it causes
> confusion.

Sure, thank you.

Jani, is this fix required for topic/core-for-CI ?

Regards,
Vignesh