Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Quan Nguyen <quan@os.amperecomputing.com>
To:     Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andi Shyti <andi.shyti@kernel.org>,
        Andrew Jeffery <andrew@codeconstruct.com.au>,
        Wolfram Sang <wsa@kernel.org>,
        Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
        Guenter Roeck <linux@roeck-us.net>, linux-i2c@vger.kernel.org,
        openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     Cosmo Chou <chou.cosmo@gmail.com>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: [PATCH v2 RESEND 0/2] i2c: aspeed: Late ack Tx done irqs and fix unhandled Tx done with NAK
Date:   Tue, 28 Nov 2023 14:52:34 +0700
Message-Id: <20231128075236.2724038-1-quan@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHFQVTF0TXlzMkVRTHhjYmIzMTZWVWlISFNGMlFrZ1dIN2JMYllBcmw3QUhK?=
 =?utf-8?B?Z3NQbVFFVE5Oazh6cU84cWlwSERWSVl1RDFva3NpSEZWb3NkY0tBSCs1MEgr?=
 =?utf-8?B?OFdHTHByaW1hVENVd29vK1FvT2JSNkd5OXNjVGx6ekNTa0lyRDQxcERBQUNz?=
 =?utf-8?B?SytIdkJrVmducisvTTQ3OUliZ2ZKRjdjMkhyQ2JPellIRjRWL2xsVWV0a1h4?=
 =?utf-8?B?Z0haNkhtS25RODFGOXFyd1A4Zmk2a0FCbjBMNEJPWnJJdVpJNEZZc25ySHZt?=
 =?utf-8?B?azcwZGJKV3dWdXYyZllvRk41bWFxcCt5NWx6Yng3QTdqQndETm03NUNBQURr?=
 =?utf-8?B?REg3TFRESUpnTmRDbW9vM2FMWlRRRUpGQUQ4RmUxOTVTU3BDL0JldFpWb0xq?=
 =?utf-8?B?QVJyblBCMEdnOFA1WmdMR0t2ZWRoZ3h4NUN4MmpkaHdSUiswbXF0WXovQ2Y2?=
 =?utf-8?B?dVM2TjhheHBsSURoeUlRUThCYzdxL3FzcVVFT2RjRmxJczJXZXlKUGdPbmY0?=
 =?utf-8?B?dTU4TkV0a1FrbitqaDNDWGZ5NVJISG5ydEtSSjhxaWs3WnhSWmlFdGFIK2N6?=
 =?utf-8?B?OEYwNjJQRjN4L2NCdVVQQlpkbDJocGpuZjFNRm1OWTQwS1ZyOGtOSW9LNGk4?=
 =?utf-8?B?VEtsREJNL3ZxbVM3Nm04NFN3UTVjdXhyblJZekwrNE80Ri81MWdqaisxcUVZ?=
 =?utf-8?B?a3hVYnIzdDNLU3lMQ1JkdFNySXFubE1Eem5Ja0MxWmQ2blFGclZRVlJWMjI5?=
 =?utf-8?B?QWVsZEd3UzdWbG1VMmlUcGZkd0lCdnpEOEJ3YkhLaTFCbWxEcTd0cGxxODJL?=
 =?utf-8?B?UlU3VVlEOG5ZSjNLOEw4eEU0TmVkbXozdWFzRjk4QytpdFhCL0hqMGdyREpz?=
 =?utf-8?B?Z1BTdnZuaGlOeTFRS3I3bmxycnN4SERsaXl4NUZqQmdSRE1tRWFpZEU4T0xs?=
 =?utf-8?B?dWVzV2l1Qk9XMVRaL2hGT3BZNkZJRmpzMUZteXRWQy9UNEVXeExWaEZmYVkw?=
 =?utf-8?B?ZTcraXh4cDQyc3V5NG1ramxiYUdTeTJPU051OUJHWCtYQ0tZUk92UUZ6MUdK?=
 =?utf-8?B?a0FaczRwc05tSDNBMzZJRW12WDh5ak41UXVTVHlDV0VqMlU1OVQ1SVRDazFr?=
 =?utf-8?B?R0ladDRyQUFxc216aDhncGw2ek5nNlhQOVRCdE15WEtHQ2pMc1ZOVXMwaDBH?=
 =?utf-8?B?Tmt4RUZrT0NkQm9lN3VuUUxPWkZMSUlrOG1RVS9Telprd0JtOVNMRG9uNEZE?=
 =?utf-8?B?R0lWK2V6VmRubFdveGMrbEtTUmIxbXpxbW56cVpkRXk1WEt6SWxjT0dHM1Ja?=
 =?utf-8?B?QldSdG5iK1o2c25DYm1GZzY3cjE5NkYrN0c5bXJReFBnWEJzK3RaRCtma0ZW?=
 =?utf-8?B?WkxlR1hYZmE3MHNEL2ZnTVZ4VjBsbjJVV2lMRE1sbWU4ajNNbERRcWVISUFP?=
 =?utf-8?B?bENpVkl4clByM1FXQUJzVFEzYzlieC9aZWpuVnh2cDZBcFBSRHpaTUNxM01R?=
 =?utf-8?B?MTlLVTBuakNVM3lrUWZlMG52WmptQW9NdElySExCYklzQVcyKzluQk1JbWlq?=
 =?utf-8?B?SnRTVXVZaWd0OGFuUHQvN2tuZlgybUJRM0VtTEZwY2hEZzhJK3c1WEltdSs4?=
 =?utf-8?B?V3doeVlyTUE1T256andjUHJaT3VhQk0yYnp5ZFZxUE9rRVZOTW9Rdy9QcFh6?=
 =?utf-8?B?M1c1c0hRdklESEJ5MTN3czNBWk1qalR4dUdPbW1sb2pSa3pmQU96ODdNK1lE?=
 =?utf-8?B?bzFySWkwcGprWUZHSm5ONUJtc1g1T0pCWXI5UkYySThwSFd3dDUrbVAwTGdh?=
 =?utf-8?B?K2tCbFErT0FyUlY0MVJyZmp5d2NsNDlNMC9TZE9ZdDJYYTJkTGhhZlZwZDNw?=
 =?utf-8?B?MnpKZEtPU2lIVU9hUTEzK25JcDIrZnB3dW4wTS9RWmhqQ2huNzFiTGVjOFV5?=
 =?utf-8?B?SmpsY0NibWYxb3N5YW12dllJWnNIVEZWT0hZSkZ0cGdDSmVMY254eTl6WG05?=
 =?utf-8?B?ckFwKzFtb2lOOEJTMHZKL0Y4RTYxS2FFSGFRSTdZOEdRQWRCTTlRQ05xZEpz?=
 =?utf-8?B?MFFyWlBINkpORlVVNnpJSCtPYWM4L0lIbmtUSW9BQy9PTVVzTVlWUkVqMTBj?=
 =?utf-8?B?Ky9DLzkrNnZLOTBzNy9uNDY5a0ZuUHhNSUlSUHBBOWxUUy9iZ05TM1RtWGVr?=
 =?utf-8?Q?xoNJuPI0PObz8XFTbt0s7HE=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9a1de63-5b15-4a90-f891-08dbefe70950
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 07:52:58.0507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xXWCxb/6gOoZy7TCGE+RliTSmEbv2+paS6ikLgBY2O/rmYGuufU7+hkcvsMxRx0OYZq6LBcZjUk8UsK2UT++hme76QPEfJchVucpnqZeBdQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7895
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 27 Nov 2023 23:53:15 -0800 (PST)

Rebase on the v6.7-rc3 and resend the series as per discussion at
https://lore.kernel.org/all/d0773df55a6fe8a5c9b1a3d7c8dd2e1343643272.camel@codeconstruct.com.au/

The prior discussion could be found at
https://lore.kernel.org/all/20210616031046.2317-1-quan@os.amperecomputing.com/

This series consists of two patches to fix the below issues observed
when testing with slave mode:
  + Unhandled Tx done with NAK
  + Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on
  read request".

v2:
  + Split these patches to separate series [Joel]
  + Added the Fixes lines [Joel]
  + Fixed multiline comment [Joel]
  + Refactor irq clearing code [Joel, Guenter]
  + Revised commit message [Joel, Quan]

v1:
  + These patches are first introduced from this disscusstion
https://lore.kernel.org/all/20210519074934.20712-1-quan@os.amperecomputing.com/

Quan Nguyen (2):
  i2c: aspeed: Fix unhandled Tx done with NAK
  i2c: aspeed: Acknowledge Tx done with and without ACK irq late

 drivers/i2c/busses/i2c-aspeed.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

-- 
2.35.1