Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <2551d35b-e5cf-4a8d-8667-b0f6720408aa@intel.com>
Date:   Tue, 28 Nov 2023 16:00:04 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 04/26] x86/fpu/xstate: Introduce
 XFEATURE_MASK_KERNEL_DYNAMIC xfeature set
Content-Language: en-US
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC:     "Hansen, Dave" <dave.hansen@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "seanjc@google.com" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "john.allen@amd.com" <john.allen@amd.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Gao, Chao" <chao.gao@intel.com>,
        "mlevitsk@redhat.com" <mlevitsk@redhat.com>
References: <20231124055330.138870-1-weijiang.yang@intel.com>
 <20231124055330.138870-5-weijiang.yang@intel.com>
 <bbcdb8c0729b6577684f89b180cae2f5ec422bdc.camel@intel.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <bbcdb8c0729b6577684f89b180cae2f5ec422bdc.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnhEMm1RUFc5N2cyYXAvUkk3U0VrSmg2SE9vR2o4YWxTZXdYTFBITVptcGFz?=
 =?utf-8?B?N1YzcEVOZitKVUluQlVHeW5JSzhyaUE3ZTR6YlI4bHZNV0g4dGdxaDlrVkN6?=
 =?utf-8?B?OFBDZ0g4Z0ZGZ0kzd09VOTk2MXRrY2wxMC9RbzdhWXdTV3gwOFZDZ3VGdUlt?=
 =?utf-8?B?dUJLSFRYcDE5NGZOS2NleURJUm1Gbk9vbUF2UzFsWktUdzFrTk0vYjBuMXJp?=
 =?utf-8?B?NllhOXRiQTFIT2EzbTB0VEN6aUFhNU8xN05KK091OVk1aVVNN053NDhuZElz?=
 =?utf-8?B?UDlDQnhycGtEcjlrOTI1cGRnUzdvOXBTN0FBTVF2RlFrRG1zWEJPeUxoSGp4?=
 =?utf-8?B?VktoQTJoR3RueFhYWloyVm52dXFJRklQMVJJTHQwa01yWFEzcy9GaFRrV0RQ?=
 =?utf-8?B?bER5SytnZ25Yd2JSRm9uRkJuWUxaSmYxWExVOEYwdStWQnBqSzd3UlJXOXJS?=
 =?utf-8?B?WFdoeVJVd3QrOFJ3UjdnK2Y1L0p3YU00MjAzQTNpQSt5b1RxN1pTQlA5akhL?=
 =?utf-8?B?bDI2dEFUL2IxRGU0bjQ5UUI4L0JKZUpnczVIN1JTdFVHcVRRT01QWHNrcVRQ?=
 =?utf-8?B?Q3FyUEtRaXQ1RGtqNUFOYm5nVUVjam1rYkR2U212N1lrL0hHRWdHY2lRaVEr?=
 =?utf-8?B?MjRKVXpDaEpodWV6YURVMmRjZzNWNDJwS3lSMFFHNU95TlowcEFzNDBNeVF0?=
 =?utf-8?B?UDBlMFNMbmV1RDU5MHFBeFlpSG90bnVNSHFJYWJJaTVVcE1TdXp1T0xHamhp?=
 =?utf-8?B?RGdqNGpLOFJpOHZ2OVhBajJFNW12TVFvL2MxS0lQby9DNDRlUkw4a2x5OVFr?=
 =?utf-8?B?RlVQcEhyby9RcnNqMjZoZVN5R1FSMlgrWWl3NEhJbTRqZGhyTVRiZFU1WmRT?=
 =?utf-8?B?cDhOdVo3UzhpVkQ3SGUrUXV6MllzbEZlbVY0OEt1RkJYSkhtYWU4aitEaVFr?=
 =?utf-8?B?aE91REhnV2NGeWNhMk1rVURHMk5OUVRnUzRyYjl3dnJMaDh5eWFrY0dNelJz?=
 =?utf-8?B?ZUVOcHRodERnY0lQMEhiemRpZk5VNGhiTmplUGlmQzNXd0ZJNmVnbXNTZzJT?=
 =?utf-8?B?U1lzd20zenJ1OUVtVk9oSnd0VHZ2RGlNb2x1Q1ZLQnBwdTFEcjJRV1hvaU5U?=
 =?utf-8?B?RWJBR3dNK015RlpUSlJUSkFUcnVLYVI2UlhTMzlrUGRmZ3cyVFBDbmx0cnZ1?=
 =?utf-8?B?ZUhJdlNDSjYyYk9IaW1QUlc0NU1sNnRMWnQyS0IvMG11QndjR1oyUWRtWFZ6?=
 =?utf-8?B?RnEvU3krbkJMUWM1ZVpMR3JTM2ViNGJTNVNPczhKRVIrN3NlS2NxSUUwcTJo?=
 =?utf-8?B?MFg1NWk3cmZ3WldmbmJ0M3FQVTd1RWMrRTl2dUVpcFYwLzdOZ0JEeFNHTjla?=
 =?utf-8?B?Z2tmZzFpcTdiTy85d3czbFA3Vkp3U0NPcm1hai9FeEM1dXBzZkpOc0drN1FT?=
 =?utf-8?B?RTE1MHo4RStWcVRRck1yZUhCVEEwWHRNTUFoc1dDUHJMeTQza3ZISU9IUDBQ?=
 =?utf-8?B?cGJTdm1Xb1k5ZWxUVHZFTTl2dnkvT01JaFF5UjU0QmhoL2h4dnA3cVA2OWhD?=
 =?utf-8?B?ei9RcnBMcnU0Rlc2SjdLeXVSb3pqTmhoV3FPNTJlamIyM1I0bHhQNzcxcjNz?=
 =?utf-8?B?OFFkdzZ6Q3hlQVE0eUlEclhWaHBMOEhrUVNUdnE3a1M2d1dBcTk3RVBNVFZx?=
 =?utf-8?B?dFlJRFZaRCsxZmtjVWd0SkJldHUvV25Yd0RUdDBtbTVOSVRwUUwzeG1GZGVH?=
 =?utf-8?B?N3A4aWFEM3FSNU96cTNqNEh5QTVVeVBTaDY4V0tOUVhqUFI2RnR2MFF5NFlh?=
 =?utf-8?B?dmJheGY5a3JYc2RCZ0J0YkJ6b1R3RW1RUUN2Yk9qTjd1aFpKK1ZlbkJoNGFW?=
 =?utf-8?B?U2Z3c0FQb3Q1cWEwajNBeVN1ZnpTMVBpSXVZWjVuL3BteWJKYytxT2g1S1NG?=
 =?utf-8?B?bnlpMStreFA4VVNzckJvQWhCT2g3UjdEd3BJMUl4SzcvU1VETGlWRXRlTitm?=
 =?utf-8?B?OU95ZFFpNFljNEI1ZnpldHNuTnlSZ0d2VE5EM3BINTExYTRvQmxqMzd1eFZw?=
 =?utf-8?B?K0R1dnlpMlZuOWl3bWc3RVdPOUlkVlFxWS9iUUFzTTlnN1Fzc3lFZFhUdldj?=
 =?utf-8?B?OWdNTTUxNkFLZFk4cS9XT3pzT3E3SFQveHFRT1JLbzF2a0RISmtSbktJYjJM?=
 =?utf-8?B?MkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf024115-109c-491a-0ff2-08dbefe80d00
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 08:00:13.5644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2+xI52twWr817KnlqrQ8oNqQ3pphPJGJCF4M+6h8lg8bXodSKjfYmdUmC+Sjo+3H2hfEu/vNC0W8WWuUAeD7RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7392
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 00:03:18 -0800 (PST)

On 11/28/2023 9:46 AM, Edgecombe, Rick P wrote:
> On Fri, 2023-11-24 at 00:53 -0500, Yang Weijiang wrote:
>> Define new XFEATURE_MASK_KERNEL_DYNAMIC set including the features
>> can be
>> optionally enabled by kernel components, i.e., the features are
>> required by
>> specific kernel components.
> The above is a bit tough to parse. Does any of this seem clearer?
>
> Define a new XFEATURE_MASK_KERNEL_DYNAMIC mask to specify the features
> that can be optionally enabled by kernel components. This is similar to
> XFEATURE_MASK_KERNEL_DYNAMIC in that it contains optional xfeatures
> that can allows the FPU buffer to be dynamically sized. The difference
> is that the KERNEL variant contains supervisor features and will be
> enabled by kernel components that need them, and not directly by the
> user.

Definitely the wording is much better,  I'll apply it to next version, thanks a lot!

>>   Currently it's used by KVM to configure guest
>> dedicated fpstate for calculating the xfeature and fpstate storage
>> size etc.
>>
>> The kernel dynamic xfeatures now only contain XFEATURE_CET_KERNEL,
>> which is
>> supported by host as they're enabled in xsaves/xrstors operating
>> xfeature set
>> (XCR0 | XSS), but the relevant CPU feature, i.e., supervisor shadow
>> stack, is
>> not enabled in host kernel so it can be omitted for normal fpstate by
>> default.
>>
>> Remove the kernel dynamic feature from
>> fpu_kernel_cfg.default_features so that
>> the bits in xstate_bv and xcomp_bv are cleared and xsaves/xrstors can
>> be
>> optimized by HW for normal fpstate.
> Thanks for breaking these into small patches.