Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
Date:   Tue, 28 Nov 2023 09:36:27 +0100
From:   Michael Walle <michael@walle.cc>
To:     "Boyapally, Srikanth" <Srikanth.Boyapally@amd.com>
Cc:     Pratyush Yadav <pratyush@kernel.org>, tudor.ambarus@linaro.org,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        "git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g
In-Reply-To: <BN9PR12MB51966705C3E306502ABABA6E9EBCA@BN9PR12MB5196.namprd12.prod.outlook.com>
References: <20231123054713.361101-1-srikanth.boyapally@amd.com>
 <mafs0jzq7dx8l.fsf@kernel.org>
 <BN9PR12MB51966705C3E306502ABABA6E9EBCA@BN9PR12MB5196.namprd12.prod.outlook.com>
Message-ID: <6342ad8a798ef811d37775b7269623a3@walle.cc>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

>> > Add support for issi is25lp02g.
>> >
>> > Verified on AMD-Xilinx versal platform and executed mtd_debug
>> > read/write test.
>> >
>> > Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>
>> 
>> Based on a datasheet [0] I found online, this flash seems to have 
>> SFDP.
>> And since you do not add any flash specific fixups, it likely does not 
>> need an entry
>> and would work fine with the generic flash driver. Did you try using 
>> that? See [1]
>> for more info on contribution guidelines.
>> 
>> [0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf
>> [1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2-
>> tudor.ambarus@linaro.org/
>> 
> I ran mtd_debug read/write tests on this flash, without adding flash
> entry, it worked fine for me. Please ignore this patch.

Great! Could you please still dump and post your SFDP just for us to
have more SFDP of diferent flashes? See [1].

-michael