Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3695955rdh; Tue, 28 Nov 2023 00:56:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlLgvX1xa8gGV1czteY/4aZAo/OznrE3M9VwGWD7HoBWwl+s2H53IAZaEHafJHkKmPG2Ag X-Received: by 2002:a05:6359:5c25:b0:16e:3099:847c with SMTP id pu37-20020a0563595c2500b0016e3099847cmr8372793rwb.9.1701161793129; Tue, 28 Nov 2023 00:56:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701161793; cv=none; d=google.com; s=arc-20160816; b=H281wUcYVFKqYpf+WrYwrBg5Z3fE0RwIMS5cn3RIv/NINpJtIHDhlClKbOSImv+mcF Z2AnzTQFc5gJBLsiy7Z4gjLID1fW+tkK+LuUmI2SsAGxOi9wDDaGS8uEeRCArYPaBKj+ tvLb0Q9Zq7daegM66H6vO5WcqHPDvIDyLfC/HOL0AhKEUUph/mCXmwu+fh8RyPyrUKG1 vIrFAy3hAPkieuREPWg2T2h0B8KfnPK1xZUFhx6S933GrzpQH+5DNs3dy76LCAkOD5D4 PYqNrgCcdZ0zKaeXoXpIsBc+AOuhTs9hY0aQTMBB/s6UWl3RDLWA4FEei9qHQDpsHupB UUKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=inSLQuIwWYGDF/gh2N0AzwknQ+Wcq8CsubSj0P9B5nc=; fh=h23slsdwTG1cNPJRU0na/tQ/HuWA5P/B8+YlwrZXN6I=; b=SNBsGDjsqOV1/1zcLUWz+nM/GpDO3dc0yz2sZveuDQwDoo5U92G99dASUXmk3d6Eqs pexyYWRII6qZLPGh6c77kqRTUvhUF01aVO0QJzi2UkfeZsoPAQdRtkHJpW+C3YWzyJ0o C9YliaBhURiUjgroXizdoN0Dx4L3ENhPiXKhlBz7ox+ZFR9CEJV2+hOHbqebsbwETTG0 P6VIyarQC+69Uxu0KhBMd1XDoFg7K2H9Fl5xWEmyQJkoaZUahJaBiCHwQxAKiSAFFEuE iAH0+zPmudaeyUQy0OI759HqbCAsNe1ZSHLZEFw7BYTY3kfh+E2N0PJJbXTsHmr6z+Zx kANA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wlWUD2LH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id t3-20020a63d243000000b005c1b313a127si11522677pgi.660.2023.11.28.00.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 00:56:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wlWUD2LH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 0DDF3809A770; Tue, 28 Nov 2023 00:56:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344204AbjK1I4P (ORCPT + 99 others); Tue, 28 Nov 2023 03:56:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231902AbjK1I4N (ORCPT ); Tue, 28 Nov 2023 03:56:13 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F834A7 for ; Tue, 28 Nov 2023 00:56:19 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a0f49b31868so252212466b.3 for ; Tue, 28 Nov 2023 00:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701161778; x=1701766578; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=inSLQuIwWYGDF/gh2N0AzwknQ+Wcq8CsubSj0P9B5nc=; b=wlWUD2LHKqyo4IO/ioda3Oi0fqiinBkXHVyekhKWDj5bKKGU8piJkgtWQkcJGodpO4 juv60TysUcZfmBXIo8uxQbTaHFQaVgyo+Go+uH7xIaEyOYvomP0RXcRib6LWVP8vAZap 2n/qbxtl4t3zizbLrkS7NsToQKQRcE7Y0VstyOHJw4viimLz3elEI9A6dUoQchyRC+z+ cfCXL7iwiaXzppkGUS+dFDBFS2m+qMNlYD8c8wmMptBQUFh8qonmt/2x72N2kpq34YJY w45B1I2eO/0NXhA5EIlk8kQpMvCF2rjlIRvZzPGDZmO20qHzAq64xwwKoIvl3cmFhWQL 7qeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701161778; x=1701766578; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=inSLQuIwWYGDF/gh2N0AzwknQ+Wcq8CsubSj0P9B5nc=; b=ahDEGrAxRRm76jFHaWIZgwkffpxdAvQ6VvxxcEVzJR+O9jjXgyfVgi99YGfiNl+Uei SLV/QYPtcfczHWNxHyvRaFpbpyuvFcBEXtRh+n81D1WXWKr+JQyRRr58dWjicnpa0zf4 JouvHmqS2JgR1giuqi1JCeN9QTggJjMezdKOvprXJqvJ3Vztu77hp3Dd97sk5MjvrehR B0DJ3nMr8CMXwbguSzO1I8mHcPnhRNqXBjCzD4ZoRdFtsqVySjMRnza/GbGaDapJM4uY h4TY21MtOhcErWX2i0L7XKWiPHzyvuJkqsDG+ymtoyGRRBzTt5bwVM3EBl0cMJeWdLU9 Isbg== X-Gm-Message-State: AOJu0YxqBI3p6W3iobS4+/IGLHNHm/S4FyVXmZP+4N5fE2M70WFVWNPP ngQCQLvDeP6K2eMnfUm/bwPuQQ== X-Received: by 2002:a17:906:2c05:b0:a04:7e4d:6c19 with SMTP id e5-20020a1709062c0500b00a047e4d6c19mr10280551ejh.68.1701161777870; Tue, 28 Nov 2023 00:56:17 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id h21-20020a1709070b1500b00a0180de2797sm6606124ejl.74.2023.11.28.00.56.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 00:56:17 -0800 (PST) Message-ID: <78815f1b-7390-40de-8afd-ac71806f4051@linaro.org> Date: Tue, 28 Nov 2023 09:56:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property Content-Language: en-US To: Krishna chaitanya chundru , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_vpernami@quicinc.com, quic_parass@quicinc.com References: <20231127-refclk_always_on-v3-0-26d969fa8f1d@quicinc.com> <20231127-refclk_always_on-v3-1-26d969fa8f1d@quicinc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231127-refclk_always_on-v3-1-26d969fa8f1d@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 28 Nov 2023 00:56:30 -0800 (PST) On 27/11/2023 13:13, Krishna chaitanya chundru wrote: > Document qcom,refclk-always-on property which is needed in some platforms > to supply refclk even in PCIe low power states. > > Signed-off-by: Krishna chaitanya chundru > --- > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > index 2c3d6553a7ba..c747c9f35795 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > @@ -93,6 +93,13 @@ properties: > "#phy-cells": > const: 0 > > + qcom,refclk-always-on: > + type: boolean > + description: In some platform where PCIe switch is connected, pcie switch due to some design You received a comment to use proper wrapping: 80. Please implement it. > + limitation fails to propage clkreq signal to the host and due to that host will not send > + refclk, which results in linkdown in L1.2 or L1.1 exit initiated by EP. > + This property if set keeps refclk always on even in Low power states. The property name suggests that's the state of hardware - refclk is always on. Description suggests you want to instruct OS to do something. Again, third time (once from Bjorn, once from Dmitry), rephrase property name and description to describe the hardware issue. I see description improved, but not the property name. Again in the end of description you say what Linux should do. Bindings do not describe Linux OS. Best regards, Krzysztof