Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3706266rdh; Tue, 28 Nov 2023 01:17:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmxRzAURQ9ZuSzLQuFLK/sW3PAKlZbILCwq4p5PWHM7V7XXs7NHb2z5IRXDncoHof64w0k X-Received: by 2002:a17:902:d50e:b0:1cf:c518:fa3f with SMTP id b14-20020a170902d50e00b001cfc518fa3fmr7166943plg.35.1701163026561; Tue, 28 Nov 2023 01:17:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701163026; cv=none; d=google.com; s=arc-20160816; b=O13j2EaVj+qmRV5gZoN8bRQWGjfb6z45MIVQY7oVWoCm/586P5LN5G5KZ04sbF59xw ZLmMqW/uDM8HoWntO9GyRRiav0pQwB4ld9/dQY8uXFqXsm6OKlK5LmlEjxOl7iOhG5UK 2EPFz0NwDhnUzWipp8d5awREKefqKlQr23Lg0ZW9JIJ6CaKqtSAcFhosYrZO9l6J+tgf t1MqcvGWnR/xMhITgHdsCp04zBd1qRSuFky2EtccX4XV8LeoIE2MIG/7sKpWuCXQpBmG o7xqm43Hz5RE5GHeLF6aIGxrGv4Ea/H37DYwTbW8GSpQUrEMr+UicFtFy1dVB+/kxdkG pn4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=e/GZH4iKHmdxig0N07S7KzuEnC/AIpMsERMKIZU3oss=; fh=EikJm6u1wroKoHf9g/h/0iIaHMhq7iHdQg2I7l1kvSQ=; b=QOXRVYwrigksdClg7+IVunIhtWQqRgxDXVRAh4F+omtTtExOREQtXH8CCbNbXMEeUP r2HvsZOW3RqQVJrdAt6X3kjCPmur/oPckll2eyjdCJk9T7iAQewjaRsIwZak0X7CmK+J E7VjELHl1ME6BWDmgTPS/9isuJVSA25fP6Uqxq6rGAkyfT2n9RjSgX0h0OP3tGAAw0xG u+eC574x8wi9znfMsNiNLddfbg7DiLFdbPe2ZdsXM7qOO0K30+GoyA6CC7CL/C+HNZXq VXpLCFCm7UnnfKIRH0GMXodYuIewC0cuHeRa8UieTVKH+zwcFVKY6uyUN2zwz4fY7aI8 o2xQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id ix9-20020a170902f80900b001cfa17ec30dsi9822962plb.508.2023.11.28.01.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 01:17:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 13791807C865; Tue, 28 Nov 2023 01:15:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231645AbjK1JO4 (ORCPT + 99 others); Tue, 28 Nov 2023 04:14:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbjK1JOz (ORCPT ); Tue, 28 Nov 2023 04:14:55 -0500 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9B0BACC; Tue, 28 Nov 2023 01:14:58 -0800 (PST) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1r7uBE-0007T6-00; Tue, 28 Nov 2023 10:14:56 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id A4070C0136; Tue, 28 Nov 2023 10:00:24 +0100 (CET) Date: Tue, 28 Nov 2023 10:00:24 +0100 From: Thomas Bogendoerfer To: Wujie Duan Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Mark symbols static where possible for mips/kernel Message-ID: References: <20231128071225.801111-1-wjduan@linx-info.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128071225.801111-1-wjduan@linx-info.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 01:15:11 -0800 (PST) On Tue, Nov 28, 2023 at 03:12:25PM +0800, Wujie Duan wrote: > We get 1 error when building kernel with -Werror=missing-prototypes check git grep setup_sigcontext arch/mips/ With this patch n32 support doesn't build. We need a prototype in a header to fix that. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]