Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3716214rdh; Tue, 28 Nov 2023 01:38:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBqKCWZVU8NNr22hYa3BRM0Q2zJsoQJn+hNorwvmRGuEYWAdarLwFLJ7WYq95MQlTWVqw9 X-Received: by 2002:a17:90a:3fc7:b0:280:37a0:69d4 with SMTP id u7-20020a17090a3fc700b0028037a069d4mr25309078pjm.19.1701164335269; Tue, 28 Nov 2023 01:38:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701164335; cv=none; d=google.com; s=arc-20160816; b=KtA5Mce9YG9MhYC200TDB0fYVJMDup8JRtesJ5CJRafOtUUju1STSq4Hhr9gEcWHjF 8HqFRyTfogrCpXIbLzvd9dEOyrIC90SBstuMcAxCGycIBzc6nCdmWwFWpprRVG+1caaW FGk/X4S+6U/QzVklUVOTbX1rBUaeWlPPDcbLn5N75XIcIEJFoW/uNiSzUrl7loTegzAX UE9/eHx5IRVF3VElSD4HBTVdLK137r/2C1jbvgFgen75uBPTCTRYRDVWVNJWVxYK42bk U7sxiKSdvirkPrPw+MwxmUtEtanU6wt1eN6R/8oZY07C8Eop1UzGAqxXQTEUU8NwoQvP 2OHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+KUlvMVVq0kzWkSg0J1DwGMUzVoldnKYXOLEGIYlAks=; fh=rPMi8sJdK0AmEAoB9tDFuXt9Fr6fed5QUNqK80Y+mf4=; b=YA9dd4KaxfrZcH+iSVlVZLPOULZ1N0Tsm/I+qq0cwRvV4Fc/BzS01yuV9KIMv7oUyW MhEXJcL4MQ0imWadk7MC4C7wwnuWXppjsbLNcwYgY4YcN1pYImOT4lkiPmdH7rJAPWKm 58HFrAuyKveEaVM6LUJZdnKTQJtdaIio/wB3hoGUkAg7d9ohPGZX2k3GNYYqNHlBg3Jl /3Bd768U40/xzgIFyZUw/sk2SUbAzBvdNtyAe6hH89S9u4hgebMY8RgXYDqde9tCczpq XmL74nO9KCc913XN3FvIBsfU39mEju9gepd/h481eeYZm66CTgcPtcZ4O8xadTuTHXPG c/9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=cAWK9vir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z20-20020a17090a8b9400b0028017a2a8f5si11704894pjn.121.2023.11.28.01.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 01:38:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=cAWK9vir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1CDBB80A07FC; Tue, 28 Nov 2023 01:38:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbjK1Jii (ORCPT + 99 others); Tue, 28 Nov 2023 04:38:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbjK1Jig (ORCPT ); Tue, 28 Nov 2023 04:38:36 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ABD8A3; Tue, 28 Nov 2023 01:38:42 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2293821989; Tue, 28 Nov 2023 09:38:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1701164321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+KUlvMVVq0kzWkSg0J1DwGMUzVoldnKYXOLEGIYlAks=; b=cAWK9virywTZ532MDIgO1gy44OyyHrGCDU3wFS4vwwkNsW/vKW1ledm8n6gZv1rRBCK5ny TGnyw24WV2gXW3ycdO9GlCA3lf2XXWbkgTirCzOlLMWXWGyWWHV7V6juL75W9SKAKHOsKJ SjyuFMC7qaohToamRE1g+RCeRp6vxrA= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F25001343E; Tue, 28 Nov 2023 09:38:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 23klOCC1ZWVtYgAAD6G6ig (envelope-from ); Tue, 28 Nov 2023 09:38:40 +0000 Date: Tue, 28 Nov 2023 10:38:40 +0100 From: Michal Hocko To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: Re: [PATCH v6 2/6] memcontrol: allows mem_cgroup_iter() to check for onlineness Message-ID: References: <20231127193703.1980089-1-nphamcs@gmail.com> <20231127193703.1980089-3-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127193703.1980089-3-nphamcs@gmail.com> Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -2.02 X-Spamd-Result: default: False [-2.02 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_TWELVE(0.00)[19]; FREEMAIL_TO(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_CC(0.00)[linux-foundation.org,cmpxchg.org,gmail.com,google.com,redhat.com,ieee.org,konsulko.com,linux.dev,kernel.org,kvack.org,meta.com,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.42)[91.09%] X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 01:38:52 -0800 (PST) On Mon 27-11-23 11:36:59, Nhat Pham wrote: > The new zswap writeback scheme requires an online-only memcg hierarchy > traversal. Add a new parameter to mem_cgroup_iter() to check for > onlineness before returning. Why is this needed? -- Michal Hocko SUSE Labs