Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3724248rdh; Tue, 28 Nov 2023 01:58:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbqbkNI4Yi+aNxBHqVp1UfDtGyqkJwsglaf4Z7xSOPYdWXYkJt3ZNSzH+GfeyZYADqu+1i X-Received: by 2002:a05:6820:513:b0:58d:6217:795e with SMTP id m19-20020a056820051300b0058d6217795emr12225627ooj.8.1701165538577; Tue, 28 Nov 2023 01:58:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701165538; cv=none; d=google.com; s=arc-20160816; b=Dbunn5gnT9q7PJAvqZcPIQoLNN+xdY6T4nYhS51F6IET8GruYxz3ssSv72rhBpP8dM 5dGaEjhZ1iHK/zQHhGv0AHGY84OjPXJH4MiFdtY6jlQyLJ8ZjDFYzUDTFXAYQufcHljy /1xpuGTj+2V/taDvlwPBAb3NEXS8tycdOBq4oDCPRjpdFt8ODv0a05DzPRxysXcmlV60 l7hJf1S9U4WoAtn49Obx8Wl/1EHIBT5a61ivKrCyXLyhhNmLNrQoPPKmsnWs20ZK+zBz LfwgtO7S3UI4238BlBZPT87MLGAggzv+ygndE1RvclYfL3ud/t/ApZfkQ0z0tk2CQj0j p9DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=YWKTVLdme9OGNnTVCcJO/hAJ3cVQ/p49zW0GCrV6m5M=; fh=Fa7MwpiRiKHvHC/prTq1HViSLYGqe02zCL1nve5+2po=; b=G8EFxsA4P+UMuRVzhfBkju8WkSFsTb1PsJai697QzDMXzppdD/jz0lER8+cTVGcYT1 nKRdbREtv2B2UYDRJSP0lN5rNNjBWawdS9kP7vcQBsFxAL+wZojDJkmgYULHBKpWRvuH D+2DD0GuzA8kFB8P51DKEVVikjp80wJrhxG7e5+m0GWRiCEOlbUEM58zBhInLsfonqam 9dZ12CeDLra0WUuWTxnRiXQrH5yITEngF42D4fN0dszQja33nllUOkApAyY7g86mpCmO u4XzhU5CNf9DxfFQwVNfJpvG+VGQq/F22/KBaWIo1A9fRVPfcg7hASTDryx5HNTMsL9N blGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tkDLR5C3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id l3-20020a63f303000000b00578a98c0687si11994428pgh.99.2023.11.28.01.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 01:58:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tkDLR5C3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 67581804C51E; Tue, 28 Nov 2023 01:58:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233003AbjK1J6n (ORCPT + 99 others); Tue, 28 Nov 2023 04:58:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234660AbjK1J6j (ORCPT ); Tue, 28 Nov 2023 04:58:39 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 148CA1A1 for ; Tue, 28 Nov 2023 01:58:45 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D01DC433CC; Tue, 28 Nov 2023 09:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701165524; bh=LcD+ldJkLkGq0ZEQhTcLuS/VhjTh8l+OCqrr7fSArpU=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=tkDLR5C3UywF0mRe344TagJiExVImW2+HXTOqoplnlCrUQo5sdUm1i9DjueHX3YDz 3nv1aMCXbt4hN/PDbPWVrWxN1wPWaqDWikrnZrR3BYARa7jLvPwPJaa1fwNhmG4OEI Ote3rT5wZ/OEjNeIyZ8HWo9GFL0HxXp7CrAOd+eDxdass5Hqd/XrchHswiCYAVeoHo A/xNwhLHpDH4AJwwR6zcOmVnLDZ/0ehnVsajl8QVNZo6zZxYtL5YOW7IGi7ccBuV1t 16ckgqvFfB5BlajCu27yvklYUCO5t/iVTn7hsOuhQgasPvV4AgE61DwzbNt53OIfkk XSufqXVZPvF7g== From: Vinod Koul To: linux-sound@vger.kernel.org, Bard Liao Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com In-Reply-To: <20231127124735.2080562-1-yung-chuan.liao@linux.intel.com> References: <20231127124735.2080562-1-yung-chuan.liao@linux.intel.com> Subject: Re: [PATCH] soundwire: intel_ace2x: fix AC timing setting for ACE2.x Message-Id: <170116552221.73476.13450222254446640671.b4-ty@kernel.org> Date: Tue, 28 Nov 2023 15:28:42 +0530 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 01:58:57 -0800 (PST) On Mon, 27 Nov 2023 20:47:35 +0800, Bard Liao wrote: > Start from ACE1.x, DOAISE is added to AC timing control > register bit 5, it combines with DOAIS to get effective > timing, and has the default value 1. > > The current code fills DOAIS, DACTQE and DODS bits to a > variable initialized to zero, and updates the variable > to AC timing control register. With this operation, We > change DOAISE to 0, and force a much more aggressive > timing. The timing is even unable to form a working > waveform on SDA pin. > > [...] Applied, thanks! [1/1] soundwire: intel_ace2x: fix AC timing setting for ACE2.x commit: 393cae5f32d640b9798903702018a48c7a45e59f Best regards, -- ~Vinod