Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Tue, 28 Nov 2023 10:59:45 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Kent Overstreet <kent.overstreet@linux.dev>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] shrinker debugging improvements
Message-ID: <ZWW6Efq6QAEQwsnl@tiehlicka>
References: <20231122232515.177833-1-kent.overstreet@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231122232515.177833-1-kent.overstreet@linux.dev>
Precedence: bulk

On Wed 22-11-23 18:25:05, Kent Overstreet wrote:
> This patchset does a few things to aid in OOM debugging, in particular
> when shrinkers are involved:
> 
>  - improves the show_mem OOM report: it now reports on shrinkers, and
>    for both shrinkers and slab we only report the top 10 entries,
>    sorted, not the full list
> 
>  - add shrinker_to_text(), for the show_mem report and debugfs, and a
>    an optional shrinker.to_text() callback to report extra
>    driver-specific information
> 
>  - add extra counters for the shrinker_to_text() report
> 
>  - implement shrinker.to_text() for bcachefs, giving an example of how
>    to use the callbacks

Could you expand some more about all these? What is the additional
information you can get and how usable that is? Some examples would be
really useful in the cover letter to establish grounds for the
discussion.

/me is looking at patches to find out more.
-- 
Michal Hocko
SUSE Labs