Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <812f7729-1e48-bdcf-18be-c94c57f5e5f2@intel.com>
Date:   Tue, 28 Nov 2023 11:25:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] checkpatch: don't complain on _Static_assert and _Generic
 use
Content-Language: en-US
To:     Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
        <linux-kernel@vger.kernel.org>
CC:     Jacob Keller <jacob.e.keller@intel.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
References: <20231127151847.52945-1-przemyslaw.kitszel@intel.com>
 <bfe9cc37ea78bd7833d22e5859495929cc896fa3.camel@perches.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <bfe9cc37ea78bd7833d22e5859495929cc896fa3.camel@perches.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnQ2SWwxVTkxdmFkNVBSTmFsdWNRWTVhczh5cERtcENVdThxUDF3TmVvYmNj?=
 =?utf-8?B?NlJJcGtDRFVaOVE1RU0ydDdQT052dytNQVJoWmhEVjU0VHFJYVRzZFRTNm5O?=
 =?utf-8?B?SmdjRkFWRU5xakk1OEQ3ZEdZejNCSklYcUpRWGV4OHdMalk3ZHpIVTVVMi8r?=
 =?utf-8?B?MTBBbnR5TFRLQmRNR3ZFK2VOUUNUVW9RYzY5dVFwR1FsOFdrbUVvQmZDWmw1?=
 =?utf-8?B?bVBhU0R3MzR0ZHhYT0hIY3RUYU44Yld1VkJ4UTZkM1BGSCtjenE1ZUtkTHVz?=
 =?utf-8?B?STl4c1NROXBtMHRNbUdqZ0RoRVVjMjllcmwxM2ZBemx1ckpBM3d1Y0NHR09a?=
 =?utf-8?B?RmNyREN3V0I4dDcxU3NkTjg4QU9hbFZrU1BGODlybFdPVllQdWpROFFpWUIx?=
 =?utf-8?B?blpTUlJScnpjeEFkejhMSnVtWHlua3hIWmQ4a2N0RUlvMEpFU1I4WDUvMllh?=
 =?utf-8?B?WVYwdkM5NFo4NTQ4ZnJUd1g5SC9DZUt3anRUdThHL2w2bnBhZjZEallMWkYr?=
 =?utf-8?B?N0VTaWFHdVJ1U1NkMkE1a3RKSGdaMmJBdG5sNXJTQkRyS1RiZXpBN0pGQ0N4?=
 =?utf-8?B?WWswR2dNUjFMQkh2UDlhbXhjUklpVGVnQXkwL1B1VndrWFQ3b0lhV01xdTdj?=
 =?utf-8?B?TlJPNW13b3JiZlV1NlhtL0FzaElvRGtYZXhyK3RKbkl2MHdPNHA5R011RUEw?=
 =?utf-8?B?Mm9GWEZnSnMycEI1Um03a3l4dzk2RWN6MjdvQjdBMUN1VUV5WHQ5K3V4bEVB?=
 =?utf-8?B?NzdKc2Q1UFZ2VkFwUEY5VGpoZjNLdnlKTmcxNy9TUmQxYkpycXBOT0N0YVZQ?=
 =?utf-8?B?VGFndnEzbFZaeDhpREpkU1lDckZBb2lpZk52VTErWEZHSFR3TWwraXRsR2JK?=
 =?utf-8?B?Ump4Yng0WWV6UE43aWpCYUVjYUd4S3FLakxBcEFPSVNXRS80TXNIWW1wTmZ5?=
 =?utf-8?B?WEd3RXROVDZCbDNHY1BNdGdmTXBxdnN3MlovWVhKaFhraUJoSjRvbHNnbHYv?=
 =?utf-8?B?WGE4Z3NrY09SK1hKYkdXSzlHSGJJdGJVeU5hRlRwMlExWWdYYTZEVm92WWJP?=
 =?utf-8?B?U1l2dlFkVmkwNkt3MzlIOGcyNytOMXYxeEFYcWgzeHVTUTNSRTdtS2d1K3FV?=
 =?utf-8?B?NmZ6aUpPb1ZZMzNxcTF4TjRTTEJES0Z2cHpsTU5qK1lyV1AvT3Y5eGdoT0Vw?=
 =?utf-8?B?R09uVFZub2RkZm9nRC9oUjRudGFpVDJ3MXhtN1NaVyt3WWEycHZmM0Yyazl5?=
 =?utf-8?B?cDMwUXdCb3NNTElWYlo3MmNab1d2Z1ViS2hBMTZBa25uMUhQQ0FzM2FScVcz?=
 =?utf-8?B?TFZXRUM2akRKNExHVkVEc3E3MVErUk83UFdYSTZlOElKdTU3QWRxc0V0ODlZ?=
 =?utf-8?B?Y0E5aWozWEJqcEw5d2ZZclM0cGIzTndUMGQweFEyeWdTd0p1ZTY3T2FDYWMw?=
 =?utf-8?B?WWtLbk1KVzZqNUVzK3FtUFQyQXd0TW5DQ3pMNVE1c2hXVE9zdWI1L2RCU3RL?=
 =?utf-8?B?VHZyQ25VWHJDb01yamFVQ3pqVVNHbGl2Z2V4ZEVaM3Y5cnNvZ2ZQbDZaYjZG?=
 =?utf-8?B?T05aZmpCUjNuU2lidnVuQ0JlMHV6RGxNNDY4NXkzbTE0QmdtZ1FYT2QyVTg3?=
 =?utf-8?B?YWdFdmgvVmZhWEI5WFJ2bGhUMmpJb3RYcWJta3FoOHBvM21SNEwxZzBSL05V?=
 =?utf-8?B?MVF4c0FVTC9IR1p4ZStxZlp2VFo0dUdnMnRud1V2M0JiaG5aK2IrUHc1aVpX?=
 =?utf-8?B?NEVOc214c3J0NVA4ZjcyZnEvS2xNNTNsZHk0azVxUXBEVmRxcVU2VkJWeVQv?=
 =?utf-8?B?bHBrQzgvVVlrOXZ1dWV5d1d1dTZnemRFazFFSnVkblJma2ZoMkp0VU4rSktY?=
 =?utf-8?B?enBHaTQ4VHo4RGViSHR2ZVZ6UVFzeEJQMEkzWGVoRFRoZzBURkVabEhxR29r?=
 =?utf-8?B?R1BBZ0VnMlhGMmlHM1lucWdlTVZXS0JkMit4cDZJV0d1SXZKdVZwV25YNndD?=
 =?utf-8?B?VStGdTBnelpnUWJyNUIzUUk2SUpDRmJTc0ZWYkoxclZQb0wzc3BZSG9zUUho?=
 =?utf-8?B?cnJrbmNjVkp2VTVVZDVXZzFacXhXUVV2RVAvR3BsNEE0SjR5dndxZVZZMnhX?=
 =?utf-8?B?VmJrN0NNajFaNFprc3JzVFVJVTcrQjVqTUhmb0tQVmNYMWltcmNwZzg3ZjIv?=
 =?utf-8?B?ZWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eaabe343-990f-4bb2-507d-08dbeffc51c5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 10:25:18.7978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zc3NKazacvQUGjnZSRXwwNJl/Jv8kCIPhbFP589LmGSvQf5U19TJObShsftYwzNv1KBMtDeZF517kUUzBoz3fAWcvxCvSM2xJOZp53Jjn3A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7612
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 28 Nov 2023 02:29:32 -0800 (PST)

On 11/28/23 01:46, Joe Perches wrote:
> On Mon, 2023-11-27 at 16:18 +0100, Przemek Kitszel wrote:
>> Improve CamelCase recognition logic to avoid reporting on _Static_assert()
>> and _Generic() use.
>>
>> Other C keywords, such as _Bool, are intentionally omitted, as those
>> should be rather avoided in new source code.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -5839,6 +5839,8 @@ sub process {
>>   #CamelCase
>>   			if ($var !~ /^$Constant$/ &&
>>   			    $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
>> +#Ignore C keywords
>> +			    $var !~ /_Static_assert|_Generic/ &&
> 
> You'll need
> 
> 			    $var != /^(?:_Static_assert|_Generic)$/ &&
> 
> to avoid words that contain either

you are correct, thanks

also good to use non-capturing group :)

I will resend after usual 24h

> 
> 
>>   #Ignore some autogenerated defines and enum values
>>   			    $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
>>   #Ignore Page<foo> variants
>