Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Tue, 28 Nov 2023 10:59:44 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Nam Cao <namcao@linutronix.de>
CC:     Jia Jie Ho <jiajie.ho@starfivetech.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE
Message-ID: <20231128-grandma-guru-4fc6e6950a75@wendy>
References: <20230525061836.79223-1-jiajie.ho@starfivetech.com>
 <20231128102722.fQizGKfo@linutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="omVPbJ2Lyr3mnpXp"
Content-Disposition: inline
In-Reply-To: <20231128102722.fQizGKfo@linutronix.de>
Precedence: bulk

--omVPbJ2Lyr3mnpXp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 28, 2023 at 11:27:22AM +0100, Nam Cao wrote:
> On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:
> > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > crypto dma engine.
> >=20
> > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > ---
> >  arch/riscv/Kconfig.socs | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> > index 1cf69f958f10..381cd46e6373 100644
> > --- a/arch/riscv/Kconfig.socs
> > +++ b/arch/riscv/Kconfig.socs
> > @@ -29,6 +29,7 @@ config SOC_STARFIVE
> >  	bool "StarFive SoCs"
> >  	select PINCTRL
> >  	select RESET_CONTROLLER
> > +	select ARM_AMBA
> >  	help
> >  	  This enables support for StarFive SoC platform hardware.
>=20
> I'm considering sending this to stable trees. Without this, it is not
> possible to configure the kernel with SPI driver for the starfive board.
>=20
> I just want to check with you first, in case I miss something obvious.
> Any objection to backporting this patch?

Personally I would be okay with that, otherwise the driver is dead code
in those stable versions. Just be sure that the rename of some pl011
variables (I think that's what it was) that was a pre-req for this being
merged is in said versions of stable. An allmodconfig should flag
whether that has happened pretty quickly.

--omVPbJ2Lyr3mnpXp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWXIHwAKCRB4tDGHoIJi
0tIeAP0Qk6kC+Ph4/2dh6HoswPR2MR7gF+g4jYowYymzMnpjGgD/Ta9CcqG6AtL4
G2djjaaTDhNFaiNDoiAAcZ7Y62SUCA8=
=Ertc
-----END PGP SIGNATURE-----

--omVPbJ2Lyr3mnpXp--