Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231123132749.108827-1-boerge.struempfel@gmail.com>
 <CAHp75VcBMbENVKhbdJnXHGxAP85_5CMNxoq7JqV5XbUyRLPoaQ@mail.gmail.com> <CAEktqctA0KWmL_W6aVM67DWB0Q6hOWUQqMwkOp6hn4+iouj1cA@mail.gmail.com>
In-Reply-To: <CAEktqctA0KWmL_W6aVM67DWB0Q6hOWUQqMwkOp6hn4+iouj1cA@mail.gmail.com>
From:   =?UTF-8?B?QsO2cmdlIFN0csO8bXBmZWw=?= <boerge.struempfel@gmail.com>
Date:   Tue, 28 Nov 2023 11:55:34 +0100
Message-ID: <CAEktqcuxS1sPfkGVCgSy1ki8fmUDmuUsHrdAT+zFKy5vGSoKPw@mail.gmail.com>
Subject: Re: [PATCH] gpiolib: sysfs: Fix improper error handling on failed export
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, bstruempfel@ultratronik.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andy,

On Thu, Nov 23, 2023 at 4:01=E2=80=AFPM B=C3=B6rge Str=C3=BCmpfel
<boerge.struempfel@gmail.com> wrote:
>
> Hi Andy
>
> thank you for your feedback
>
> On Thu, Nov 23, 2023 at 3:25=E2=80=AFPM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Thu, Nov 23, 2023 at 3:30=E2=80=AFPM Boerge Struempfel
> > <boerge.struempfel@gmail.com> wrote:
> > >
> > > If gpio_set_transitory fails, we should free the gpio again. Most
> >
> > We refer to functions as func() in the text and comments (note parenthe=
ses).
> >
> > GPIO
>
> Thanks for letting me know, I will update the the commit message in
> regards to this.
>
> >
> > > notably, the flag FLAG_REQUESTED has previously been set in
> > > gpiod_request_commit, and should be reset on failure.
> >
> > Same about func().
> >
> > ...
> >
> > Seems the correct fix, but you may also add that no existing user is
> > returning anything except 0 or ENOTSUPP that is converted to 0 in
> > GPIOLIB core code. Hence no Fixes tag is needed, but still possible if
> > maintainers want it.
> >
>
> You are right. For now, all mainline users are returning 0. We only found
> this due to downstream-specific code. I'll add a comment about this not
> affecting any existing users to the commit message.
>

A small update:
I looked through the possible users again, and there seems to be at least
the possibility for some other return values. The reason for this is, that
the .set_config() of the specific gpio driver is called during the
gpiod_set_transitory() call. For example the .set_config() of gpio-aspeed
might in certain (somewhat unlikely) cases return -EPROBE_DEFER as
well as -EINVAL.

However I don't think, that these conditional paths can be reached on a
properly configured system.

Kind Regards,
B=C3=B6rge Str=C3=BCmpfel