Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3764329rdh; Tue, 28 Nov 2023 03:20:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOhfqDAo+sN3H99YZ7sTG1MAKL+yykIpoBO9j9rVYvvX7S3vDywI48ycR2Kst7DbiqwEdR X-Received: by 2002:a05:6830:270a:b0:6d8:3ffb:ccb7 with SMTP id j10-20020a056830270a00b006d83ffbccb7mr1707531otu.30.1701170403883; Tue, 28 Nov 2023 03:20:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701170403; cv=none; d=google.com; s=arc-20160816; b=VtaFsrCFk6kUmWTVq4Cu/+AVXsdSTSqpEddPw6w0YuoSw3V4NCb9zvRd6kaaQ2GHps YQa8FlewvObKnLApoH860tOOEoVwslg0B1qtiEdj/7JXWbJwRwz7xp8oTAOkQr+288Re 9uvH1iw30fVrrGM5cxw/EkAgMlOYJX4Imv5+s2X3Mr7bjqc5/dt6vgcYcEcO9IxaG0+N tXwLe4NzapvrJXZbd+1aHSP2T/APy2c2uIADzRE/cvP/Bh9fE3itG4ea86Equb1V5gOa 3J0NHKwWZFgxcvkzAJWfP/tgGiosQC36idNP0xM0KRMJ2d6S0ng0uu3i3ykZwKkDOutP J7iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=paHa1uoajRl3fiHQkwc47R9Apwy0aaoIfcAUXcnGAho=; fh=ODwDLlHidm3ekD9N+QmQzQnqpJxQgXfsyOOwBau5DIY=; b=Us6PF5O8KBRc3/KemRzyTEvLVDhtNZVCMkfD/8DZpRSw+CPZwqc75tgQt6JJg9/Vfw rNDdVSlZ86gmnZDHquBSQhILsf5yiohb419PoyaiKErz/xQrY735Fz3IZZc6CF/F3/5f qiKXF8Wj4WGzvzNQizf+/ADLeEqeIuN2kUcdnLOjkXcT8BizdzOsYhFnaIhHoXRFNVPu cFWQWSGvF6RSTnfPL9c9BMHl13o6njo+Fqitxp9BPHD2zf0aEcxhA+7v0Ywic4i9FNeU 38CgoYrgZzwFZj1BimQU3aO5Wa50bnkad7RKnCOeHV6Is6eGxCDXM2kJf6Su45Hg2Ofy UOWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=red-soft.ru Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id 1-20020a631541000000b005c1cc7273bcsi12387881pgv.731.2023.11.28.03.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 03:20:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=red-soft.ru Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 684B68072A23; Tue, 28 Nov 2023 03:20:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344534AbjK1LTq (ORCPT + 99 others); Tue, 28 Nov 2023 06:19:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344124AbjK1LTp (ORCPT ); Tue, 28 Nov 2023 06:19:45 -0500 X-Greylist: delayed 567 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 28 Nov 2023 03:19:48 PST Received: from gw.red-soft.ru (red-soft.ru [188.246.186.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CF8DD194; Tue, 28 Nov 2023 03:19:48 -0800 (PST) Received: from localhost.biz (unknown [10.81.81.211]) by gw.red-soft.ru (Postfix) with ESMTPA id 9643E3E1A83; Tue, 28 Nov 2023 14:10:18 +0300 (MSK) From: Artem Chernyshev To: Satish Kharat , Sesidhar Baddela Cc: Artem Chernyshev , Karan Tilak Kumar , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] scsi: fnic: return error if vmalloc failed Date: Tue, 28 Nov 2023 14:10:08 +0300 Message-Id: <20231128111008.2280507-1-artem.chernyshev@red-soft.ru> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 181650 [Nov 28 2023] X-KLMS-AntiSpam-Version: 6.0.0.2 X-KLMS-AntiSpam-Envelope-From: artem.chernyshev@red-soft.ru X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Auth: dkim=none X-KLMS-AntiSpam-Info: LuaCore: 5 0.3.5 98d108ddd984cca1d7e65e595eac546a62b0144b, {Tracking_from_domain_doesnt_match_to}, localhost.biz:7.1.1;127.0.0.199:7.1.2;red-soft.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1, FromAlignment: s X-MS-Exchange-Organization-SCL: -1 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, bases: 2023/11/28 09:02:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2023/11/28 07:11:00 #22560184 X-KLMS-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 03:20:01 -0800 (PST) In fnic_init_module() exists redundant check for return value from fnic_debugfs_init(), because at moment it only can return zero. It make sense to process theoretical vmalloc failure. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 9730ddfb123d ("scsi: fnic: remove redundant assignment of variable rc") Signed-off-by: Artem Chernyshev --- drivers/scsi/fnic/fnic_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c index c4d9ed0d7d75..cf2601bf170a 100644 --- a/drivers/scsi/fnic/fnic_debugfs.c +++ b/drivers/scsi/fnic/fnic_debugfs.c @@ -52,9 +52,10 @@ int fnic_debugfs_init(void) fc_trc_flag->fnic_trace = 2; fc_trc_flag->fc_trace = 3; fc_trc_flag->fc_clear = 4; + return 0; } - return 0; + return -ENOMEM; } /* -- 2.37.3