Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3766995rdh; Tue, 28 Nov 2023 03:24:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCtEvE78sybg2xldInYjPH0xqa4E+OHWqNm1fDpeL2NuL2WJmJL6b1Yj2YWqGTnmEF/HKU X-Received: by 2002:a05:6a21:a5a7:b0:18c:908b:e16e with SMTP id gd39-20020a056a21a5a700b0018c908be16emr7606013pzc.24.1701170687617; Tue, 28 Nov 2023 03:24:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701170687; cv=none; d=google.com; s=arc-20160816; b=mCt+JmabFTMbhQ85kQyELTRttEHeS55msQ+boYxc7549DKu6xxQzRyKw+Ep+mnmRln m2l4AA2Y4Mh8SHxvFaAhSTVIc9Isustl8OnsRgczYyIxNqSJwVuon1+C9i2NzRszbsvd JKXxTAj1c74wYiXSaw9OpiMUToh4830Ye3xb7Yk1lPDk7QKpj17gvv9daD7w++NUZOAT a1qrHHGXsF9zhL1Dnh5Yl7W7P/J4lhW99ou9xaxR9Nj37U2ZN/H3JN18VH81PmNCfYx3 ywU9bSBr+KBZpUsaJGyOPSmEVbBJzWZgLYsdheYQdO6uMlPTktXpXO/GTsjugYHM0gWP Mdrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Q/4I4L0xAwk/trQvNdVHXY+RPoncGXXCSxUTBh3V9+Y=; fh=fKTaOfNpNriLh2ihNxnJUGHaZRsAsozL4WgZvGInEC4=; b=cAyrHFe+4xV0y4YRKIQZzo1+V6LNoiTMAkziOsK2juvDNmq7Au8cvsSKE5D0LeZCfq 5eF99Ye4KA6q3O1t6c6TUeuIMU6Qfd+fjapBxza8mG8IqEfYr+MJtvkVW0OJw7tfcYb3 X0UdH67gFcNL0ezA9ZKli1TgMw5/j2IOgCHOOAhttg5OEki2gCIgg4xNWlfCrboTq60T XIx1qbdiJ++pjjncmdzk06+NNkdwh8r2XOLMDDfp8sxS7Q3Rh0XlpDfSqy03Cye0Oe/8 LikJ0n6cdl3AkgDs2B00bRqhRBmUtVC1I0KgkE+PMlznDPHNyO3UQhQIxrJDhGbKHi7G GS0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pCmNuBi1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id 27-20020a630d5b000000b005c21d7d1114si12415164pgn.818.2023.11.28.03.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 03:24:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pCmNuBi1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 4D858804B032; Tue, 28 Nov 2023 03:24:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344579AbjK1LYg (ORCPT + 99 others); Tue, 28 Nov 2023 06:24:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344558AbjK1LYd (ORCPT ); Tue, 28 Nov 2023 06:24:33 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 776C4D60 for ; Tue, 28 Nov 2023 03:24:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36231C433C8; Tue, 28 Nov 2023 11:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701170679; bh=IsNn+ClgvkZ4uETCGvuIForgy3jvNsLeqUnXrX0XuV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pCmNuBi1q7zW0CbjVsoOuWVtQzzGwuXlPKHnOE7o7cFo3lHpuDDHUQHlT8A6qYUZu ThI+045PVpaG57yYVqFKBxRA7FB/bkn9kjc2GlmWcP8q0U45AkNTKRdPoNkaM2srAJ 6c8pomjEvMzsvZWY4zG/cFhLbU6oc88VQhianOZMQEZLDC04mWHP+mrTRPMDCvEIwA 3FMj4mja4ZiEzdZ6thgqm2XTYLoJtF0ZVVi2zS6nJQdRy/1qx/WajBeX4CfchHTLlG heu2ClC6A+ryTfAZJWf6jWpVcE0LMdsY4nKGKDPzM6aioCbw5tBSj4GnsWW1uRqZsM fiE7KxIfNLqHg== Date: Tue, 28 Nov 2023 16:54:09 +0530 From: Manivannan Sadhasivam To: Can Guo Cc: bvanassche@acm.org, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , open list Subject: Re: [PATCH v5 06/10] scsi: ufs: ufs-qcom: Limit HS-G5 Rate-A to hosts with HW version 5 Message-ID: <20231128112409.GU3088@thinkpad> References: <1700729190-17268-1-git-send-email-quic_cang@quicinc.com> <1700729190-17268-7-git-send-email-quic_cang@quicinc.com> <20231128055520.GG3088@thinkpad> <4648b6a0-92cb-4411-9b58-03219962505d@quicinc.com> <20231128105506.GO3088@thinkpad> <46b24613-cffc-4a87-9232-8b93e09906f1@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46b24613-cffc-4a87-9232-8b93e09906f1@quicinc.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 03:24:46 -0800 (PST) On Tue, Nov 28, 2023 at 06:59:39PM +0800, Can Guo wrote: > > > On 11/28/2023 6:55 PM, Manivannan Sadhasivam wrote: > > On Tue, Nov 28, 2023 at 03:48:02PM +0800, Can Guo wrote: > > > Hi Mani, > > > > > > On 11/28/2023 1:55 PM, Manivannan Sadhasivam wrote: > > > > On Thu, Nov 23, 2023 at 12:46:26AM -0800, Can Guo wrote: > > > > > Qcom UFS hosts, with HW ver 5, can only support up to HS-G5 Rate-A due to > > > > > HW limitations. If the HS-G5 PHY gear is used, update host_params->hs_rate > > > > > to Rate-A, so that the subsequent power mode changes shall stick to Rate-A. > > > > > > > > > > Signed-off-by: Can Guo > > > > > > > > Reviewed-by: Manivannan Sadhasivam > > > > > > > > One question below... > > > > > > > > > --- > > > > > drivers/ufs/host/ufs-qcom.c | 18 +++++++++++++++++- > > > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > > > > > index 9613ad9..6756f8d 100644 > > > > > --- a/drivers/ufs/host/ufs-qcom.c > > > > > +++ b/drivers/ufs/host/ufs-qcom.c > > > > > @@ -442,9 +442,25 @@ static u32 ufs_qcom_get_hs_gear(struct ufs_hba *hba) > > > > > static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) > > > > > { > > > > > struct ufs_qcom_host *host = ufshcd_get_variant(hba); > > > > > + struct ufs_host_params *host_params = &host->host_params; > > > > > struct phy *phy = host->generic_phy; > > > > > + enum phy_mode mode; > > > > > int ret; > > > > > + /* > > > > > + * HW ver 5 can only support up to HS-G5 Rate-A due to HW limitations. > > > > > + * If the HS-G5 PHY gear is used, update host_params->hs_rate to Rate-A, > > > > > + * so that the subsequent power mode change shall stick to Rate-A. > > > > > + */ > > > > > + if (host->hw_ver.major == 0x5) { > > > > > + if (host->phy_gear == UFS_HS_G5) > > > > > + host_params->hs_rate = PA_HS_MODE_A; > > > > > + else > > > > > + host_params->hs_rate = PA_HS_MODE_B; > > > > > > > > Is this 'else' part really needed? Since there wouldn't be any 2nd init, I think > > > > we can skip that. > > > > > > We need it because, even there is only one init, if a UFS3.1 device is > > > attached, phy_gear is given as UFS_HS_G4 in ufs_qcom_set_phy_gear(), hence > > > we need to put the UFS at HS-G4 Rate B, not Rate A. > > > > > > > But the default hs_rate is PA_HS_MODE_B only and the else condition would be not > > needed for the 1st init. > > You are right, but still we need this in case the UFS device version is not > populated, meaning dual init can also happen to SM8550. We need to apply the > right hs_rate in case the 2nd init asks for HS_G4. > Hmm, yeah I missed that corner case. This is fine. - Mani > Thanks, > Can Guo. > > > > > - Mani > > > > > Thanks, > > > Can Guo. > > > > > > > > > > > - Mani > > > > > > > > > + } > > > > > + > > > > > + mode = host_params->hs_rate == PA_HS_MODE_B ? PHY_MODE_UFS_HS_B : PHY_MODE_UFS_HS_A; > > > > > + > > > > > /* Reset UFS Host Controller and PHY */ > > > > > ret = ufs_qcom_host_reset(hba); > > > > > if (ret) > > > > > @@ -459,7 +475,7 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) > > > > > return ret; > > > > > } > > > > > - phy_set_mode_ext(phy, PHY_MODE_UFS_HS_B, host->phy_gear); > > > > > + phy_set_mode_ext(phy, mode, host->phy_gear); > > > > > /* power on phy - start serdes and phy's power and clocks */ > > > > > ret = phy_power_on(phy); > > > > > -- > > > > > 2.7.4 > > > > > > > > > > > -- மணிவண்ணன் சதாசிவம்