Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   <Shravan.Chippa@microchip.com>
To:     <vkoul@kernel.org>
CC:     <green.wan@sifive.com>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <palmer@dabbelt.com>,
        <paul.walmsley@sifive.com>, <conor+dt@kernel.org>,
        <dmaengine@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <Nagasuresh.Relli@microchip.com>, <Praveen.Kumar@microchip.com>
Subject: RE: [PATCH v4 1/4] dmaengine: sf-pdma: Support
 of_dma_controller_register()
Thread-Topic: [PATCH v4 1/4] dmaengine: sf-pdma: Support
 of_dma_controller_register()
Thread-Index: AQHaC7rwiAakoMNSeUabYOyvai+WirCJhnmAgAY/ogA=
Date:   Tue, 28 Nov 2023 11:34:44 +0000
Message-ID: <PH0PR11MB561175B8951083F151A7269681BCA@PH0PR11MB5611.namprd11.prod.outlook.com>
References: <20231031052753.3430169-1-shravan.chippa@microchip.com>
 <20231031052753.3430169-2-shravan.chippa@microchip.com>
 <ZWCSS+UXpRO+4y9h@matsya>
In-Reply-To: <ZWCSS+UXpRO+4y9h@matsya>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sU0ZKLTExSGeZU5JTCNq9MZYBbCQ9XIsG5o0w2NMqm6VBH5t5VF8GmvBDMRe?=
 =?us-ascii?Q?Foi8cK6pwooubVLW6f1criN7oQSLF4/hICkyW0SXfQ9kViObkfFyUyXkPP+T?=
 =?us-ascii?Q?oP4oq+xeDg90v8bBZOzDF356ZNUzzz0gT4MLXzrflc523LgKjz8z3OolOTNG?=
 =?us-ascii?Q?CG7qj1elKgRYIwsFht5HKqVnEKtovsqjePblIcDVniUuthh+6LopD7n/wk+V?=
 =?us-ascii?Q?6HCjPtDuI/aOEMIs4sWx37CknucFHvaVM+oWWyzFDvETMMuwdfHnyEWc3vBt?=
 =?us-ascii?Q?ePCxcPktpn3REoEtAcrEKQImNXcc4pB+tfx/hgOX8B/EXK4L/WlQ8H6GGut2?=
 =?us-ascii?Q?15fMhkGlGQbeV/LYWvD9LUvgQ1ELOyq0Lt9kGlL1DQb1riwmKawpVS3YYKze?=
 =?us-ascii?Q?g0hkjhGGXYtA3w+Y0NKTz+hA3RJ1UEoLyYjaVBedQJTzCX5ol25996HTqloA?=
 =?us-ascii?Q?/t9vZXDjayrZwsQ/tyPCwAdk8q4b4H0XJyf2pRxKgBQ9RHO5gFWZM2ldMrQI?=
 =?us-ascii?Q?S/AJkWelphtj4qJWhnAyEsLIq94y3tAWdNzXAOnoAf6ePd20+ie4cU6E19ND?=
 =?us-ascii?Q?VD7G3EXIZMI5E6mhA7eog9rjpDVRLjUo1Rg02rWcHNTXPJa5ZFJNb/ts+wii?=
 =?us-ascii?Q?mWdMytTksHxnixbxP10MOeveVXBb7jR9gDhaT0L7J2Tje9tcuqFjDbQ4c25Z?=
 =?us-ascii?Q?6n9Kn9wAfQwKiOgzJ2zQ2dT3bvxC7sYerOf7jdJBLnSZeb/Lx/fXS/z9d0Rb?=
 =?us-ascii?Q?wMZQRfTDJgr2W7PWEf9K2hSH34e6EwKFJtzKxGHMQty/bFgQauQ+2ztM0UtG?=
 =?us-ascii?Q?Drs0RhXG+j2pHDTyBzkBQnJb710JiSm4j8Rwrdx6qL9IdC8Kzg110EPLUQ7Q?=
 =?us-ascii?Q?X4Zctjd3kgB3QAidgxLqIqPboF7hRsLOihPNXWQqTmM93oZNLc8+0EV2d2Zz?=
 =?us-ascii?Q?0HD3czbuy62/WQGKzaVOWKGFHWXk3hVQ8nyxLXkbhvCMOdt6jrR4hP9xF8XF?=
 =?us-ascii?Q?27Egihd73IhaSFukq2soBPehFladDOiCSt2ZNOCEj/xCMNyJ7u40d+z0jnKi?=
 =?us-ascii?Q?5tut0sFdmjO7u/7tE8kG3J7OfmY2KrshGDu9d+TMLn1Ln27bNWZ0Y976R13C?=
 =?us-ascii?Q?lfpEWpLygUuD1B6elMtb8geL5/tQLrtT2fjgXbPm5RwnkYIiGFpDqKja3Bb7?=
 =?us-ascii?Q?T/TDXUpPTyqVrZ62oEf3MWrB1nnbrtsoESBhJQGTkXWGVvU5t3XEHgmk+7EC?=
 =?us-ascii?Q?Du3QJnNnbNtHmHdzjOlt8erNi7sdxMS4jiRa04O/kkY25ooLNGSrC6vVozBS?=
 =?us-ascii?Q?q10H6PlWjEvOqiu+BiG/J2AE+NbTJjchu5DpOexhFVpqm8pxYVqACpyZoz+6?=
 =?us-ascii?Q?qnbVPXpFR2cRmCjlFuFd0/hNc5m8GixE1YdLr6EE/xjY2vPB1g+Rdm7RSF5R?=
 =?us-ascii?Q?Pe2aEweX6RjBllwwc5neXytzllEE4Qn9hEElLwybBG+G1OLIrLAeG4k77fAb?=
 =?us-ascii?Q?vS6kFsnKTvKG2Hp7b4DRL72hiUHxZSHiWW8PbYDBNPrkavFgUvU+TtK1VGCh?=
 =?us-ascii?Q?c9VlYuOzaylRLpwHOG1wNLHvMoTX2eO+PzpIMOfh36v8cvONImMvwWg68ai1?=
 =?us-ascii?Q?VA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5611.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07286717-c2d9-4797-f887-08dbf00604b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 11:34:44.2452
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mhpd/X40uUcKt75WKCKP0TrsVbWLbs6lBvbYVAmmVRYLvTKjFmLmP7ZZgEJT1qjIRhx61jphq0EbYtoFQtbn7sdisTbCX5RI1Mi0mJoIizU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7822
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 03:35:08 -0800 (PST)

Hi Vinod,


> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Friday, November 24, 2023 5:39 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>
> Cc: green.wan@sifive.com; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; palmer@dabbelt.com;
> paul.walmsley@sifive.com; conor+dt@kernel.org;
> dmaengine@vger.kernel.org; devicetree@vger.kernel.org; linux-
> riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Nagasuresh Relli=
 -
> I67208 <Nagasuresh.Relli@microchip.com>; Praveen Kumar - I30718
> <Praveen.Kumar@microchip.com>
> Subject: Re: [PATCH v4 1/4] dmaengine: sf-pdma: Support
> of_dma_controller_register()
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On 31-10-23, 10:57, shravan chippa wrote:
> > From: Shravan Chippa <shravan.chippa@microchip.com>
> >
> > Update sf-pdma driver to adopt generic DMA device tree bindings.
> > It calls of_dma_controller_register() with sf-pdma specific
> > of_dma_xlate to get the generic DMA device tree helper support and the
> > DMA clients can look up the sf-pdma controller using standard APIs.
> >
> > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
> > ---
> >  drivers/dma/sf-pdma/sf-pdma.c | 44
> > +++++++++++++++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >
> > diff --git a/drivers/dma/sf-pdma/sf-pdma.c
> > b/drivers/dma/sf-pdma/sf-pdma.c index d1c6956af452..4c456bdef882
> > 100644
> > --- a/drivers/dma/sf-pdma/sf-pdma.c
> > +++ b/drivers/dma/sf-pdma/sf-pdma.c
> > @@ -20,6 +20,7 @@
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/of.h>
> > +#include <linux/of_dma.h>
> >  #include <linux/slab.h>
> >
> >  #include "sf-pdma.h"
> > @@ -490,6 +491,33 @@ static void sf_pdma_setup_chans(struct sf_pdma
> *pdma)
> >       }
> >  }
> >
> > +static struct dma_chan *sf_pdma_of_xlate(struct of_phandle_args
> *dma_spec,
> > +                                      struct of_dma *ofdma) {
> > +     struct sf_pdma *pdma =3D ofdma->of_dma_data;
> > +     struct device *dev =3D pdma->dma_dev.dev;
> > +     struct sf_pdma_chan *chan;
> > +     struct dma_chan *c;
> > +     u32 channel_id;
> > +
> > +     if (dma_spec->args_count !=3D 1) {
> > +             dev_err(dev, "Bad number of cells\n");
> > +             return NULL;
> > +     }
> > +
> > +     channel_id =3D dma_spec->args[0];
> > +
> > +     chan =3D &pdma->chans[channel_id];
> > +
> > +     c =3D dma_get_slave_channel(&chan->vchan.chan);
> > +     if (!c) {
> > +             dev_err(dev, "No more channels available\n");
> > +             return NULL;
> > +     }
> > +
> > +     return c;
> > +}
>=20
> This seems could be replaced by of_dma_xlate_by_chan_id() can you tell me
> why that cant be used?

I will try to use the of_dma_xlate_by_chan_id() function instead of a custo=
m function, I will try to send the next revision.

Thanks,
Shravan


>=20
> > +
> >  static int sf_pdma_probe(struct platform_device *pdev)  {
> >       struct sf_pdma *pdma;
> > @@ -563,7 +591,20 @@ static int sf_pdma_probe(struct platform_device
> *pdev)
> >               return ret;
> >       }
> >
> > +     ret =3D of_dma_controller_register(pdev->dev.of_node,
> > +                                      sf_pdma_of_xlate, pdma);
> > +     if (ret < 0) {
> > +             dev_err(&pdev->dev,
> > +                     "Can't register SiFive Platform OF_DMA. (%d)\n", =
ret);
> > +             goto err_unregister;
> > +     }
> > +
> >       return 0;
> > +
> > +err_unregister:
> > +     dma_async_device_unregister(&pdma->dma_dev);
> > +
> > +     return ret;
> >  }
> >
> >  static int sf_pdma_remove(struct platform_device *pdev) @@ -583,6
> > +624,9 @@ static int sf_pdma_remove(struct platform_device *pdev)
> >               tasklet_kill(&ch->err_tasklet);
> >       }
> >
> > +     if (pdev->dev.of_node)
> > +             of_dma_controller_free(pdev->dev.of_node);
> > +
> >       dma_async_device_unregister(&pdma->dma_dev);
> >
> >       return 0;
> > --
> > 2.34.1
>=20
> --
> ~Vinod