Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231128055248.659808-1-bhe@redhat.com>
In-Reply-To: <20231128055248.659808-1-bhe@redhat.com>
From:   Ignat Korchagin <ignat@cloudflare.com>
Date:   Tue, 28 Nov 2023 11:51:19 +0000
Message-ID: <CALrw=nG0AhxEmx39bnvM+CKh8bFijvsAPGU3CFY5Top0prS3yw@mail.gmail.com>
Subject: Re: [PATCH v2] drivers/base/cpu: crash data showing should depends on KEXEC_CORE
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
        x86@kernel.org, akpm@linux-foundation.org, eric_devolder@yahoo.com,
        agordeev@linux.ibm.com, kernel-team <kernel-team@cloudflare.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 28, 2023 at 5:53=E2=80=AFAM Baoquan He <bhe@redhat.com> wrote:
>
> After commit 88a6f8994421 ("crash: memory and CPU hotplug sysfs
> attributes"), on x86_64, if only below kernel configs related to kdump
> are set, compiling error are triggered.
>
> ----
> CONFIG_CRASH_CORE=3Dy
> CONFIG_KEXEC_CORE=3Dy
> CONFIG_CRASH_DUMP=3Dy
> CONFIG_CRASH_HOTPLUG=3Dy
> ------
>
> ------------------------------------------------------
> drivers/base/cpu.c: In function =E2=80=98crash_hotplug_show=E2=80=99:
> drivers/base/cpu.c:309:40: error: implicit declaration of function =E2=80=
=98crash_hotplug_cpu_support=E2=80=99; did you mean =E2=80=98crash_hotplug_=
show=E2=80=99? [-Werror=3Dimplicit-function-declaration]
>   309 |         return sysfs_emit(buf, "%d\n", crash_hotplug_cpu_support(=
));
>       |                                        ^~~~~~~~~~~~~~~~~~~~~~~~~
>       |                                        crash_hotplug_show
> cc1: some warnings being treated as errors
> ------------------------------------------------------
>
> CONFIG_KEXEC is used to enable kexec_load interface, the
> crash_notes/crash_notes_size/crash_hotplug showing depends on
> CONFIG_KEXEC is incorrect. It should depend on KEXEC_CORE instead.
>
> Fix it now.
>
> Fixes: commit 88a6f8994421 ("crash: memory and CPU hotplug sysfs attribut=
es")
> Signed-off-by: Baoquan He <bhe@redhat.com>

Tested-by: Ignat Korchagin <ignat@cloudflare.com> # compile-time only
for x86 and arm

> ---
>  drivers/base/cpu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
> index 9ea22e165acd..548491de818e 100644
> --- a/drivers/base/cpu.c
> +++ b/drivers/base/cpu.c
> @@ -144,7 +144,7 @@ static DEVICE_ATTR(release, S_IWUSR, NULL, cpu_releas=
e_store);
>  #endif /* CONFIG_ARCH_CPU_PROBE_RELEASE */
>  #endif /* CONFIG_HOTPLUG_CPU */
>
> -#ifdef CONFIG_KEXEC
> +#ifdef CONFIG_KEXEC_CORE
>  #include <linux/kexec.h>
>
>  static ssize_t crash_notes_show(struct device *dev,
> @@ -189,14 +189,14 @@ static const struct attribute_group crash_note_cpu_=
attr_group =3D {
>  #endif
>
>  static const struct attribute_group *common_cpu_attr_groups[] =3D {
> -#ifdef CONFIG_KEXEC
> +#ifdef CONFIG_KEXEC_CORE
>         &crash_note_cpu_attr_group,
>  #endif
>         NULL
>  };
>
>  static const struct attribute_group *hotplugable_cpu_attr_groups[] =3D {
> -#ifdef CONFIG_KEXEC
> +#ifdef CONFIG_KEXEC_CORE
>         &crash_note_cpu_attr_group,
>  #endif
>         NULL
> --
> 2.41.0
>