Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <58af512c-3d7d-4774-88f7-6336c9384b61@arm.com>
Date:   Tue, 28 Nov 2023 12:15:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RESEND PATCH v7 00/10] Small-sized THP for anonymous memory
Content-Language: en-GB
To:     David Hildenbrand <david@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Alistair Popple <apopple@nvidia.com>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yin Fengwei <fengwei.yin@intel.com>,
        Yu Zhao <yuzhao@google.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Yang Shi <shy828301@gmail.com>,
        "Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Itaru Kitayama <itaru.kitayama@gmail.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Hugh Dickins <hughd@google.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20231122162950.3854897-1-ryan.roberts@arm.com>
 <ZV9267tQEhoPzCru@casper.infradead.org>
 <f8e518f2-fb15-4295-a335-bea5a8010ab2@arm.com>
 <ZWC9lwDAjMZsNzoG@casper.infradead.org>
 <9c8f6d2a-7ed8-45d2-9684-d77489bd99b8@redhat.com>
 <ZWDG6BYqmZVpyTLL@casper.infradead.org>
 <26c361bc-6d87-4a57-9fae-ef635c9039c7@redhat.com>
 <87sf4rppuc.fsf@nvdebian.thelocal>
 <51e6c9f1-e863-464b-b5f3-d7f60a7ebed6@arm.com>
 <b2d19306-0d68-4aef-9b68-15948ddc8ea0@nvidia.com>
 <afb92816-25ed-41c8-a48b-94fb2d885d8e@redhat.com>
From:   Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <afb92816-25ed-41c8-a48b-94fb2d885d8e@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 28/11/2023 08:48, David Hildenbrand wrote:
> 
>>>
>>> Agreed. We are bikeshedding here. But if we really can't swallow "small-sized
>>> THP" then perhaps the most efficient way to move this forwards is to review the
>>> documentation (where "small-sized THP" appears twice in order to differentiate
>>> from PMD-sized THP) - its in patch 3. Perhaps it will be easier to come up with
>>> a good description in the context of those prose? Then once we have that,
>>> hopefully a term will fall out that I'll update the commit logs with.
>>>
>>
>> I will see you over in patch 3, then. I've already looked at it and am going
>> to suggest a long and a short name. The long name is for use in comments and
>> documentation, and the short name is for variable fragments:
>>
>>       Long name:  "pte-mapped THPs"
>>       Short names: pte_thp, or pte-thp
> 
> The issue is that any THP can be pte-mapped, even a PMD-sized THP. However, the
> "natural" way to map a PMD-sized THP is using a PMD.
> 

How about we just stop trying to come up with a term for the "small-sized THP"
vs "PMD-sized THP" and instead invent a name that covers ALL THP:

"multi-size THP" vs "PMD-sized THP".

Then in the docs we can talk about how multi-size THP introduces the ability to
allocate memory in blocks that are bigger than a base page but smaller than
traditional PMD-size, in increments of a power-of-2 number of pages.