Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <10660ec7032cf66a772ecd0b7cfdbba88849929a.camel@linux.ibm.com>
Subject: Re: [PATCH v3] rootfs: Fix support for rootfstype= when root= is
 given
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Stefan Berger <stefanb@linux.ibm.com>
Cc:     linux-kernel@vger.kernel.org, initramfs@vger.kernel.org,
        stable@vger.kernel.org, Rob Landley <rob@landley.net>
Date:   Tue, 28 Nov 2023 07:18:07 -0500
In-Reply-To: <2023112826-cesspool-cabbie-06c5@gregkh>
References: <20231120011248.396012-1-stefanb@linux.ibm.com>
         <2023112826-cesspool-cabbie-06c5@gregkh>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-11-28 at 09:54 +0000, Greg KH wrote:
> On Sun, Nov 19, 2023 at 08:12:48PM -0500, Stefan Berger wrote:
> > Documentation/filesystems/ramfs-rootfs-initramfs.rst states:
> > 
> >   If CONFIG_TMPFS is enabled, rootfs will use tmpfs instead of ramfs by
> >   default.  To force ramfs, add "rootfstype=ramfs" to the kernel command
> >   line.
> > 
> > This currently does not work when root= is provided since then
> > saved_root_name contains a string and rootfstype= is ignored. Therefore,
> > ramfs is currently always chosen when root= is provided.
> > 
> > The current behavior for rootfs's filesystem is:
> > 
> >    root=       | rootfstype= | chosen rootfs filesystem
> >    ------------+-------------+--------------------------
> >    unspecified | unspecified | tmpfs
> >    unspecified | tmpfs       | tmpfs
> >    unspecified | ramfs       | ramfs
> >     provided   | ignored     | ramfs
> > 
> > rootfstype= should be respected regardless whether root= is given,
> > as shown below:
> > 
> >    root=       | rootfstype= | chosen rootfs filesystem
> >    ------------+-------------+--------------------------
> >    unspecified | unspecified | tmpfs  (as before)
> >    unspecified | tmpfs       | tmpfs  (as before)
> >    unspecified | ramfs       | ramfs  (as before)
> >     provided   | unspecified | ramfs  (compatibility with before)
> >     provided   | tmpfs       | tmpfs  (new)
> >     provided   | ramfs       | ramfs  (new)
> > 
> > This table represents the new behavior.
> > 
> > Fixes: 6e19eded3684 ("initmpfs: use initramfs if rootfstype= or root=  specified")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Rob Landley <rob@landley.net>
> > Link: https://lore.kernel.org/lkml/8244c75f-445e-b15b-9dbf-266e7ca666e2@landley.net/
> > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Who should take this patch?  Me?  Or someone else?

Reviewed-and-Tested-by: Mimi Zohar <zohar@linux.ibm.com>

Thanks, Greg.  As there is no initramfs maintainer, I'd appreciate your
picking it up.

-- 
thanks,

Mimi