Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Tue, 28 Nov 2023 12:47:18 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Neil Armstrong <neil.armstrong@linaro.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami <bgoswami@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] ASoC: codecs: Add WCD939x Soundwire slave driver
Message-ID: <ZWXhVvGWwXc27FHo@finisterre.sirena.org.uk>
References: <20231123-topic-sm8650-upstream-wcd939x-codec-v1-0-21d4ad9276de@linaro.org>
 <20231123-topic-sm8650-upstream-wcd939x-codec-v1-4-21d4ad9276de@linaro.org>
 <ZV+PTynfbRmF0trU@finisterre.sirena.org.uk>
 <ee3baf94-4158-4440-8d89-de39fe0aa2f3@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zRYJJGeNyjEN57NU"
Content-Disposition: inline
In-Reply-To: <ee3baf94-4158-4440-8d89-de39fe0aa2f3@linaro.org>
Precedence: bulk


--zRYJJGeNyjEN57NU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 28, 2023 at 10:09:29AM +0100, Neil Armstrong wrote:
> On 23/11/2023 18:43, Mark Brown wrote:

> > > +static int wcd9390_interrupt_callback(struct sdw_slave *slave,
> > > +				      struct sdw_slave_intr_status *status)
> > > +{
> > > +	struct wcd939x_sdw_priv *wcd = dev_get_drvdata(&slave->dev);
> > > +	struct irq_domain *slave_irq = wcd->slave_irq;
> > > +	u32 sts1, sts2, sts3;
> > > +
> > > +	do {
> > > +		handle_nested_irq(irq_find_mapping(slave_irq, 0));
> > > +		regmap_read(wcd->regmap, WCD939X_DIGITAL_INTR_STATUS_0, &sts1);
> > > +		regmap_read(wcd->regmap, WCD939X_DIGITAL_INTR_STATUS_1, &sts2);
> > > +		regmap_read(wcd->regmap, WCD939X_DIGITAL_INTR_STATUS_2, &sts3);
> > > +
> > > +	} while (sts1 || sts2 || sts3);
> > > +
> > > +	return IRQ_HANDLED;
> > > +}

> > We do this in the other Qualcomm drivers but it doesn't seem ideal to
> > just ignore the interrupts.

> It seems we simply ignore IRQs that are not mapped in the regmap_irq,
> what would be the ideal way to handle this ?

I don't understnad what "this" is here.  Why even register an interrupt
handler here?  What is the regmap_irq you are referring to here and why
would an interrupt handler here be related to it?

> > > +static int wcd939x_sdw_component_bind(struct device *dev, struct device *master,
> > > +				      void *data)
> > > +{
> > > +	return 0;
> > > +}
> > > +
> > > +static void wcd939x_sdw_component_unbind(struct device *dev,
> > > +					 struct device *master, void *data)
> > > +{
> > > +}
> > > +
> > > +static const struct component_ops wcd939x_sdw_component_ops = {
> > > +	.bind = wcd939x_sdw_component_bind,
> > > +	.unbind = wcd939x_sdw_component_unbind,
> > > +};

> > Do these need to be provided if they can legitimately be empty?

> AFAIK yes, component code will crash if those are not defined.
> I'll add a comment explaining whey they are no-op.

If the framework can genuninely have empty callbacks here the framework
should be updated to make the callbacks optional.

--zRYJJGeNyjEN57NU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVl4VUACgkQJNaLcl1U
h9CQFAf/X86BJjWyIuWFGa/imsTVc1qRNOaSfXiSo5tUqzDx+dmeJZ0iDSexp52n
+s6hQKvWt8aXarV/rAUIIM8yemaz2BMINAZQQxW5Qm0IpNH82u9AFczWvx9fK8AG
ISjnkn5P+MEhqTHfB54ZNcdT11C9KPgo0kP5eMIsRNJxVPahElMgde866TSK7P3Q
VYrYF+xKYHaoHR5kIC4lgHgbzVpaa2O9nbuur28vCX5HHg7Mv9y2ia1X2R+qLKrp
yuB/5lBeGaFidOuZdoz8KqxsI9e4Z4aqzKGsMBVV7i966MiEX2cHfcEq0qC8y6QN
dndVngDVmPkbhT/RFYsA7yCD2uRfxA==
=P7CZ
-----END PGP SIGNATURE-----

--zRYJJGeNyjEN57NU--