Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3820766rdh; Tue, 28 Nov 2023 05:01:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8d4tnq2q9VIsZU4YRVdIKMnpon5jxq/VsODZxsYTKBKBBvoJ4ExRvIXgME1gpeRowsneC X-Received: by 2002:a9d:7353:0:b0:6d8:2995:518d with SMTP id l19-20020a9d7353000000b006d82995518dmr6696824otk.13.1701176493877; Tue, 28 Nov 2023 05:01:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701176493; cv=none; d=google.com; s=arc-20160816; b=0f3i9aZ5oMoOVEVimv4APjtPr9MKtpB+Xi9nDq/yTRKwdKo5ucYre/lPBKs7YicQmZ POu3Z4BxUDVQwF2BB4UdX5gGf78AWVp/TntEMbR1wX+7G0GxF+dSoBhDJd1vNRbai4vS kAWrS5NA6UPeO9yNlLTo53c0fdsLxeEPq7DpuYOtfGx8Mz1xbxk+cPZKMqSjqX9DWVBe ABh6BFuvK2cFZGmJQBxhge+m3CqIzsZoiA8S6oRDEh8XRHDcOy6zVZdTIiTqahMHV1Gp 8C9yGDQHs6ijDqf0mV6NPEkJXPfAdpTuiOtZxlyzkAOG12AyCi/VKCr0G/v3J8UvlxZm GCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=ImYlswwBMMw3QNHu0NBwf0ORuVFQG7SZ9eVRnCJ64g8=; fh=+9B8pDoow6Ly8ty9RpPXS8A/F1KZ6NQ9Q2IODC05p7Q=; b=DzOSH+pruu7RIZViqoFwvxkb2I5I0fpo6kJrfC1nRbdPmRWYJzmc4WjRFiro7+scTN xhJ1b2HEz1IgZ95heyN6I2XIfiztrU5J6X+zylx/tymLzZP1E7TeNPj4xozpNJFOC2AA XdVqf4aYWnM6OaUbtyjZcWPQPT5hlk7gaXFVRat+4kiwWL6XaYiBAJBr3+uU548ic+Vm hgeWSqMRjfIjsLOFqGEGJZ0s32H3p3UQOwkIq93FfHl2vqlzPxF9BfAuMfXvEYav8nzj 4mxuXDfDWpMrFSOv3DAgT0UaSKbpXPntB1M4x1PC/sKMOzXCba3aNSziVhJRSF6otDyc wTVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KsA17b8a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ca21-20020a056830611500b006d818c98a4csi3051301otb.321.2023.11.28.05.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 05:01:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KsA17b8a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6A3DE80560C4; Tue, 28 Nov 2023 05:01:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344895AbjK1NBA (ORCPT + 99 others); Tue, 28 Nov 2023 08:01:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344886AbjK1NAw (ORCPT ); Tue, 28 Nov 2023 08:00:52 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7464D10E7 for ; Tue, 28 Nov 2023 05:00:58 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD0C4C433BB; Tue, 28 Nov 2023 13:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701176458; bh=j0jjiheRS7DE4WAr5PkTVziGAOVyNRK3hhCMBZKajFQ=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=KsA17b8aS4/+1pg5VQU/LfyGUw3AvwNKG2YGY4FjRvPseS/hqw1bnYZU+S3kj21jL VySGwwKL6qviId39WIIoFtnasevNjDMyjFFnumG/E1dzgju+Uc1m15mD7cG8xi2r1B 1Yc/5Nenp57PXCqWwQcdex3JCbq2wSws+W1SgEFZU/qi4+3d0hTRnGPvQHGTAdnm0L U9opjRtLPpGXu/B/SN/7LBdjUyF625+fCgrziXkAWeqy4Gln3+GEqQaiymJAafcEtu cucA/iulmA/oCQ1ONv7w6nO/mrkA/VpRFWgt9iwU7Xw5Jy+ywFx8wyfUC+pFlHNrnE fLDYYzvvHbw3w== From: Maxime Ripard To: airlied@gmail.com, daniel@ffwll.ch, frank.binns@imgtec.com, donald.robson@imgtec.com, matt.coster@imgtec.com, sarah.walker@imgtec.com, Danilo Krummrich Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org In-Reply-To: <20231124233650.152653-2-dakr@redhat.com> References: <20231124233650.152653-1-dakr@redhat.com> <20231124233650.152653-2-dakr@redhat.com> Subject: Re: (subset) [PATCH drm-misc-next 1/5] drm/imagination: vm: prevent duplicate drm_gpuvm_bo instances Message-Id: <170117645564.2825698.1827367300735783510.b4-ty@kernel.org> Date: Tue, 28 Nov 2023 14:00:55 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 05:01:30 -0800 (PST) On Sat, 25 Nov 2023 00:36:36 +0100, Danilo Krummrich wrote: > Use drm_gpuvm_bo_obtain() instead of drm_gpuvm_bo_create(). The latter > should only be used in conjunction with drm_gpuvm_bo_obtain_prealloc(). > > drm_gpuvm_bo_obtain() re-uses existing instances of a given VM and BO > combination, whereas drm_gpuvm_bo_create() would always create a new > instance of struct drm_gpuvm_bo and hence leave us with duplicates. > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime