Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 28 Nov 2023 08:15:47 -0500
From:   Gregory Price <gregory.price@memverge.com>
To:     Michal Hocko <mhocko@suse.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-api@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-kernel@vger.kernel.org, arnd@arndb.de, tglx@linutronix.de,
        luto@kernel.org, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        tj@kernel.org, ying.huang@intel.com
Subject: Re: [RFC PATCH 00/11] mm/mempolicy: Make task->mempolicy externally
 modifiable via syscall and procfs
Message-ID: <ZWXoA6udt0OJ0P7c@memverge.com>
References: <20231122211200.31620-1-gregory.price@memverge.com>
 <20231122133348.d27c09a90bce755dc1c0f251@linux-foundation.org>
 <ZV5/ilfUoqC2PW0D@memverge.com>
 <ZWS19JFHm_LFSsFd@tiehlicka>
 <ZWTAdKnBVO0+5bbR@memverge.com>
 <ZWW2ngGhM9af5qJW@tiehlicka>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZWW2ngGhM9af5qJW@tiehlicka>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X5Qor0B7Twu074At4B6PPb7RyIGi2ZAyvc2rS7qIhMgiBbwzphTYAtgCCnid?=
 =?us-ascii?Q?GSvwTr5DPjziXHMNZ5KPuVq3PW4lUpBx1vKaN1oP2LyopKqVycjPNW0FEsoN?=
 =?us-ascii?Q?cEMJHImRnhvaDii6OOaHvIrkx0vHOE5SuC1XpGMcSeK+p9PTk+hXYnJCHCma?=
 =?us-ascii?Q?NYUdAd9C2wMf46knHwTcWbo2UyyOsEKFa7IiOe9M1kN2+19aoHeqSRv+3fNA?=
 =?us-ascii?Q?6HAjIPNXfdtXDw0Twv22IG2ZCLsdPhOoAni5vpF3mGBHayo/NZTOWdcGpxpJ?=
 =?us-ascii?Q?1AGjMmCOBE4QJCCDveEmlQv/8Zfj3TfeE1a4/qUrS+3E0Oy70sMGaoLjwUNu?=
 =?us-ascii?Q?hjygpK9UALYkqrYspXjaM/S1gegLuliUIgkxaJ+B6VKZhuZPMBqz6RhUy2E8?=
 =?us-ascii?Q?S5NcjX8ljQe14HTC1Qz7t7Q94yM/ad2h6wYHkSJCvQyoXcI8tjMlyfbncBAl?=
 =?us-ascii?Q?v+0DzSaaJj3l9z94GM24V8JlpqoFSBJqUp61CN0zK99jHPxWkcEp0I1Xd/Ec?=
 =?us-ascii?Q?L79qPncaBDH15Q0cfpea+gtyTSK3OfqDr2yrwsPNtoBuVcp3zaxtdMn8Y7ZL?=
 =?us-ascii?Q?LGw7WXUCzBYinQDGwtauZNxoJbvFZutdpqGtx9g6tUOPje1L0dqXDmTblaqO?=
 =?us-ascii?Q?UA394oLuMACZTICZ8KORMyrQqE2EsUrdv2Ah/6h5FBhJwtUMflY0cxjiPi28?=
 =?us-ascii?Q?q+j4YN72Xs3Ovem/eAb6laahk41V4bUkPc5MwoEBSo6X7vASPdVpVcRmfBpG?=
 =?us-ascii?Q?C2bj/Epf1jzck3o0HVl5U7HtQq++x+7ej5V53y1bHpdmXmG6+tHQyMbYEnwA?=
 =?us-ascii?Q?DjBZj2CKMY1H3hXRTICD2uI/sFA+KPzG7Zw6uBNZH88it9DlzThhKqUQ8J/O?=
 =?us-ascii?Q?eEOzzQtwZEVKVYOQGVKFoiyvE+5Tgx+sBSqYpUGLL4AYMBpfIZpiy+eLxr2H?=
 =?us-ascii?Q?LKHT4XstN4nkFIJdl/oXgF5LQpTIeGadmleE4OyIZI2uv3OOJwt5+W5E9ckI?=
 =?us-ascii?Q?4s5gWg5zoyobCdAst7Zyhg19wk/0JR+wXJgJmnqVafDrPSIAJkwOw/BWxSiL?=
 =?us-ascii?Q?pnP4li0H8Z0h8qYfAzOa4+xWpIWLagsSMdZ+CH7Ot+AUi9FhzJTFF4f64vhI?=
 =?us-ascii?Q?ZHWl9eLJicHPLIK7GNkAVe62dn6TKikeGpkMUgJrz2b45ZrLkEQ9qWOOUFAM?=
 =?us-ascii?Q?S/4Hrvexv5SBvkkRXFPkWfr7FJAnjojcNXorkYMfdintXyrtUQPmjnn48DKe?=
 =?us-ascii?Q?svQ32eBgtzpdbdAAYBfxOs/tbwwmYZdU62r0oOHQHutY6awaa85xFMMs5RZb?=
 =?us-ascii?Q?phJGb4oQP/dRmH1QxukTQTmTA1Dh5wABbhIqcE73tfNj5SqSz3Ztv/znOFND?=
 =?us-ascii?Q?s42yNiFifwCGLnh8EYhuxGeMDfcpgilBb0TtAowN7THzDiVWWHC4BupG94tz?=
 =?us-ascii?Q?Y6IrGCjWxV2Y4s/RygnwVs0KVoJL/OnMpFLpAAUl5YCvmtl+zcSjYlSNFhdN?=
 =?us-ascii?Q?idpFlmcoz4ICMmTP4Hl0JKwazV9yYVSQAzB55KOKTpuxa4RvKo+Kdar7C31R?=
 =?us-ascii?Q?hGFxdHNVxE35DxYXh2A6X5Y3Ylpfbm/O9JTHmjBdoxLm78B8wfAwt2Htyd8q?=
 =?us-ascii?Q?pQ=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 445cccf6-4b18-48b0-524e-08dbf014282d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 13:15:56.8362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hSAS0MTUmHqSiLoI6cXLkN5Idgdy+kYxHMYHNKYKYiITftFYV1ojROZhEqklh0b8bw1ypKG9UdnvxIxLIo+apS+iH7yR6UsHm1SLHs6niLI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR17MB6819
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 05:16:39 -0800 (PST)

On Tue, Nov 28, 2023 at 10:45:02AM +0100, Michal Hocko wrote:
> > 2) Should we combine all the existing operations into set_mempolicy2 and
> >    add an operation arg.
> > 
> >    set_mempolicy2(pidfd, arg_struct, len)
> > 
> >    struct {
> >      int pidfd; /* optional */
> >      int operation; /* describe which op_args to use */
> >      union {
> >        struct {
> >        } set_mempolicy;
> >        struct {
> >        } set_vma_home_node;
> >        struct {
> >        } mbind;
> >        ...
> >      } op_args;
> >    } args;
> > 
> >    capturing:
> >      sys_set_mempolicy
> >      sys_set_mempolicy_home_node
> >      sys_mbind
> > 
> >    or should we just make a separate interface for mbind/home_node to
> >    limit complexity of the single syscall?
> 
> My preference would be to go with specific syscalls. Multiplexing
> syscalls have turned much more complex and less flexible over time.
> Just have a look at futex.

got it, that simplifies things a bit.  I can pull my set/get mempolicy2
work forward and just keep the interfaces pretty much the same. Only
difference being an argument structure that is extensible and possibly
some additional refactoring in do_get_mempolicy to make things a bit
cleaner.

~Gregory