Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3836955rdh; Tue, 28 Nov 2023 05:21:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwNRtutDjjuyZQQBxD5aVNGhWPFmKNEod+sxB4ReCtWXvO9GweovFZzHL2mNRSx6UAaU+u X-Received: by 2002:a05:6808:11cd:b0:3b2:e2d5:bcec with SMTP id p13-20020a05680811cd00b003b2e2d5bcecmr13376917oiv.47.1701177694707; Tue, 28 Nov 2023 05:21:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701177694; cv=none; d=google.com; s=arc-20160816; b=ygak7qBWnV4KQs/rGqmft+nvrn8GZWaHXYmNSCc15ZdS/MhgGUKpHGZ6esIuvwuYue cPBoYOc396tPCgxlF61Ef1gV3QfS99DgbJIzzJ68aeFSvZc1YYB8VNxpBpF7bG+wodah 223/CWL26a7rRSMyKvtyV9x7BxaclaPgvj++pr9/YzTqIEpoUURqrkmG7P83VndMyNlE MGXQZwiXnv8/OdkqXb2f30bSA0d4me9n8pqK18EhsYC/lgC4UHNw1Ya4jnR+Rm100MPS ZoY0kql7rfjaQHThknbu0mdPjv6kUyMmZ7tHd7yzu8mif+j7ewnZs9oF4BY+xgEAsHm0 H7aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=TdI1A5jMJB3S+mT6Vya6W/Cnp8bW/jZIMMFDG6dHCr4=; fh=t6cplH0IXxURg0apbxq10Jg7SnDsmJudNWMxVKS0NkQ=; b=Y9ISkXP0OkGFSS8jP41XDaJo0noY1mpWzBeIyk3vLFOsTMI1Vc9DQVYaEuioLilcG3 sely1ZLgDDte/v7tqeb5AOnUQWT6azaoy6QiQ94nmabkeF9CuKHf41EbeTxr+6Xxghuy 461PKWUP6mxwosPtVDsx/Bu87uQK0ZFuUxCqAyBCrRAlc9mx6j8kbOgMSmRhZeUgn8Ns jFPdBGyhmlWhI8lh0MZMLCZ5LEHugaQCN/Op0ZSzK7mKMRhdDg4XejpSHr/c92JMkZnF PSCa6LYS8s9QXD5+zwaWOkiaMOGEd9gL+rakttIMa/y4aRXBSaf08tbKtUuL1dz4+DQN z4mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gvo7FWXD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id s4-20020a656904000000b00577960a815csi11756058pgq.188.2023.11.28.05.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 05:21:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gvo7FWXD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 08F1B8074CC9; Tue, 28 Nov 2023 05:21:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345111AbjK1NVD (ORCPT + 99 others); Tue, 28 Nov 2023 08:21:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344566AbjK1NVC (ORCPT ); Tue, 28 Nov 2023 08:21:02 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A61DDA; Tue, 28 Nov 2023 05:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701177668; x=1732713668; h=from:to:cc:in-reply-to:references:subject:message-id: date:mime-version:content-transfer-encoding; bh=q8LFbcF8XIOorZjKnJKfcMWLygjGPUyZvF6azgdLJzc=; b=gvo7FWXDxhAFc8tRzZ1Zz7FHWB3LP5XsBc94smGcmXvep0nmrq6N4jSQ Cvqb77plH9SuqlimpEgknjaQFE5BNNXkY/+8rL7asCNWfpDtQGGOK9NT1 yQ2DS4K9l8ezz/558Lf8AyMsTIH/LjMi6w5IwUWUUZbpe6NBGSSoUaJfG Ek0e3i/SSx5oBg3251m4tIitHCjMV74S9O9bLBKFlUKpkhx3i/biWoOZ9 fZDuSZs4VVxfhmoITYr09wkA0DVqslnD+Vnq934sSZHg4wW61Qw1zQo2l pwFOOHOwzQsNiyNSU+8Qng4N3IIITdPgxvYn6S08fWy12J2IGByNFOvko Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="11618512" X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="11618512" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 05:21:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="16625071" Received: from mvafin-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.43.98]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 05:21:06 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: hdegoede@redhat.com, "Luke D. Jones" Cc: corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231126230521.125708-1-luke@ljones.dev> References: <20231126230521.125708-1-luke@ljones.dev> Subject: Re: [PATCH v2 0/1] platform/x86: asus-wmi: disable USB0 hub on ROG Ally before suspend Message-Id: <170117767063.1996.14540015573395714093.b4-ty@linux.intel.com> Date: Tue, 28 Nov 2023 15:21:10 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 28 Nov 2023 05:21:32 -0800 (PST) On Mon, 27 Nov 2023 12:05:20 +1300, Luke D. Jones wrote: > This is a fix for the ROG Ally not being able to use the N-Key device after a suspend/resume cycle. > > The root of the issue is that ASUS changed the MCU firmware to dfisconnect the USB0 hub when the > screen is switched off during the s2idle suspend path. I tried many many different tactics to try > and get this s2idle part to work but it seems there are races between this and other subsystems. > > What has so far been reliable and consistent is a manual call to the CSEE method that is called in > ACPI by the Microsoft DSM screen off path followed by a short sleep in asus-wmi. The PM prepare > hook looks to be the earliest possible place. A sleep that is too long ends up with USB subsystem > registering a disconnect, and thus on resume the device paths change. Too short and it is unreliable. > > [...] Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86: asus-wmi: disable USB0 hub on ROG Ally before suspend commit: e0894ff038d86f30614ec16ec26dacb88c8d2bd4 -- i.