Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
MIME-Version: 1.0
References: <20231121094642.2973795-1-qiujingbao.dlmu@gmail.com>
 <20231121094642.2973795-3-qiujingbao.dlmu@gmail.com> <09b29f1f-a42b-49f7-afca-f82357acd4c8@linaro.org>
In-Reply-To: <09b29f1f-a42b-49f7-afca-f82357acd4c8@linaro.org>
From:   jingbao qiu <qiujingbao.dlmu@gmail.com>
Date:   Tue, 28 Nov 2023 21:22:52 +0800
Message-ID: <CAJRtX8TU9Z3OXL1zw9+mGNhxugp_C2jo40k-s9V2byNCQeBoLQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     a.zummo@towertech.it, alexandre.belloni@bootlin.com,
        krzysztof.kozlowski+dt@linaro.org, chao.wei@sophgo.com,
        unicorn_wang@outlook.com, conor+dt@kernel.org, robh+dt@kernel.org,
        conor@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, linux-rtc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 21, 2023 at 6:01=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 21/11/2023 10:46, Jingbao Qiu wrote:
> > Implement the RTC driver for CV1800B, which able to provide time and
> > alarm functionality.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> > ---
> >  drivers/rtc/Kconfig       |  10 ++
> >  drivers/rtc/Makefile      |   1 +
> >  drivers/rtc/rtc-cv1800b.c | 293 ++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 304 insertions(+)
> >  create mode 100644 drivers/rtc/rtc-cv1800b.c
>
> Bindings were not tested, so I assume you did not compile the code
> either. Please confirm that you fixed all warnings pointed out by W=3D1
> builds, smatch and sparse. All of them.

 will test & fix in next version

>
> >
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index 3814e0845e77..2089cceea38c 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -1103,6 +1103,16 @@ config RTC_DRV_DS2404
> >         This driver can also be built as a module. If so, the module
> >         will be called rtc-ds2404.
> >
> > +config RTC_DRV_CV1800B
> > +     tristate "Sophgo CV1800B RTC"
> > +     depends on ARCH_SOPHGO || COMPILE_TEST
> > +     help
> > +       If you say yes here you will get support for the
> > +       RTC of the Sophgo CV1800B SOC.
> > +
> > +       This depend on ARCH_SOPHGO and COMPILE_TEST. Please
> > +       first config that.
>
> ...
>
> > +static int cv1800b_rtc_probe(struct platform_device *pdev)
> > +{
> > +     struct cv1800b_rtc_priv *rtc;
> > +     struct resource *res;
> > +     int ret;
> > +
> > +     rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL);
> > +     if (!rtc)
> > +             return -ENOMEM;
> > +
> > +     res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +     if (!res) {
> > +             ret =3D -ENODEV;
> > +             goto err;
> > +     }
> > +
> > +     rtc->core_map =3D devm_ioremap_resource(&pdev->dev, res);
>
> Use helper combining these two calls.

Ok, will use devm_platform_ioremap_resource() to replace it.

>
> > +     if (IS_ERR(rtc->core_map)) {
> > +             ret =3D PTR_ERR(rtc->core_map);
> > +             goto err;
> > +     }
> > +
> > +     rtc->irq =3D platform_get_irq(pdev, 0);
> > +     platform_set_drvdata(pdev, rtc);
>
> Your code has random order. First you get IRQ, then you check its value,
> then you go further.

ok

>
> > +     if (rtc->irq < 0) {
> > +             ret =3D -EINVAL;
> > +             goto err;
> > +     }
> > +
> > +     ret =3D
> > +         devm_request_irq(&pdev->dev, rtc->irq, cv1800b_rtc_irq_handle=
r,
>
> Wrong wrapping.

ok

>
> > +                          IRQF_SHARED, "rtc alarm", &pdev->dev);
>
> Why shared?

ok

>
> > +     if (ret)
> > +             goto err;
> > +
> > +     rtc->clk =3D devm_clk_get(&pdev->dev, NULL);
> > +     if (IS_ERR(rtc->clk)) {
> > +             dev_err(&pdev->dev, "no clock");
>
> This code is not ready for upstream. There are multiple things wrong here=
.
>
> First, syntax is return dev_err_probe.
>
> Second, you do not have clocks and you do not allow them! Just open your
> binding.

I'm not fully understanding here, can you elaborate more?
as there is clocks info like this in the dt-bindings:
 clocks =3D <&osc>;

>
> Third, use wrapper - devm_clk_get_enable or something like that.

I will use devm_clk_get_enabled() to replace it.

>
>
> > +             ret =3D PTR_ERR(rtc->clk);
> > +             goto err;
> > +     }
>
> Blank line.

ok

>
> > +     ret =3D clk_prepare_enable(rtc->clk);
> > +     if (ret)
> > +             goto err;
>
> Blank line.

ok

>
> > +     ret =3D cv1800b_rtc_softinit(rtc);
> > +     if (ret)
> > +             goto err;
> > +     cv1800b_rtc_alarm_irq_enable(&pdev->dev, 1);
> > +     rtc->rtc_dev =3D devm_rtc_allocate_device(&pdev->dev);
> > +     if (IS_ERR(rtc->rtc_dev)) {
> > +             ret =3D PTR_ERR(rtc->rtc_dev);
> > +             goto err;
> > +     }
> > +     rtc->rtc_dev->range_max =3D U32_MAX;
> > +     rtc->rtc_dev->ops =3D &cv800b_rtc_ops;
> > +
> > +     return rtc_register_device(rtc->rtc_dev);

I find the commet of devm_rtc_device_register wirte
=E2=80=9CThis function is deprecated, use devm_rtc_allocate_device and
rtc_register_device instead=E2=80=9D
but all of code about this, they all use devm_rtc_device_register
function. So which one do you suggest I use?

> > +err:
> > +     return dev_err_probe(&pdev->dev, ret, "Failed to init cv1800b rtc=
\n");
>
> Drop, just return.

ok

>
> Best regards,
> Krzysztof
>

Best regards,
Jingbao Qiu