Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3843668rdh; Tue, 28 Nov 2023 05:31:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtzJ4WYcjeGNru/JdOMsVysK9LDOzOaZFGnPV64L2QiTUEsuwMfnnYEtVNY6R5mTbPQRGY X-Received: by 2002:a17:903:2292:b0:1cf:ba9d:abc0 with SMTP id b18-20020a170903229200b001cfba9dabc0mr12017484plh.67.1701178314321; Tue, 28 Nov 2023 05:31:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701178314; cv=none; d=google.com; s=arc-20160816; b=Mo0g8sxMj6/dgwrPCK2i12CNlTtwqYZ11znerZva6SU/Gp2NpxJmJda4yVeefy8GI8 CfgYGDkIDdhGF8cRT1V9G4CWRwiJfkApTvzwsnc5ibbkTXXROnb9h9s/nNzcCtaQk4Gs +EyuStsxPATF9shuN7XfeV0gQZKDuslZW3kQMP2scgMKP/2G5yVAuOoUoetxAxiDQaI1 JMvvY7mlxIBgpCzrmzPmyqT8FVf/UQnGDG7BQEzieEKnRHYQpQNVEd+dIG0YdmnHyitZ EeqSGxNwLmkZ4hTXtZffkWK62leZhFxXwvaAplNAOXDf/3wVg+d+lYjFbhpctLI1g8lc Teig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=25BJolsQx0uLt5rnS4I4hKyenr1l/iYuTg4HynQIPjo=; fh=fMSwoP07RiwO9LlX3F3HUk5L0URwGpfxAQVZpq8agu8=; b=e2lwBZnWDquARCLDXRI3P/FianFCtvirHA9MZstcVDlxrEfco5eahxFozy9iBf7RrF w67+3SYS2uCBDr99aU1ovAGrMuav2MpCFr7GBZN/7zrx/C8mWhQuDg5aRNJ9Twq4cuBR qfnRwUIVbxiE2HA0Qn1gOnI+0cH1GRqUR8alUt3l8cQcjLaldp4iFkJ9VfIQFIvIrqLQ 2Lj2GGioVYvQVAdW+c3ZozcA26K8bMEliK6eLLzT4rpScRSh1SUAjo1mri5I9TEHDvnD MmRlhD1oz2zJ5ZbAoOvqND3ipOTynCX+cDhrEppcUOD7xnk4IPPhcql2vwWnZd0Rrvx6 mUyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ILUabpPq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id p3-20020a170902e74300b001c9d9050b37si12054009plf.260.2023.11.28.05.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 05:31:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ILUabpPq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 797E78072A22; Tue, 28 Nov 2023 05:31:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344784AbjK1Nb3 (ORCPT + 99 others); Tue, 28 Nov 2023 08:31:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344120AbjK1Nb1 (ORCPT ); Tue, 28 Nov 2023 08:31:27 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62EB6DA for ; Tue, 28 Nov 2023 05:31:33 -0800 (PST) Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 075FF66072EC; Tue, 28 Nov 2023 13:31:30 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701178291; bh=8HUp/WY5zNsYwdk4O1u0ndjuhKYGp+ookzfWUOsLC5k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ILUabpPqvJxRThGJqMdOStIeS8rJvnC/llD2ycYqV4NAjq8yfRHKpUArEWSG8srje kFFl1eqbgiGEQvZ2wIuhvXN9uOh73dA7VSkxgTD8kqvSiwi/tpVhtutsBNRn1tMXR/ OocQ6PSLwk9HVB/1/NwjM9GZplLkXwk3j74FxCzJzDAa5/sONYi9NcKTzWGiDFYQ8q P1QMyGYYcOK6biNxFohS2JBjDKgATf4SATAd2W9OgfSEFcU1+Dqbb96Ff8Bt9cimAI x8idbxORk5kLuO/qk4vHYnToiW7OHqrXW5lqUnSyS1cVMxZdmhkGGqaKT1C1LAiglf eCnf07jPAWDfQ== Date: Tue, 28 Nov 2023 14:31:27 +0100 From: Boris Brezillon To: AngeloGioacchino Del Regno Cc: robh@kernel.org, steven.price@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, m.szyprowski@samsung.com, krzysztof.kozlowski@linaro.org Subject: Re: [PATCH v2 2/3] drm/panfrost: Add gpu_irq, mmu_irq to struct panfrost_device Message-ID: <20231128143127.5d52b75f@collabora.com> In-Reply-To: <20231128124510.391007-3-angelogioacchino.delregno@collabora.com> References: <20231128124510.391007-1-angelogioacchino.delregno@collabora.com> <20231128124510.391007-3-angelogioacchino.delregno@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 05:31:51 -0800 (PST) On Tue, 28 Nov 2023 13:45:09 +0100 AngeloGioacchino Del Regno wrote: > In preparation for adding a IRQ synchronization mechanism for PM suspend > add gpu_irq and mmu_irq variables to struct panfrost_device and change > functions panfrost_gpu_init() and panfrost_mmu_init() to use those. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_device.h | 2 ++ > drivers/gpu/drm/panfrost/panfrost_gpu.c | 10 +++++----- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 10 +++++----- > 3 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h > index 0fc558db6bfd..54a8aad54259 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.h > +++ b/drivers/gpu/drm/panfrost/panfrost_device.h > @@ -94,6 +94,8 @@ struct panfrost_device { > struct device *dev; > struct drm_device *ddev; > struct platform_device *pdev; > + int gpu_irq; > + int mmu_irq; > > void __iomem *iomem; > struct clk *clock; > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c > index bd41617c5e4b..7adc4441fa14 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c > @@ -454,7 +454,7 @@ void panfrost_gpu_power_off(struct panfrost_device *pfdev) > > int panfrost_gpu_init(struct panfrost_device *pfdev) > { > - int err, irq; > + int err; > > err = panfrost_gpu_soft_reset(pfdev); > if (err) > @@ -469,11 +469,11 @@ int panfrost_gpu_init(struct panfrost_device *pfdev) > > dma_set_max_seg_size(pfdev->dev, UINT_MAX); > > - irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "gpu"); > - if (irq < 0) > - return irq; > + pfdev->gpu_irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "gpu"); > + if (pfdev->gpu_irq < 0) > + return pfdev->gpu_irq; > > - err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler, > + err = devm_request_irq(pfdev->dev, pfdev->gpu_irq, panfrost_gpu_irq_handler, > IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev); > if (err) { > dev_err(pfdev->dev, "failed to request gpu irq"); > diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c > index 846dd697c410..ac4296c1e54b 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > @@ -753,13 +753,13 @@ static irqreturn_t panfrost_mmu_irq_handler_thread(int irq, void *data) > > int panfrost_mmu_init(struct panfrost_device *pfdev) > { > - int err, irq; > + int err; > > - irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "mmu"); > - if (irq < 0) > - return irq; > + pfdev->mmu_irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "mmu"); > + if (pfdev->mmu_irq < 0) > + return pfdev->mmu_irq; > > - err = devm_request_threaded_irq(pfdev->dev, irq, > + err = devm_request_threaded_irq(pfdev->dev, pfdev->mmu_irq, > panfrost_mmu_irq_handler, > panfrost_mmu_irq_handler_thread, > IRQF_SHARED, KBUILD_MODNAME "-mmu",