Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Tue, 28 Nov 2023 15:28:55 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Gregory Price <gregory.price@memverge.com>
Cc:     linux-mm@kvack.org, linux-doc@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
        linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de,
        luto@kernel.org, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        tj@kernel.org, ying.huang@intel.com,
        Gregory Price <gregory.price@memverge.com>
Subject: Re: [RFC PATCH 02/11] mm/mempolicy: swap cond reference counting
 logic in do_get_mempolicy
Message-ID: <ZWX5J5frMXCnO1HW@tiehlicka>
References: <20231122211200.31620-1-gregory.price@memverge.com>
 <20231122211200.31620-3-gregory.price@memverge.com>
 <ZWX0Dq6_-0NAFgSl@tiehlicka>
 <ZWX0ytAwmOdooHdZ@memverge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZWX0ytAwmOdooHdZ@memverge.com>
Precedence: bulk

[restoring the CC list, I supect you didn't want this to be a private
discussion]

On Tue 28-11-23 09:10:18, Gregory Price wrote:
> On Tue, Nov 28, 2023 at 03:07:10PM +0100, Michal Hocko wrote:
> > On Wed 22-11-23 16:11:51, Gregory Price wrote:
> > [...]
> > > @@ -982,11 +991,11 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask,
> > >  	}
> > >  
> > >   out:
> > > -	mpol_cond_put(pol);
> > > +	mpol_put(pol);
> > >  	if (vma)
> > >  		mmap_read_unlock(mm);
> > >  	if (pol_refcount)
> > > -		mpol_put(pol_refcount);
> > > +		mpol_cond_put(pol_refcount);
> > 
> > Maybe I am just misreading the patch but pol_refcount should be always
> > NULL with this patch
> > 
> 
> earlier:
> 
> +               pol = pol_refcount = __get_vma_policy(vma, addr, &ilx);
> 
> i can split this into two lines if preferred.
> 
> If addr is not set, then yes pol_refcount is always null.

My bad, missed that. Making that two lines would be easier to read but
nothing I would insist on of course.

-- 
Michal Hocko
SUSE Labs