Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3901256rdh; Tue, 28 Nov 2023 06:54:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdBbCBuNTZRWfcmTPhwlFcXK+9jM274XLmgaEJRZmoWeyhYOTgQ8Ms+N+lAkkDTT9fw7M8 X-Received: by 2002:a05:6e02:20c7:b0:35c:daf4:6984 with SMTP id 7-20020a056e0220c700b0035cdaf46984mr8009358ilq.28.1701183245483; Tue, 28 Nov 2023 06:54:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701183245; cv=none; d=google.com; s=arc-20160816; b=ipnZvwSh4N2RE9YMVzE6ZrslZHCfpd8Rx1wmmlOKOak0kzvDcodtSk0tmm/OyRz2F5 I96tZ5/W3+fkz+xwnmRkR523iZlSGP84EydoaUTWa6K94ZRmx+VVUdsdI+r+i9bv7R6D 9UG8DjBCFGdWivcaev6zdxcmi4TQtobzpQjFULHnv2sicvP/nW4qDjvJlriOoOlLzhws 9tNjTncDHxhjxNFPL0MQpsRael8gA+21IC8kC/JtP775zqiUYHEu5UGVpzgIIjpI820v F1M6YGFJKXM3lTfwZlCgJ1+MCae+7h83EmnY8D3IzVn0uOhQFlVq/bjmnkj9B18Tj8VU qSEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:references :in-reply-to:subject:to:from:date:message-id:dkim-signature; bh=c0ZYNzVGoVR3LZ+hHwpYGP5HK9+rOwCC30iQUuzfSqs=; fh=Xu1WmTmT3FlWTcydnpHFjjYQQKmci+Dbf36GXxl/j5k=; b=W9S4y+1Hb9zxFViK0lTtEnheLTes7ARluDEUs4erTFgIDEaEay36tvz+qZKZ/LD6rQ Uh9pArXIROl/ipXdxviEWIMcJl677ZYr+obmUmEM2CMiKTssVs7NY413g99Y+3/6mwGC a89UbreD9TFJFk75kKSTLgk1NaK/9iQIv2M8IItHMY7sEkKG8z0DGzEeotm6dJxOKAXx +2hHOD/jkWccgByZJi2taG5DfAdSLY2RRkQHpFls+4g3ni5yVR+2XGH2i7xFAN6mMJ7S 2tr3K/uH64yIKHG2ig4l/LWkxX703StEbY64XouE2VmKDpIXYkQLmRF0IGBZP3KG4Qcw JtVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDEW4XCa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id l3-20020a63ba43000000b005bd366fd5a1si12177681pgu.449.2023.11.28.06.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 06:54:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDEW4XCa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 75D48807C570; Tue, 28 Nov 2023 06:54:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346308AbjK1Oxo (ORCPT + 99 others); Tue, 28 Nov 2023 09:53:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346283AbjK1Oxe (ORCPT ); Tue, 28 Nov 2023 09:53:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79C0419A8 for ; Tue, 28 Nov 2023 06:53:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF618C433C8; Tue, 28 Nov 2023 14:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701183220; bh=s13LC6ZqOcgJuEDiOYtPEnnI1TIenYkNDeB6eVAchC4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=aDEW4XCa8SiymRXB0L2NQ5E/+Z5gKrj4cHbcCIsyw7DORAnxXmZVmpk8OhkjlxD5X 0RJwRQv5oQWvY9qXn+Ln8lTjUILh7algqre7fmf5Gyxt/hEeynyGo0dvSx8ZUxLgl8 mDk4PI3DUrraphNasAYxBhreq6Mb1w578WIHfGuHv1WXFDMuM6t79iTC9/cTFYgpac 81etA5a0+Y3W330lqFDudyhlfDUy/Ap08JhnQoctVgVsWcQWlIXnhzmQFoPbLSQ0v8 HzOVn8mKmHWH5vauMeR4wYHPUgKmgbbxFQ+bvwEr0m7+bLLziJDHTdQWCNpn0bYAeX qHut2Jwff8t5w== Message-ID: <0977ffcd30973d0edc1ae4132216b094.mripard@kernel.org> Date: Tue, 28 Nov 2023 14:53:37 +0000 From: "Maxime Ripard" To: "David Gow" Subject: Re: [PATCH v2 3/3] drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER In-Reply-To: <20231128072410.952662-3-davidgow@google.com> References: <20231128072410.952662-3-davidgow@google.com> Cc: dlatypov@google.com, kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, "Benjamin Berg" , "Brendan Higgins" , "Kees Cook" , "Maxime Ripard" , "Nathan Chancellor" , "Nick Desaulniers" , "Rae Moar" , "Richard Fitzgerald" , "Tom Rix" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 06:54:02 -0800 (PST) On Tue, 28 Nov 2023 15:24:07 +0800, David Gow wrote: > In order to pass functions to kunit_add_action(), they need to be of the > kunit_action_t type. While casting the function pointer can work, it > will break control-flow integrity. > > vc4_mock already defines such a wrapper for drm_dev_unregister(), but it > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime