Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 28 Nov 2023 09:54:37 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Dmytro Maluka <dmaluka@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Sean Paul <seanpaul@chromium.org>,
        Arun Easi <aeasi@marvell.com>, Daniel Wagner <dwagner@suse.de>
Subject: Re: [RFC][PATCH] tracing: Allow creating instances with specified
 system events
Message-ID: <20231128095437.423f5f88@gandalf.local.home>
In-Reply-To: <20231128092029.342f5f03@gandalf.local.home>
References: <20231127174108.3c331c9c@gandalf.local.home>
        <ZWXntcHNflkbrxd7@google.com>
        <20231128092029.342f5f03@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 28 Nov 2023 09:20:29 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 28 Nov 2023 14:14:29 +0100
> Dmytro Maluka <dmaluka@chromium.org> wrote:
> 
> 
> > This limitation will cause (unrelated) events created by modules that
> > are insmoded after creating the instance to be also added to the
> > instance. Why not filter those as well?  
> 
> I did think of that. But that would be a separate patch. Where I would save
> the string that is passed in, and whenever a new module is loaded, it would
> only add the events if the events' system matches in the string. This would
> also allow adding event systems that do not yet exist.

Now that I'm implementing this, it makes more sense to just do that as one
patch. Otherwise the check against the systems string is redundant, as the
creation of the events needs to check against the tr->systems too. I found
that I was deleting most of this patch to implement the change.

-- Steve