Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 28 Nov 2023 11:05:18 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Thomas =?iso-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>
CC:     <linux-doc@vger.kernel.org>,
        Francois Dugast <francois.dugast@intel.com>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        "Boris Brezillon" <boris.brezillon@collabora.com>,
        Danilo Krummrich <dakr@redhat.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        <intel-xe@lists.freedesktop.org>
Subject: Re: [Intel-xe] [PATCH v5] Documentation/gpu: VM_BIND locking document
Message-ID: <ZWYPvhDzmqipdhC/@intel.com>
References: <20231121104046.3201-1-thomas.hellstrom@linux.intel.com>
 <ZWTvohD9rTx9aAWa@intel.com>
 <03712311650b5fcf7162309f13a18dbd240e8a9f.camel@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <03712311650b5fcf7162309f13a18dbd240e8a9f.camel@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?1snx0pEL7dTTfMQ+Q8Hbr4at2cgWOuEJIaDgxoJat50Dr6OQvD2ZeSxWX2?=
 =?iso-8859-1?Q?p2QoPkKokojtdYD3FDHMbpYbdxW1bemTerElzMoJeEo0FF7MN4vhStmvy0?=
 =?iso-8859-1?Q?ETb2bDraj6tLRIudHIw9rLRZFiTIMoppuwA50YTssR9CxTJi2zkGsQMRdx?=
 =?iso-8859-1?Q?GXDFHhZL7YSbm3qN3W6RVL+yU9+lU7E9ZxXkW6ov2sWRADV2G6PP6RWvEf?=
 =?iso-8859-1?Q?DPUWtwQ2D1axHCcGTjN6LJGIzzyTBxknGFVZZdDsokCB0U6MS7/MJRDzxC?=
 =?iso-8859-1?Q?paVdOe/V0PH9452hEf/IK6FK0A6LNg1mhd1PpwOQQ9rKsLg+cxX8iacRXt?=
 =?iso-8859-1?Q?JoaAKoESz24uqafQAEgug9N/q2pZVmi6m8IgAco7EbEetsvDaIIzJ6qF1P?=
 =?iso-8859-1?Q?BDcVAeVavnB0aj19rkHKgcBGLW+SGjF+dHikBQDtEYWeDGFpqMC14oWbOX?=
 =?iso-8859-1?Q?7It1zg0jU0PqRx2f4hwMgI6awYqEzXZdmLqyIBrL/8uLLeJpq6M8Tgm//A?=
 =?iso-8859-1?Q?d/xVvcnLPmu5OnVy2eZlD4bWkGpF7+ufyWZ5WmnVVLY8G6UtuQ4SCQWfrA?=
 =?iso-8859-1?Q?kEL5MdL5UZOksbXHLynaggDcH1aiZQKDB/VlEHI7q5JwBLPw5P5YI8EaPC?=
 =?iso-8859-1?Q?aJRTHGbWLrtZPHrBv3Lt7P4krXzZMrkzcP6mRzc3j7MBNISoXJcfT4otbf?=
 =?iso-8859-1?Q?kt3/VYEWSK2ygf4X1Hjc52ZrFrytsy8K5O05nKmSWuS5CnvF5gx2F0buTU?=
 =?iso-8859-1?Q?bMfaJA7rerJ0M2RqDc0CKnsFL5rjREru7iBHbGYl+M5Qx2uPdH7fXWmaJn?=
 =?iso-8859-1?Q?oJd9ZZiFQNTb+q3qBdsR2YXCNWXMGLiyRVlHlP/mbmA/61wLFzomCjNsiH?=
 =?iso-8859-1?Q?bOzZlkaVJ981be8ruL0NFDeBEy847Ik6cWfi4PrejwHJewXcA9rJIL+hGA?=
 =?iso-8859-1?Q?kjZCFju3CPQ+TXr6RnQhjxjyCp05tA4hF17TtPvL+Ac+BKElBxwHr6FMEc?=
 =?iso-8859-1?Q?D7x2FNytZIGaicFmJm8DZmZm0uNJFzXE65eeYjbZVloBbHxATSsSK+qA+S?=
 =?iso-8859-1?Q?hp3djBviP8/v1Xi7tOf7kKUMCTwI2ZrpCfmyroZ4wQz2uuMHJuz6Dr/bDM?=
 =?iso-8859-1?Q?/DO6uddSZbHFSsJ5WkkzLIWYbA7GN6+68U4gfky1Pn7zzt6dnahhpbtBDz?=
 =?iso-8859-1?Q?EgOZKBFjVyYFincWBbNfoc7T3xuZT95trUlxY0bt87+vlhHFjwwODRH1HE?=
 =?iso-8859-1?Q?gkcKzghhllxsmv4G+WI59mMSMY8h8GLL1Qh1QiZq+CPzWCj3caXtj8ipdg?=
 =?iso-8859-1?Q?Avv49b0CPy5UpESNDUIZdbw99AquFd6R6WWglx1qwag27XD64mOQal44CG?=
 =?iso-8859-1?Q?7AloCphH+eEEAYxSJS/3NncZbQJ/QA5eQfz2Y7iA6bBa9O2luhFh1+gFQZ?=
 =?iso-8859-1?Q?9OsVI4gEs4Khe/uCak5SF9VVLRubKnEn2q4dyru7cUrCg2aomkyhunKn3j?=
 =?iso-8859-1?Q?3YGtfcd+PENB5By7cx68wIcsNxBtpRLkVeI941Y5y3KzVPcOihcOZlJwZS?=
 =?iso-8859-1?Q?R6sQKsNFCognhT7fPOrvpVbGjMTcmlnVlhSygBgifJyAfEvHaG0gPCrTny?=
 =?iso-8859-1?Q?EmRV6LrtQn7rFkBksKZ6ulXahozR5JuEbdKmfjaaJoiZVG55fDC7hnww?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fde76c31-5a4c-474f-f338-08dbf02bd4c4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 16:05:25.1383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gg9V/zEhnSwmwAS65xCsSHvPhf/g4qkc83IUWiF9IDyePZZQ8LzsqnzIb60zSvlwjTKwtYsQMsMAWwXdJnRNfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7990
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 08:05:43 -0800 (PST)

On Tue, Nov 28, 2023 at 04:51:25PM +0100, Thomas Hellstr?m wrote:
> On Mon, 2023-11-27 at 14:36 -0500, Rodrigo Vivi wrote:
> > On Tue, Nov 21, 2023 at 11:40:46AM +0100, Thomas Hellstr?m wrote:
> > > Add the first version of the VM_BIND locking document which is
> > > intended to be part of the xe driver upstreaming agreement.
> > > 
> > > The document describes and discuss the locking used during exec-
> > > functions, evicton and for userptr gpu-vmas. Intention is to be
> > > using the
> > > same nomenclature as the drm-vm-bind-async.rst.
> > > 
> > > v2:
> > > - s/gvm/gpu_vm/g (Rodrigo Vivi)
> > > - Clarify the userptr seqlock with a pointer to mm/mmu_notifier.c
> > > ? (Rodrigo Vivi)
> > > - Adjust commit message accordingly.
> > > - Add SPDX license header.
> > > 
> > > v3:
> > > - Large update to align with the drm_gpuvm manager locking
> > > - Add "Efficient userptr gpu_vma exec function iteration" section
> > > - Add "Locking at bind- and unbind time" section.
> > > 
> > > v4:
> > > - Fix tabs vs space errors by untabifying (Rodrigo Vivi)
> > > - Minor style fixes and typos (Rodrigo Vivi)
> > > - Clarify situations where stale GPU mappings are occurring and how
> > > ? access through these mappings are blocked. (Rodrigo Vivi)
> > > - Insert into the toctree in implementation_guidelines.rst
> > > 
> > > v5:
> > > - Add a section about recoverable page-faults.
> > > - Use local references to other documentation where possible
> > > ? (Bagas Sanjaya)
> > > - General documentation fixes and typos (Danilo Krummrich and
> > > ? Boris Brezillon)
> > > - Improve the documentation around locks that need to be grabbed
> > > from the
> > > ? dm-fence critical section (Boris Brezillon)
> > > - Add more references to the DRM GPUVM helpers (Danilo Krummrich
> > > and
> > > ? Boriz Brezillon)
> > > - Update the rfc/xe.rst document.
> > > 
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Thomas Hellstr?m <thomas.hellstrom@linux.intel.com>
> > 
> > First of all, with Bagas and Boris latest suggestions, already few
> > free to use:
> > 
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > 
> > But a few minor comments below. Mostly trying to address Boris
> > feeling
> > of long sentences. However, take them with a grain of salt since I'm
> > not
> > a native english speaker. :) 
> 
> Hi, Rodrigo.
> 
> Thanks for the reviewing. I've added most but not all of the
> suggestions in v6. Regarding the comment about "zapping", that's used
> by the core mm for the process of unmapping page-table entries;
> zap_vma_ptes() etc. Merely following that, although I'm not really
> against using unmapping etc.

Perfect then. No concerns from my side.

Thanks,
Rodrigo.

> 
> /Thomas
>