Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 28 Nov 2023 12:24:13 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     David Ahern <dsahern@kernel.org>,
        Saeed Mahameed <saeed@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, Leonid Bloch <lbloch@nvidia.com>,
        Itay Avraham <itayavr@nvidia.com>,
        linux-kernel@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver
Message-ID: <20231128162413.GP436702@nvidia.com>
References: <20231121070619.9836-3-saeed@kernel.org>
 <2023112702-postal-rumbling-003f@gregkh>
 <20231127144017.GK436702@nvidia.com>
 <2023112752-pastel-unholy-c63d@gregkh>
 <20231127161732.GL436702@nvidia.com>
 <2023112707-feline-unselect-692f@gregkh>
 <ZWTtTjgBrNxpd9IO@x130>
 <20231127160719.4a8b2ad1@kernel.org>
 <20231128044628.GA8901@u2004-local>
 <20231128065321.53d4d5bb@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231128065321.53d4d5bb@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O1hDI6kiqAEZhy7bIU9iQMwP6K8pvq6NJicsl1XZEZBnQmLqpBdRDg6n8Aky?=
 =?us-ascii?Q?SArER0Hq+6L1wLTxuziZY4i/i5+QMhP6ZtXWnMAHFxPk1wzFYx4ty4tLM89s?=
 =?us-ascii?Q?LJiYst8EcE74BglCHmWVPCUHbKzMIkfTb7knv/hswGhbIFwguVmu53Yo0ryn?=
 =?us-ascii?Q?76GAaO9OWwZx2b3xVVG2hbfQrVKfp55kavsxvSwIfGzCfw5+hyFvYZTlqbfz?=
 =?us-ascii?Q?yO6z4JJa9CAOBaha/me23U4HXmx26ezvIobHqORh+x+a5Np4Il8cSgNojyAO?=
 =?us-ascii?Q?b1nVcOQITqQ/taG9xjvP/nbNHClt6iT3GviHg/sZ6iVIA2ImsWqORvG3UB+w?=
 =?us-ascii?Q?nIGdXYAcdqOaJV2AZhL7IcXLKW3P/hFuGvTn2irpU65NTuNvvg2hF65SksAg?=
 =?us-ascii?Q?4Qwf+rgw/EJz1aNcP9f6Ibmh8b7fV0uc2zRbuLrx8u1SXABSGXBVHjTOK6Al?=
 =?us-ascii?Q?3HdsrVyVznkNuZFGhi2weCqi16tbTpxfyQnkMH53yJl7HlOzBKFobd7om1hd?=
 =?us-ascii?Q?Dkj2a4Ql/8irpYmMCXkrHY0J9jKE1GSXuENNUSDMpRJQS28VxSJuftjVZ/Rr?=
 =?us-ascii?Q?DpS1xIx9/wdASFxs4AMlvX2hvFo5VTY0gn1GZPTsRhq7IMXTMTut4fTntN2O?=
 =?us-ascii?Q?o7WFTg0EQ0VGWYvthu2iV94/H8riK32yDI5crKwvBnyUFOu5uyiUX3wyepsg?=
 =?us-ascii?Q?AGGrjJnbYG1JQ94/XCX5pZ6XAu+b352Jy64YDLpuHixY0ru6CzD3CYf0CFAx?=
 =?us-ascii?Q?IzJb9AGr0RtKM+5I2Um3GlYmExO75RO1UyeVAwm2yWp8xQT4vh6miE7ZTmaH?=
 =?us-ascii?Q?U0UnUMAPcJbuEcEPnM2zCt/UPnQw5hKWS8T+5h4TdS8U1C/X62d8GkbVjGWh?=
 =?us-ascii?Q?ekwDLM0HuHD4xKtRKt6lxV6lDz24F+DsXONPhSUH8EM9Zdh0lJCvhTwxfG9W?=
 =?us-ascii?Q?DBMK/1AtXdO0a76/JEyh+JLQ8tc2B3HIUu6UjOUqNTVaMzNrQ7l5+gkFKnWH?=
 =?us-ascii?Q?jvSNGCfTrJHnwvrU4NTTH6s6tuAbi3Rvsk/LBH46gxkaLYxL7A0mcJkts4HJ?=
 =?us-ascii?Q?bgNmeDQiZ65dCzJKkgXE4UPQaxNLV3nACEs80dfuKZuxroyeyz1l1H0iRyKK?=
 =?us-ascii?Q?pQjCaGk3suCXYOHyqxmTJYEin62WqbSIHSTg2qhypsA5DhazvUoDt2W85/6H?=
 =?us-ascii?Q?koRXe0JLQZiaiRy/o0ywi8xVLS2NMgiMpZ9Hhjoj/PlzdHK5p7K3jOp8uO8P?=
 =?us-ascii?Q?pIjHYXMM1T6dq7wwrkUQYykwyaDa7Pc16wDEnEADM5oqVPlkz7JnC7QRSWJo?=
 =?us-ascii?Q?d+CY/0nPDCnmz4E99CiHaIKu69QqhHT/i7DKPblDRXznXQbGFVO94jK4q/uZ?=
 =?us-ascii?Q?5ZO62E/FM5HRnNHpth5MJ4dVtbW9sSTYVWAyZb3Eo1eL76OwyyzvR1bCPzHl?=
 =?us-ascii?Q?62ABWv82llAYLX6wYdEAq2xeB+icbDPQs+l1xRKdjLJwtjOIMNC2oNvTksJZ?=
 =?us-ascii?Q?6bLrsuCpz+9Qt0lRK8KKgId2M331cTG1hG1tz/D2Dq6hV4mLGvvydQnY+0t/?=
 =?us-ascii?Q?jjCGy7M6xlkdBeX/Or3p4nbrE1LEtFU7qzDudH++?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6575d196-417a-4efd-c669-08dbf02e7675
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 16:24:15.0980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NPUwWI4fqUG6YCrAJyo6AMRtxCVzLoSv1IneKybljp6Mhv62JQw5jTqsLPfNZhlJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8100
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 28 Nov 2023 08:24:30 -0800 (PST)

On Tue, Nov 28, 2023 at 06:53:21AM -0800, Jakub Kicinski wrote:
> > You said no to the devlink parameters as a way to tune an ASIC.
> 
> What? When?

You said you already rejected it at the very start of this discussion
and linked to the video recording of the rejection discussion:

https://lore.kernel.org/all/20231019165055.GT3952@nvidia.com/

This session was specifically on the 600 FW configuration parameters
that mlx5 has. This is something that is done today on non-secure boot
systems with direct PCI access on sysfs and would be absorbed into
this driver on secure-boot systems. Ie nothing really changes from the
broader ecosystem perspective.

The discussion starts at time index 22:11.

Dave (IIRC? sorry) is talking about unique things and suggesting
devlink. Many people in the audiance seem to support this idea

27:00 -> 28:00 you repeated this thread's argument about said NO
"occasionally you are allowed to use [devlink parameters] them"

At 29 you said just keep it all out of tree.

Oh, I chimed in around 30:00 saying it is not the kernel maintainers
job to force standardization. This is a user problem.

31:25 you said again "nothing"

31:30 S390 teams would like this and pushed back against "keep it all
out of tree" describing the situation as a "deadlock".

33:00 you said need two implementors for device specific parameters,
which misses the point of the discussion, IMHO.

And this was at the Dublin LPC, so over a year ago.

I second Dave's question - if you do not like mlx5ctl, then what is
your vision to solve all these user problems?

Jason