Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3971999rdh; Tue, 28 Nov 2023 08:27:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcimhFbDDHdDnrmwQhc3PmBcy+Qr3zNLEv2NGdz6JYyzK84uOtsoMHDZN8AAW17y0mBQcc X-Received: by 2002:a17:902:8543:b0:1cf:d0fe:5097 with SMTP id d3-20020a170902854300b001cfd0fe5097mr6458886plo.62.1701188840054; Tue, 28 Nov 2023 08:27:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701188840; cv=none; d=google.com; s=arc-20160816; b=J9xZjbpiUKkzRCipgkA5gc8k/Vs8lZhFyAH0XGVZeB3SFGfDyNskrMe+z8uTdpEC2s IeDJLTtpH9rBfVUxkSbbOfoiW/3BDtf/+EcCNULiOar/FCTTtT0dVtsfQV30zQ7IHl1M HPLFMUIkdaBe9XePog2ewROSEBmutEsOQ2RvFy5P+ZbjAqo9B910SXbn9V8r3FThJsTg bQlgI3y8BnMn0DrmGt3zpm0+A5gpy2GHXvbFAIzWx/kNdp83AZuwkpjnCGb30eYNdgNu wxrw2ttH4sG1/VqW/mXy9kQkDHoWwhEKTX6xiUP75+qPabyM7bXh+h1WPH8KOYebu+hg 5E2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=JS+aVqqKajhDrAbzfb9e4TmDET6rL4azE2+o/1eGIfs=; fh=VWO8QUzpSHrcEVSj15N74semdpDOxihYBrP9wGECEdA=; b=GcLqM+Psm/Y/mWUeNV131tvmWiROYaWg9yEN+VRxSzJMaimIU8LMe1LEzIpFBn61Y9 2/5IiF8ArgASCPoIGWpVRwbdsVLIZFpxJTNYkxS2pmwRiJW/kfyAXyRX610qO6ncXu6w cEBi4WiTyzSpsa75N/NrEjIcGlomNvhlTshhaJ29mVVru5ljVH1hfhYrcwBHOwxxNera O2s9zP/xcFSoyF/lXCVbxZHhtyKSf2BfAbeYqnY8DRF8Gc9JeYkG9SeXf+kaXY0kFO+J fyOEk5utzd0apVhglvA/kics753I8GbcK7kaNJ0YGzP8KIpRmEAswtC7LQo8eSAuq8wK bhDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XFWHfHx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id g23-20020a1709029f9700b001ce6452a744si11435401plq.445.2023.11.28.08.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 08:27:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XFWHfHx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 068B080B01CA; Tue, 28 Nov 2023 08:27:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbjK1Q1I (ORCPT + 99 others); Tue, 28 Nov 2023 11:27:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjK1Q1H (ORCPT ); Tue, 28 Nov 2023 11:27:07 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B781C98 for ; Tue, 28 Nov 2023 08:27:14 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D12C433C8; Tue, 28 Nov 2023 16:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701188834; bh=aK3/21f9RdYQmcl78FRdiNXVmir4FYYt7jy6fX2hIpg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XFWHfHx5ueIQ0Tg3EIGPSyC7hgzi/Jb+ytpkcUDYu3ppS3nmkvWds7wqI9z7dRVcv wqtgM/4geSq5d9Dx57DkPryfc0Vc9TbJX/wQEFuyy2COHIBYEkUBcuA+fgB6McUwG2 79TqcJTuYyZwXlkF/fFa+C2B/W+atrX2ecSTWUMLJBiIAbnu1dqxZYGSepbOM7leei 2Ati39yHhzabrAgw7BSTTAAEXsiX4tMvaBrM59ZFYGkFQ0iBScxMDL/qVwsGKMqJOk j71ETCHZKJgvr6s+ESmFYnqXHFJUZVAbz/7YJ28YU9GfDhOMwUoIYyN/Ye9bKwCalj Ra9G7fV0xue1w== Date: Tue, 28 Nov 2023 08:27:12 -0800 From: Jakub Kicinski To: Shinas Rasheed Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Haseeb Gani , Vimlesh Kumar , "egallen@redhat.com" , "mschmidt@redhat.com" , "pabeni@redhat.com" , "horms@kernel.org" , "davem@davemloft.net" , "wizhao@redhat.com" , "konguyen@redhat.com" , Veerasenareddy Burru , Sathesh B Edara , Eric Dumazet Subject: Re: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device unload control net API Message-ID: <20231128082712.223c4590@kernel.org> In-Reply-To: References: <20231127162135.2529363-1-srasheed@marvell.com> <20231127162135.2529363-2-srasheed@marvell.com> <20231127184306.68c2d517@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 08:27:19 -0800 (PST) On Tue, 28 Nov 2023 04:22:11 +0000 Shinas Rasheed wrote: > > On Mon, 27 Nov 2023 08:21:34 -0800 Shinas Rasheed wrote: > > > Device unload control net function should inform firmware > > > > What is "control net" again? > > Control net is just a software layer which is used by the host driver > as well as the firmware to communicate with each other, given in the > source file octep_ctrl_net.c and the corresponding octep_ctrl_net.h > interface, which is already part of upstreamed driver. Yes, I think it went in before I had time to nack it. I'm strongly against using the IP stack to talk to FW, if you read the ML you would know it. No new patches to octep_ctrl_net will be accepted.