Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3978652rdh; Tue, 28 Nov 2023 08:36:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTOIsCgaHHtFc/SkYwGab8aqJJds2bYjjHEaxI8gTmCjdWinAnpVeZ1qOVIkdezmbuTzcC X-Received: by 2002:a92:dc0b:0:b0:35c:dbda:25f9 with SMTP id t11-20020a92dc0b000000b0035cdbda25f9mr7174019iln.31.1701189406231; Tue, 28 Nov 2023 08:36:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701189406; cv=none; d=google.com; s=arc-20160816; b=EI7nsNtnMTfK2BYGcuqu9kIACND0KE/sQcuivNdSP9KQyVzuDIJ+yK5BTBL+mpo6CA qV2tzinzdnd4wXmYCj5PrB4MI8CjJMu5LaFvLhz4CUVkzjPaljj/o4C1kSJ5bujxqgOI WEdrlP+1zRBuHwV8u0CI3+E/xf2m99MJW2gX4LBkQ4E0p4zkmWP5EPxkpeLIgXzXSPF7 oBG7NmAamV263wZeiajEoirm0jhUk88Z7BY/qq5oqBqo9Pa1ogpEbaEG4+EQxM0wnd8i iprrJZ1O1+BCs9gn5TtWNids0pW/VF9FNRT5KkBA7YiJc6Z/4kLZXSqZVmNCHz2q6hid CsIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6p4tI/7yugY2pk7TseYAqalSlsg8r810ey8UkBV3jxM=; fh=37BSkvMVRtNOyGmfD1bxY3Z7FgHLxdhnqwgFRK6ycSY=; b=DRfVPYgDpsl30MV6bwk/rH1sB6uKofc+6adpjhGDuTxr4XykpW2Fya8w0ujkesxirK QWm+NoZI5r+sL4fjUG9SVOV/ZwuM4TibNXetiUYLv9l9kSsJvKCKEmSLC5o2GwwWRv+N OIb7mE6JMMx+aOPiZqQnN8pHWUlOhglKg6YWsljUZut7EluWHjOlHnkeURVvgahRpt6y RTuX5oznZj0srtWF7pPGArebrLmtAXioMdtHRpHhGB2tK/Ti52SV4W1jSpQUkYySHWRL qwSIBvhyfI/+jDyyx5pDZ/eWTdgbfqiJy1wmWrZGQFLKzjRmgmgLhH1X18/oCu2l9f8o m09g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=APepEbCY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id s62-20020a635e41000000b005c2421e149esi12677078pgb.564.2023.11.28.08.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 08:36:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=APepEbCY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C3BE7804119F; Tue, 28 Nov 2023 08:36:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbjK1Qft (ORCPT + 99 others); Tue, 28 Nov 2023 11:35:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbjK1Qfs (ORCPT ); Tue, 28 Nov 2023 11:35:48 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B434D60 for ; Tue, 28 Nov 2023 08:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701189353; x=1732725353; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4RER+04drm8bLOvAPnWsEO8Ej4uQa5dTZ8BV5eVR2xk=; b=APepEbCYWN2C0LLtSroyObJxQdHlOkEU/CmSAqkc8dD1kLiYN7Xia/Dk ILHymy6dPxDsrU3n/nHfDL7Xyp5bFrKu6PCW1vP2N1fTsKEA66/J8fzqx vwZftu4leYsJD9C2PzSOVysNNCdIA4/waiKH21rjAOVEIpuyooQVWBHwd UG1oSR8URU9NiMI7Uu3wlblu6CsAZRgc9nNGjR7sO0uE2JeT0t7gAJoJi prhGkYE5ZhQTiQr2bI/MGy8EpuRqM6cMs09LmBFhjk2TxnLJ9mwbWkyAI CqzA/ySR48/2bk61M7pUVuTb7H27l3jbxSktPQeRyNU1FtuJktxvGWhoV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="391828988" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="391828988" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 08:35:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="797628781" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="797628781" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 08:35:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r813q-00000000D7N-4A2F; Tue, 28 Nov 2023 18:35:46 +0200 Date: Tue, 28 Nov 2023 18:35:46 +0200 From: Andy Shevchenko To: Waiman Long Cc: George Stark , peterz@infradead.org, mingo@redhat.com, will@kernel.org, boqun.feng@gmail.com, jic23@kernel.org, linux-kernel@vger.kernel.org, kernel@salutedevices.com Subject: Re: [RFC PATCH 1/1] locking: introduce devm_mutex_init and devm_mutex_destroy Message-ID: References: <20231128000910.73784-1-gnstark@salutedevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 28 Nov 2023 08:36:07 -0800 (PST) On Mon, Nov 27, 2023 at 08:55:18PM -0500, Waiman Long wrote: > On 11/27/23 19:09, George Stark wrote: ... > These APIs are specific to devres. I don't believe it is suitable to put > them into the generic mutex.h header file. All devres_* functions are > defined in include/linux/device.h which is probabably not included in > mutex.h. You may consider putting these APIs into device.h instead. +1. We have include/linux/devm-helpers.h. -- With Best Regards, Andy Shevchenko