Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3983448rdh; Tue, 28 Nov 2023 08:44:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmidB1aquGoaQzIDsWV7UYPJY5N/j8yHzPtPxJ55lWa2wva5dzNgKD/tcRsx8taBCIcKX+ X-Received: by 2002:a17:903:48c:b0:1cf:b3ed:817 with SMTP id jj12-20020a170903048c00b001cfb3ed0817mr11481207plb.20.1701189874679; Tue, 28 Nov 2023 08:44:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701189874; cv=none; d=google.com; s=arc-20160816; b=X33skNLS9m+sO5PYkb+0D3/xnfOeoPzYFjNtetXWMHSiEjPE7o+l7kiEoWxh6fUmYd MTp2Vcigux6DYpAALgEC6sABUj1By6ZXb+7Q5ewcoEm1zsNgAbuhDLSectZ7lkOsBoBy YYYJ+BXVzdWPQSXTT/tEE6pI8d3zJEs/ucIBLMQRiI7WDZscOirdlfcrlzC7kChVqygK IbqaRPi6i48IA9u+nspHeL64WkhE3ociJn7qOBIGpcVnhcphoF161aAbxd3Et0SQ7vwP shLMAs0fsw4RA/WlaaVc0uxnLfi7MCwMzdP2XmMLrKKksRyzCoC+yMCLu3YCKt4n436o eNOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=VP8b8U1frLwU2T2F8FM5z3t8qlAUGYhEyvsjCrBMwcM=; fh=7Oz92vs8x5MOMz6tQG853AZLaWvUkMjbWWDQh4IbfGM=; b=OWIuGJP66kh9IVK94jhyoR6zWGjZ+rOBm60YQUL7IxZT0F20uPazBpDSrwynxeHmSV hD2sr45eH0A5vUIWHiTzOEWwh8U2pwgEl3IKwyH4b/RPMo22jBwNlfozmvYFNwSocziQ ztTZN19/itM7M4PXvnLqvpjhyu4sGlqdn746ctGSDe2EaSvhPjMJtVZPQl0xc2sFBgJs rmaKOO9ByM84ZJl+hLHYpsDIt2jQqODtshIVgzRBhL5G9C/RCdkRSyKag4UOns0QugBN Su2cUOzkBC3C8xmb5n3vP1ZdEcVCoFhn2PE2Er0n8hR7630UE+I1pSpdk1sod+JN23fP rtRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=feZ0lBAv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q22-20020a170902bd9600b001c9c967e77esi11665615pls.207.2023.11.28.08.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 08:44:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=feZ0lBAv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1115F80A530C; Tue, 28 Nov 2023 08:44:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbjK1QoR (ORCPT + 99 others); Tue, 28 Nov 2023 11:44:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbjK1QoQ (ORCPT ); Tue, 28 Nov 2023 11:44:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19BC4D6 for ; Tue, 28 Nov 2023 08:44:23 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3042EC433C8; Tue, 28 Nov 2023 16:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701189862; bh=VXBxDQYXemPJD2OWSBAxs4OdN3/5YPb2d7fGJc3c0so=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=feZ0lBAvj+a8TYsX0HsEYspGxzNhQjd6bEAOt8m5Y2IcAG55AsIPeHaUle7U62GiO h6bD/CDMiYE5nH++594r6bvD4651o+5eOZUkkxaf1mTVfcOeMKagIeWuNp7ry4a+aP kR/BMdqQUQlxXYpbF+mYE3UxVeSFzdfYIHGkHvkxdFVc0iX1/uVM2HGWVJIZIBBcYF kVAk7n+2kd+6S+YoOSLe69xs2K092B6hR7i/LjHE+QbDWDt7mdsFuBIVtvb3hFUiDi Yhrmq6M3ibZqPQRlbZhnBqWyBSlxQOdD7uoDG63X+LMzX3gfrCNqCRvnIzwXgWlwdf ai8Pvb1JYmpDQ== Date: Tue, 28 Nov 2023 08:44:21 -0800 From: Jakub Kicinski To: Jason Gunthorpe Cc: David Ahern , Saeed Mahameed , Greg Kroah-Hartman , Arnd Bergmann , Leon Romanovsky , Jiri Pirko , Leonid Bloch , Itay Avraham , linux-kernel@vger.kernel.org, Saeed Mahameed Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Message-ID: <20231128084421.6321b9b2@kernel.org> In-Reply-To: <20231128162413.GP436702@nvidia.com> References: <20231121070619.9836-3-saeed@kernel.org> <2023112702-postal-rumbling-003f@gregkh> <20231127144017.GK436702@nvidia.com> <2023112752-pastel-unholy-c63d@gregkh> <20231127161732.GL436702@nvidia.com> <2023112707-feline-unselect-692f@gregkh> <20231127160719.4a8b2ad1@kernel.org> <20231128044628.GA8901@u2004-local> <20231128065321.53d4d5bb@kernel.org> <20231128162413.GP436702@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 08:44:32 -0800 (PST) On Tue, 28 Nov 2023 12:24:13 -0400 Jason Gunthorpe wrote: > You said you already rejected it at the very start of this discussion > and linked to the video recording of the rejection discussion: > > https://lore.kernel.org/all/20231019165055.GT3952@nvidia.com/ > > This session was specifically on the 600 FW configuration parameters > that mlx5 has. This is something that is done today on non-secure boot > systems with direct PCI access on sysfs and would be absorbed into > this driver on secure-boot systems. Ie nothing really changes from the > broader ecosystem perspective. The question at LPC was about making devlink params completely transparent to the kernel. Basically added directly from FW. That what I was not happy about. You can add as many params at the driver level as you want. In fact I asked Saeed repeatedly to start posting all those params instead of complaining. > I second Dave's question - if you do not like mlx5ctl, then what is > your vision to solve all these user problems? Let the users complain about the user problems. Also something I repeatedly told Saeed. His response was something along the lines of users are secret, they can't post on the list, blah, blah. You know one user who is participating in this thread? *ME* While the lot of you work for vendors.