Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231122022154.12772-1-CruzZhao@linux.alibaba.com>
 <CAM9d7chVZRKUSmXmZS4OyokKfLKp4h8K8RLWehYRpAs5Z4jsbg@mail.gmail.com> <5ab76c0c-6333-4452-ae51-9193926c802c@linux.alibaba.com>
In-Reply-To: <5ab76c0c-6333-4452-ae51-9193926c802c@linux.alibaba.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 28 Nov 2023 09:12:57 -0800
Message-ID: <CAP-5=fW31eiy8ke0hc_YwCffFRW4PNOUnsN89N_goQq5hgHmJw@mail.gmail.com>
Subject: Re: [PATCH] perf: ignore exited thread when synthesize thread map
To:     cruzzhao <cruzzhao@linux.alibaba.com>
Cc:     Namhyung Kim <namhyung@kernel.org>, mingo@redhat.com,
        peterz@infradead.org, acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        adrian.hunter@intel.com, kprateek.nayak@amd.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 27, 2023 at 10:23=E2=80=AFPM cruzzhao <cruzzhao@linux.alibaba.c=
om> wrote:
>
>
>
> =E5=9C=A8 2023/11/23 =E4=B8=8A=E5=8D=885:05, Namhyung Kim =E5=86=99=E9=81=
=93:
> > Hello,
> >
> > On Tue, Nov 21, 2023 at 6:22=E2=80=AFPM Cruz Zhao <CruzZhao@linux.aliba=
ba.com> wrote:
> >>
> >> When synthesize thread map, some threads in thread map may have
> >> already exited, so that __event__synthesize_thread() returns -1
> >> and the synthesis breaks. However, It will not have any effect
> >> if we just ignore the exited thread. So just ignore it and continue.
> >
> > Looks ok.  But I guess you want to do the same for the leader
> > thread below as well.
> >
> > Thanks,
> > Namhyung
> >
>
> With my testcase, no error is returned even if we don't do the same for
> the leader thread blow. Well, I'll check whether the logic is still
> correct if we do so.
>
> Many thanks for reviewing.

Thanks for looking at this. Could you share the test? It looks like
the thread be removed from the thread map to avoid potential future
broken accesses like below:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tr=
ee/tools/perf/util/synthetic-events.c?h=3Dperf-tools-next#n887

Some of the race will hopefully get narrowed by switching to a less
memory intense readdir:
https://lore.kernel.org/lkml/20231127220902.1315692-7-irogers@google.com/

Threads racing is an issue in this example:
```
$ sudo perf top --stdio -u `whoami`
Error:
The sys_perf_event_open() syscall returned with 3 (No such process)
for event (cycles:P).
/bin/dmesg | grep -i perf may provide additional information.
```

Generally the races are covered by the dummy event that gathers
sideband data like thread creation and exits, which is created prior
to synthesis. It would be nice to have a better threading abstraction
to avoid these races.

Thanks,
Ian

> Best,
> Cruz Zhao