Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   "Bahadur, Sachin" <sachin.bahadur@intel.com>
To:     Jiri Pirko <jiri@resnulli.us>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond
Thread-Topic: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond
Thread-Index: AQHaIPe/QZ4HasPNt0KtTZtgr5dQa7CN6caAgABvukCAAQAbgIAAqEWw
Date:   Tue, 28 Nov 2023 17:45:47 +0000
Message-ID: <BY5PR11MB42574A519BF05AF80BC03E1A96BCA@BY5PR11MB4257.namprd11.prod.outlook.com>
References: <20231127060512.1283336-1-sachin.bahadur@intel.com>
 <ZWRkN12fhENyN4PY@nanopsycho>
 <BY5PR11MB42574D2A64F2C4E42400213A96BDA@BY5PR11MB4257.namprd11.prod.outlook.com>
 <ZWWYx18w2BnLyAZL@nanopsycho>
In-Reply-To: <ZWWYx18w2BnLyAZL@nanopsycho>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lMuui15hSAw4zgwaFmXg7Q/3q0nSt6DfUQfANFxqYRM5ZihYFHq+05DsXX6W?=
 =?us-ascii?Q?8JxQB4Wth3F813BQDCj3X+pLujMvBU6WLGZAu59hUyDOrIyaKnB3DDWF+VU6?=
 =?us-ascii?Q?wfEx/STYsNJU6Z1t1LSbVbHfrPXQyufFlpqsPAEnDLaT/AKMFvrfwV9/D6x3?=
 =?us-ascii?Q?WlBuHcywvFK8pW8tMN0f3WQHDyc/9xAHu9QB/WFk1LsODgEP4uioNSECVg1K?=
 =?us-ascii?Q?9Sbs2JSBumL1wz8iG6VRDGKy933GntULYG52o1TCRqGMyZXMvAbmSIMliWoF?=
 =?us-ascii?Q?PQdKfX6Tn4fgX7OM9fhGXvL2exfZvaOhyE/xNOyu94gMnXBRjvfhhh/+Cm1J?=
 =?us-ascii?Q?s87jT7KOEj4tZz4Ys5aUYLLbzxfNwdbsKTX5vdnC4I4lDgVQCp75honrcvPo?=
 =?us-ascii?Q?jOFBVGMciuudXtkMI++WUOo7cRN/XGb/clXKMqHHsDWEvHcg9DX7Td93vC3C?=
 =?us-ascii?Q?RdjxF7teEN7tO97nVRXynh57nYsaYS543NIWzHqJQfZ17AmAZd5SDC3pnbpZ?=
 =?us-ascii?Q?1/udAgvHlx+PxXrB6GF+CnjXJuWaCYLe30G1W3zh5fXGiDfX4BYjhCEJ73d3?=
 =?us-ascii?Q?nVhT/BiFxVd04QaE6mSObnbiA0r1u+axqDueuKCC4V1fEhR2JnH+UMzFQ019?=
 =?us-ascii?Q?YXfA2zV4cutk889bhQfTnJ1gy6G5v5ajokhN2hLQlowU8aVKvxcIwjWLNCWj?=
 =?us-ascii?Q?TkJ0dncM6EJr6ULQbTlbIMYkeqmND2PTunLWUXCCBIUfJfRFyXAZ/JQ3rM8Y?=
 =?us-ascii?Q?XKktABAFLI8Mo2UUUfNub2lsU4DfMlNsskYkFKlWOQRu27sVF+rOboeYMzfu?=
 =?us-ascii?Q?2ZlXvgubFwR6QUOkrstzKO4NH5l+un2fQU/JkYaKjZ5tldwPIFj5KUBZ0IEO?=
 =?us-ascii?Q?xUwsvVnBZpMwxp3vITUzKxWXqGul9cdZs+rhkMBbSI3EgIKzz/t6xF/HqJir?=
 =?us-ascii?Q?jUlYtTw0X+/VbDOCL9gDKZlrVNquYfy9ci1wunbiIO13+ztZFKq5zqAPF0mq?=
 =?us-ascii?Q?j0wBFbxzJCJs0fpPGNabC9oYI72Lthv7NNTFPftZ9cvMXeHHgay9EleQt8RT?=
 =?us-ascii?Q?egLx89TjJ+ezFGy8xy5W4bohUxi0n/bSKx+OsWuFN83KRTL49NcfG4ANhTxZ?=
 =?us-ascii?Q?dqPfSjH8kHx0qhGU5/RH4uQ44ooPwcU1R1+qOIxvCbIRJ8HkgzUmyONEfL6z?=
 =?us-ascii?Q?fEvvlb1TqIQtr+XWXeBrv5S2K2O6CeCq37C869t/4zIepnO39vpDpANGZ5w7?=
 =?us-ascii?Q?RLMhTTQ2XQ4XYm8NTS739Cw1c9aRl27FWsSi995DpWPrCGb0FhN3cvqE9iiW?=
 =?us-ascii?Q?IBsrtDvWgv8v9J/d3F0hZlxn6vymIcyMu5hv1GkPvur57Clof1siwISncS/t?=
 =?us-ascii?Q?2K8X1d8zahhr5N9QOi9pGth5C8Fa2t3/ThNw611lmVPkpwivpUky7Bq21XFn?=
 =?us-ascii?Q?bvM/lducU36WjQ2HG4TR9ZFYEKjB9as19SBJrWd7nUmo4fKtIR55ZoURFNOd?=
 =?us-ascii?Q?aoka99YaaOYr4gv8tO/NQoRRCs054ijAJYdu3vjv4e7huDd2KkQpepqtljrG?=
 =?us-ascii?Q?IJc+9ju7nfalqk7hJ3Xmg7u/Hl3hvjT41J6dJRPX?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4257.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06548052-112d-4379-3100-08dbf039dae9
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 17:45:47.9027
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CCourXkA3rquhqReFs8mQFpz/FaVuhAYefF7Y/DHB7YwN8LaZW5LFjYit45R4qNjbqX6nD8gHVO7VdSK5koXXfrpbZTczawHC14VavjRqIc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5339
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 09:46:11 -0800 (PST)


> From: Jiri Pirko <jiri@resnulli.us>
> Sent: Monday, November 27, 2023 11:38 PM
> To: Bahadur, Sachin <sachin.bahadur@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond
>=20
> Mon, Nov 27, 2023 at 05:23:55PM CET, sachin.bahadur@intel.com wrote:
> >
> >> Nack. Remove the netdev during re-init, that would solve your issue.
> >> Looks like some checks are needed to be added in devlink code to make
> >> sure drivers behave properly. I'm on in.
> >
> >Sure. This fix should apply to all drivers. Adding it in devlink makes
> >more sense. I am not a devlink expert, so I hope you or someone else
> >can help with it.
>=20
> No, you misunderstood. I'll just add a check-warn in devlink for case whe=
n port
> exists during reload. You need to fix it in your driver.


What should be fixed in my driver. Can you clarify ?=20
And are suggesting I add the check-warn in devlink code ?


> >
> >>
> >>
> >> >+			return -EBUSY;
> >> >+		}
> >> > 		ice_unload(pf);
> >> > 		return 0;
> >> > 	case DEVLINK_RELOAD_ACTION_FW_ACTIVATE:
> >> >--
> >> >2.25.1
> >> >
> >> >