Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4027644rdh; Tue, 28 Nov 2023 09:49:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IEtFV73c+USWJornmFQ1BKQ//ukw27nqX1Ji5H3rk+tEMWTYwJa2YzZGcPjk9s+yhZDYiQK X-Received: by 2002:a17:903:228a:b0:1cf:ad1a:60c3 with SMTP id b10-20020a170903228a00b001cfad1a60c3mr16817827plh.53.1701193788175; Tue, 28 Nov 2023 09:49:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701193788; cv=none; d=google.com; s=arc-20160816; b=v6/4srzkpt9h28eCDH49vAmbAwU9NoBfDSS3T21Pt7ZDT4Ng61w0ACQjKAXEVqSxud Sw/c1FyfDYZlT4i7OoryWzgXNN5NGVOzTDdCDX17mXRSpEGTq+S6FM6MPBKqTB05HStU VOrzY4BEvDHG7ptjSzm0YXCOFtZ37ZSqshcUpk69BGD63ODWtjl9J7soMqfwlpnxl8Xz SNc92DGxFFA8NYLi1sUAZYe9XWuoI1JATjIlyalyel9C1Aif2Q2MXi5yX7fkLRok9C7/ 813kS0mLiluW8MX4oPma1k+gthAVUT1w98fVv6xcBsmmftFxjtr/A9F7HpTKM5hLA27U iAEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hYAdPXYjdtJoSjhwdnkJc5M1Ql6U3jFAivs3ToBpO7o=; fh=4+KII/aEiorRhrRXAj1IqraVIc1e4vSM4D5/g8pZ+Kk=; b=ZMgYw+7E6nPQj+y/X4y+seOAYga3F1cgd0ABhqUyHxDDCA+xlueuVrJMOqgjlwj33+ 4CuMg4VXZqCpD+Xe9zUh6O1wOyk9WTPXp8Rdigq07peTl0hiBkAZa1xFexQuCx9f2Gz4 309ti7Aqw6es+Sfocg9aN/HU1k1e48t9LKwENdEa7w2LjPXIMMsbE4/+JWXmVk2Xzwa0 mEDdsqISOxrmOTivWQNNL13zhFUHPOSNWPAnx1uHNCz4tQlevdTxdkk01AfxyA7FwdLD e1kQZLt6//evOXZVvX7hk+sywgzUaqGcTbMy5hoEBxfA1mAweXMgTnLwoy9OXJck1g9/ 8ehQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=geWxiC9x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id m22-20020a170902bb9600b001cf9d8aeeafsi10841987pls.247.2023.11.28.09.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 09:49:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=geWxiC9x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 18E5D804C238; Tue, 28 Nov 2023 09:49:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346219AbjK1Rt1 (ORCPT + 99 others); Tue, 28 Nov 2023 12:49:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345727AbjK1Rt0 (ORCPT ); Tue, 28 Nov 2023 12:49:26 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C20B4; Tue, 28 Nov 2023 09:49:32 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9e1021dbd28so783093666b.3; Tue, 28 Nov 2023 09:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701193770; x=1701798570; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hYAdPXYjdtJoSjhwdnkJc5M1Ql6U3jFAivs3ToBpO7o=; b=geWxiC9xIbMsM6p30SwbUXcsxQNYa3QbEBydxeuRnPy1O3LJzo/+5yDQm3g7yBCKlM ySCkbFNvJzsd8ik+Oe7EgIP9NBzpIkzl/4bm3ccix8oe3Rmbl58h7wad54UWbQERwMRx +lZdH4+1cQ2YSkR1WYskYUVkUqvjTt1vTkcUXubEsoZh6QOuC1wrWl6VxArLz2NUaPA/ +2uWZkexO/YVWXgjas/NhXf3l5S1ls204G6MQTFY5IAE1JAr05i1fC388veD/DCXlVcE fUTzDCzrWLH4d3N0u4yrlCE9gEH8zCoQkOO0JfDBclIdDf1njw2ChnuYO7qM2MUg92q9 HynQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701193770; x=1701798570; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hYAdPXYjdtJoSjhwdnkJc5M1Ql6U3jFAivs3ToBpO7o=; b=ph/dNyozTXql2XUwHWwtZPG5Wh1lV1u8SxCbszzh/MRm6f6sjzeTTVyAtkWdO6ajKn s9b29/Hoq46LjcbF2vPi1FahUHEnhs2UnAGW3N+sRL9XXk0145msAGfNMPawyRJT8FBF XP80uRGgsWrGFXFVNLA96O1V59eis9YkeX1nmWpTpEFc3JbeM0DElti/Qb50eE1Aa7J3 UMMlel1ao/RNHSYPTBqYZ9TjFoCttZ7vZap1CuzaOeHQv65AynX1Eoelh/XWElFGMc43 nRGxnFZCV//nsum5TDGOG/FWzBYXZtHy/sdL+CzSJfnPjAdPvl99GwIDGG7mvg1ZtE+f XFzQ== X-Gm-Message-State: AOJu0YzRQ2P7WN9a5xMifPJXE2zHxMrw93uk4nRk0FaLxIbfzcFwKq4v 2HqndQu9m/HKPZF3Iki8dwoA6wlZqaA= X-Received: by 2002:a17:906:5352:b0:a0d:d73d:1542 with SMTP id j18-20020a170906535200b00a0dd73d1542mr5581642ejo.20.1701193770276; Tue, 28 Nov 2023 09:49:30 -0800 (PST) Received: from localhost (p200300e41f0fa600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f0f:a600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id lv23-20020a170906bc9700b009f28db2b702sm6981520ejb.209.2023.11.28.09.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 09:49:29 -0800 (PST) From: Thierry Reding To: linux-kernel@vger.kernel.org, Florian Fainelli Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] pwm: bcm2835: Fix NPD in suspend/resume Date: Tue, 28 Nov 2023 18:49:22 +0100 Message-ID: <170119374441.445690.2721498852495955001.b4-ty@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231113164632.2439400-1-florian.fainelli@broadcom.com> References: <20231113164632.2439400-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 28 Nov 2023 09:49:44 -0800 (PST) On Mon, 13 Nov 2023 08:46:32 -0800, Florian Fainelli wrote: > When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was > sent out on October 11th,, there was still a call to > platform_set_drvdata() which would ensure that the driver private data > structure could be used in bcm2835_pwm_{suspend,resume}. > > A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835: > Simplify using devm functions") removed that call which would now cause > a NPD in bcm2835_pwm_{suspend,resume} as a consequence. > > [...] Applied, thanks! [1/1] pwm: bcm2835: Fix NPD in suspend/resume commit: fba7e9f839d7fcb0888094697da45c5668226455 Best regards, -- Thierry Reding