Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4030457rdh; Tue, 28 Nov 2023 09:55:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnPiL9EfO9o3pSCFO2VBM7piSDy/gd5rjssCxh9sQzGCAyPHvQrpVbqX3HfQ40/s9tLWBZ X-Received: by 2002:a05:6a21:3293:b0:18b:3c54:e6d8 with SMTP id yt19-20020a056a21329300b0018b3c54e6d8mr15918235pzb.39.1701194099913; Tue, 28 Nov 2023 09:54:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701194099; cv=none; d=google.com; s=arc-20160816; b=ddogUoChUT3L2NoShqWpsaeWK7XejdggjxXMCYgcNDx+hqtk5cUq1bJKpObj28ZOuV OJnyaygD66N8VRuGfHdhI/h5cW7fJqzkfno+gxJ/5TTfIj7+PZqBFanGk5Quhf4mcn8A wkerOiO9tq2BNYEFs360y2ienLkE+J6kTe0fFxwRVK0y714W7nYx1qAYj59LVTNaD3O+ a/PGJvEw5vleRdz9CcimqBSiyje06fysCkvCOugp/zLQZk6McoQUOyjOG2J75HtmX/m2 GVf88BdW87M3Upcnw8tFxxK7I5vdpKzFPDfaGGKcWkW1wvM+nL1gKCZJERVylAGSqtBF c9yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=UFccXEXz7IM6tMF3bP+Pq5FuCNUT9piA8FwAmlVMJeo=; fh=/TViaxNXj9Ubl1KVZseJCqJutBKG0dvzf3DPkf/1G64=; b=lhbVqb5cUdV2FEzsV7LDCtEjYEwxVpUmpBHkbXkjZTbv0Vt5uSOD1YD6SL3IPOP0Gl KXjM517eLapdrWG1D8wmljakLX27Iyy9s6SfH48IaCDeO0RlKBkh3R1jSNqyDd7H08tb 2Q/VITjGGOhdmmsxNvagNOaU2/LcBBdCAx0b8kpaIVqAdtEL2F323P5Q8oP6iXNv6Qb2 pZZNyhQTT773uKoEwZJ6P3/CxIGbSPaR74Dh0TmPF8ESfJjW6gd6wpyKF10eoUfdnXGn NURmd1MhwdUmsz2hhWgAEU/Ws4LbqrGHfEyu3UxaxlZaA7Ka0OhGekyAuTWvik0TkBTh vNdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jHU0LgaF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id s20-20020a656914000000b005b935872b48si12459080pgq.537.2023.11.28.09.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 09:54:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jHU0LgaF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9D955804596A; Tue, 28 Nov 2023 09:54:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234790AbjK1Ryp (ORCPT + 99 others); Tue, 28 Nov 2023 12:54:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234782AbjK1Ryn (ORCPT ); Tue, 28 Nov 2023 12:54:43 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65700C1; Tue, 28 Nov 2023 09:54:49 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6cb4d366248so4904337b3a.0; Tue, 28 Nov 2023 09:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701194089; x=1701798889; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=UFccXEXz7IM6tMF3bP+Pq5FuCNUT9piA8FwAmlVMJeo=; b=jHU0LgaFecYLrQpdNh2/xvNWQI6zZAzH+/C0L/UGDJGTVFkEtSZ4zWaVLlXIbI6P7F zFyXKONPFv6Yj0gEOfOGv0KCDEetR7MSzdDuqlKg8Ue7bSE1zMU0nekVrJHSmjhmfAcw BfUJHmG27lSGex+MbAisCw/m/Fx0N8HvZeFALAu3XpFqBjii4532IsD6drHZX/dMkA+I lxBHVJHaDeUwRkBqMtd1gvNEnIcnff/jjQrvstS3uYZ69UjHD4LiDBXaO2wVJV2sg4ia o4pOuW1IKkc9tTRGo3eVFgc2tFGrwM/8Jg8A5ZhuyxuWLY0XRHe81jowq1S1MQtRW5pv WXDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701194089; x=1701798889; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UFccXEXz7IM6tMF3bP+Pq5FuCNUT9piA8FwAmlVMJeo=; b=Ae70X63FhSoYwKgT/LgtjlTSPsUkmO/+AhWFPIGb7z32W/VB383DSZtv23l7b+FCq5 /WA9e7x+br1MvwteTAFeExV8AafyykcjYcblZ2fGzjdur9tMSo9Xu9VSysXUYxiZD1Me fR8wjSEKkYDqpXbsx0EF1O4fEKEyWyKP/9f1avy+m3pR2eRwdLaR/p0O+DSAnjfvPnQb BTYrf0ADOm2yOTwkciKN4b6obiwDWqrnePseBGeoImNdAxO2DrN3OAVKdJmrOiKPDWLX 9VxbSa482Xp8UXpgIE289FZVtpQJfIt6ZL8SE1sIqqP77rj1RAG9FILk8JGu7lwf0AAF cCew== X-Gm-Message-State: AOJu0YyNH1jjAeVqNbq147551+WXWZAAdYQJGzNZsbqwUDcfB1sw2MCM 3qffv1g1JCqQKSt6wovRWg8= X-Received: by 2002:a05:6a00:1d25:b0:6b3:aded:7e9a with SMTP id a37-20020a056a001d2500b006b3aded7e9amr15712535pfx.27.1701194088596; Tue, 28 Nov 2023 09:54:48 -0800 (PST) Received: from bangji.corp.google.com ([2620:15c:2c0:5:146f:6347:3bb4:8cf4]) by smtp.gmail.com with ESMTPSA id y2-20020aa78042000000b006cbbc07a1c0sm9224721pfm.156.2023.11.28.09.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 09:54:48 -0800 (PST) Sender: Namhyung Kim From: Namhyung Kim To: Arnaldo Carvalho de Melo , Jiri Olsa Cc: Ian Rogers , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCHSET 0/8] perf annotate: Make annotation_options global (v1) Date: Tue, 28 Nov 2023 09:54:33 -0800 Message-ID: <20231128175441.721579-1-namhyung@kernel.org> X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 09:54:58 -0800 (PST) Hello, It used to have annotation_options for each command separately (for example, perf report, annotate, and top), but we can make it global as they never used together (with different settings). This would save some memory for each symbol when annotation is enabled. This code is available at 'perf/annotate-option-v1' branch in git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Thanks, Namhyung Namhyung Kim (8): perf annotate: Introduce global annotation_options perf report: Convert to the global annotation_options perf top: Convert to the global annotation_options perf annotate: Use global annotation_options perf ui/browser/annotate: Use global annotation_options perf annotate: Ensure init/exit for global options perf annotate: Remove remaining usages of local annotation options perf annotate: Get rid of local annotation options tools/perf/builtin-annotate.c | 43 +++++---- tools/perf/builtin-report.c | 37 ++++---- tools/perf/builtin-top.c | 45 +++++----- tools/perf/ui/browsers/annotate.c | 85 ++++++++---------- tools/perf/ui/browsers/hists.c | 34 +++---- tools/perf/ui/browsers/hists.h | 2 - tools/perf/util/annotate.c | 142 +++++++++++++++--------------- tools/perf/util/annotate.h | 38 ++++---- tools/perf/util/block-info.c | 6 +- tools/perf/util/block-info.h | 3 +- tools/perf/util/hist.h | 25 ++---- tools/perf/util/top.h | 1 - 12 files changed, 206 insertions(+), 255 deletions(-) base-commit: 757489991f7c08603395b85037a981c31719c92c -- 2.43.0.rc1.413.gea7ed67945-goog