Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231102175735.2272696-1-irogers@google.com> <20231102175735.2272696-5-irogers@google.com>
 <ZWURZvDA2L4Mr3HR@kernel.org> <ZWYf+Sy6JKd7CYlN@kernel.org> <ZWYlgPwGmAEUKIsE@kernel.org>
In-Reply-To: <ZWYlgPwGmAEUKIsE@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 28 Nov 2023 09:55:22 -0800
Message-ID: <CAP-5=fVgVY8hhhhgW-aJic6Vez2CJmA8VLx+Az3kKJFB7fz1Pg@mail.gmail.com>
Subject: Re: [PATCH v4 04/53] perf mmap: Lazily initialize zstd streams
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Nick Terrell <terrelln@fb.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Vincent Whitchurch <vincent.whitchurch@axis.com>,
        "Steinar H. Gunderson" <sesse@google.com>,
        Liam Howlett <liam.howlett@oracle.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Colin Ian King <colin.i.king@gmail.com>,
        Dmitrii Dolgov <9erthalion6@gmail.com>,
        Yang Jihong <yangjihong1@huawei.com>,
        Ming Wang <wangming01@loongson.cn>,
        James Clark <james.clark@arm.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        Leo Yan <leo.yan@linaro.org>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        German Gomez <german.gomez@arm.com>,
        Changbin Du <changbin.du@huawei.com>,
        Paolo Bonzini <pbonzini@redhat.com>, Li Dong <lidong@vivo.com>,
        Sandipan Das <sandipan.das@amd.com>,
        liuwenyu <liuwenyu7@huawei.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 28, 2023 at 9:38=E2=80=AFAM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Tue, Nov 28, 2023 at 02:14:33PM -0300, Arnaldo Carvalho de Melo escrev=
eu:
> > Em Mon, Nov 27, 2023 at 07:00:06PM -0300, Arnaldo Carvalho de Melo escr=
eveu:
> > > Em Thu, Nov 02, 2023 at 10:56:46AM -0700, Ian Rogers escreveu:
> > > > Zstd streams create dictionaries that can require significant RAM,
> > > > especially when there is one per-CPU. Tools like perf record won't =
use
> > > > the streams without the -z option, and so the creation of the strea=
ms
> > > > is pure overhead. Switch to creating the streams on first use.
>
> > > > Signed-off-by: Ian Rogers <irogers@google.com>
>
> > > Thanks, applied to perf-tools-next.
>
> > Trying to fix this now:
> >
> >   6    20.59 alpine:3.18                   : FAIL gcc version 12.2.1 20=
220924 (Alpine 12.2.1_git20220924-r10)
> >     In file included from util/zstd.c:5:
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown=
 type name 'ssize_t'; did you mean 'size_t'?
>
> So the problem was really the one above, that got fixed with the patch
> below, that is what 'man size_t' documents on my fedora:38 system.


Thanks, perhaps this is something clang-tidy, clang-format or similar
could help with in the future. There was event IWYU discussion at LPC:
https://lpc.events/event/17/contributions/1620/attachments/1228/2520/Linux%=
20Kernel%20Header%20Optimization.pdf

Thanks,
Ian

> - Arnaldo
>
> diff --git a/tools/perf/util/compress.h b/tools/perf/util/compress.h
> index 9eb6eb5bf038ce54..b29109cd36095c4f 100644
> --- a/tools/perf/util/compress.h
> +++ b/tools/perf/util/compress.h
> @@ -3,7 +3,8 @@
>  #define PERF_COMPRESS_H
>
>  #include <stdbool.h>
> -#include <stdlib.h>
> +#include <stddef.h>
> +#include <sys/types.h>
>  #ifdef HAVE_ZSTD_SUPPORT
>  #include <zstd.h>
>  #endif
>
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           | ^~~~~~~
> >           | size_t
> >     util/zstd.c:31:9: error: conflicting types for 'zstd_compress_strea=
m_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t,  void *, s=
ize_t,  size_t,  size_t (*)(void *, size_t))' {aka 'long int(struct zstd_da=
ta *, void *, long unsigned int,  void *, long unsigned int,  long unsigned=
 int,  long unsigned int (*)(void *, long unsigned int))'}
> >        31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous=
 declaration of 'zstd_compress_stream_to_records' with type 'int(struct zst=
d_data *, void *, size_t,  void *, size_t,  size_t,  size_t (*)(void *, siz=
e_t))' {aka 'int(struct zstd_data *, void *, long unsigned int,  void *, lo=
ng unsigned int,  long unsigned int,  long unsigned int (*)(void *, long un=
signed int))'}
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     make[3]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: u=
til] Error 2
> >       CC      /tmp/build/perf/util/zstd.o
> >       CC      /tmp/build/perf/util/cap.o
> >       CXX     /tmp/build/perf/util/demangle-cxx.o
> >       CC      /tmp/build/perf/util/demangle-ocaml.o
> >     In file included from util/zstd.c:5:
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown=
 type name 'ssize_t'; did you mean 'size_t'?
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           | ^~~~~~~
> >           | size_t
> >       CC      /tmp/build/perf/util/demangle-java.o
> >     util/zstd.c:31:9: error: conflicting types for 'zstd_compress_strea=
m_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t,  void *, s=
ize_t,  size_t,  size_t (*)(void *, size_t))' {aka 'long int(struct zstd_da=
ta *, void *, long unsigned int,  void *, long unsigned int,  long unsigned=
 int,  long unsigned int (*)(void *, long unsigned int))'}
> >        31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous=
 declaration of 'zstd_compress_stream_to_records' with type 'int(struct zst=
d_data *, void *, size_t,  void *, size_t,  size_t,  size_t (*)(void *, siz=
e_t))' {aka 'int(struct zstd_data *, void *, long unsigned int,  void *, lo=
ng unsigned int,  long unsigned int,  long unsigned int (*)(void *, long un=
signed int))'}
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >    7    21.14 alpine:edge                   : FAIL gcc version 13.1.1 2=
0230722 (Alpine 13.1.1_git20230722)
> >     In file included from util/zstd.c:5:
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown=
 type name 'ssize_t'; did you mean 'size_t'?
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           | ^~~~~~~
> >           | size_t
> >     util/zstd.c:31:9: error: conflicting types for 'zstd_compress_strea=
m_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t,  void *, s=
ize_t,  size_t,  size_t (*)(void *, size_t))' {aka 'long int(struct zstd_da=
ta *, void *, long unsigned int,  void *, long unsigned int,  long unsigned=
 int,  long unsigned int (*)(void *, long unsigned int))'}
> >        31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous=
 declaration of 'zstd_compress_stream_to_records' with type 'int(struct zst=
d_data *, void *, size_t,  void *, size_t,  size_t,  size_t (*)(void *, siz=
e_t))' {aka 'int(struct zstd_data *, void *, long unsigned int,  void *, lo=
ng unsigned int,  long unsigned int,  long unsigned int (*)(void *, long un=
signed int))'}
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     make[3]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: u=
til] Error 2
> >       CC      /tmp/build/perf/util/cap.o
> >       CXX     /tmp/build/perf/util/demangle-cxx.o
> >       CC      /tmp/build/perf/util/demangle-ocaml.o
> >       CC      /tmp/build/perf/util/demangle-java.o
> >     In file included from util/zstd.c:5:
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown=
 type name 'ssize_t'; did you mean 'size_t'?
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           | ^~~~~~~
> >           | size_t
> >     util/zstd.c:31:9: error: conflicting types for 'zstd_compress_strea=
m_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t,  void *, s=
ize_t,  size_t,  size_t (*)(void *, size_t))' {aka 'long int(struct zstd_da=
ta *, void *, long unsigned int,  void *, long unsigned int,  long unsigned=
 int,  long unsigned int (*)(void *, long unsigned int))'}
> >        31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous=
 declaration of 'zstd_compress_stream_to_records' with type 'int(struct zst=
d_data *, void *, size_t,  void *, size_t,  size_t,  size_t (*)(void *, siz=
e_t))' {aka 'int(struct zstd_data *, void *, long unsigned int,  void *, lo=
ng unsigned int,  long unsigned int,  long unsigned int (*)(void *, long un=
signed int))'}
> >        34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *d=
ata, void *dst, size_t dst_size,
> >           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
>
> --