Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <b1fa28b5-a93a-4580-8f50-b27f975216d3@oracle.com>
Date:   Tue, 28 Nov 2023 23:25:14 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] EDAC/sysfs: Fix calling kobject_put() without kobj
 initialization
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
        James Morse <james.morse@arm.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
        kernel-janitors@vger.kernel.org, error27@gmail.com
References: <20231128130952.3372794-1-harshit.m.mogalapalli@oracle.com>
 <2023112824-cupbearer-salvage-b064@gregkh>
Content-Language: en-US
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <2023112824-cupbearer-salvage-b064@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG54MlJtUjNXYlhMM1drQXA3eEU4bmJhS1pDT29HRnhpaTlDSEhFQ2gwZUNG?=
 =?utf-8?B?V1VCWnhyeTRDOGlEb1VCempnenJidHE4bzBzWWN2Zi9zNlh3WlBnY29tSkhO?=
 =?utf-8?B?RkhnaGJuNnJMcXVaTWFYWStDc2M1QW53MEFPdmV4clI4VE9NM3hwZlhTTjgv?=
 =?utf-8?B?bEdqNkVPRjdoaDFnMlloU3E2VmdXaFk5TDFqbVY5c0dtNElFN2UyOHAxSng4?=
 =?utf-8?B?SHBXT0FEOTZuaERPdnNpZUc2RHZTYU5rSG1tbGtGZWkzbGgxUTVjNDg5Yk1I?=
 =?utf-8?B?MjdtMUttSDY0NDJTSk1zUXN6ZEl5RDFKQ3FaQzM0em9TOHlCaktXNFlha2pQ?=
 =?utf-8?B?TWJKUU5SaXV0N0lKc0taMnhqdEpxcW5EL0lPSmVlUnNFTFNRb29HemdtK3p2?=
 =?utf-8?B?ejFaaUk5T3JHUWg4dnk4S1FmV3I5SmpncG5vVHdFTm80TXo0K0owTk8rUGZM?=
 =?utf-8?B?c2U4SW1qSTVCUXpYOU0vME9mMkxzS1kyenJzNGdEd0lNTTVlWUxPUkVURkgv?=
 =?utf-8?B?Q0dwUkpkcnFWWEtuckFMQm50eWlMYlJqNEV0REtBWGJVNHBYa3ZseHhxbEdi?=
 =?utf-8?B?a0o3a2JKaTVkVk5zRk5KVVN1OTRlbU5lVjRuQitVSjlRUEpNbXhPTDhlSDFi?=
 =?utf-8?B?MzFybGxIcm5PSHpjN3lnVm9Fd2Q0REI3cS9LNVJKMk1TaVpBaUxORTdMb0Vw?=
 =?utf-8?B?M0dBYkJodzFjMDBuV0dmcjRSR3EvRjYwUVREN2Rrd2I1RU1mbjJNaDA1cnQy?=
 =?utf-8?B?ZnpNTEZmT3EzOVRGZVdMY3luZTRDeXZhcE9UWlNJY2V5R0dMc09WZVZqU3RX?=
 =?utf-8?B?bmtndXpDNjdJdzM2WWFSVEI3ek5LRjMxdzJGWEpnTEp1dTNaR2U3bXUxQWFm?=
 =?utf-8?B?OURMbmw5Q1pQZE45eXhuY3FDSFpBaFRLdmZkNjhzdnl0WFdSVTRlNSthRnAv?=
 =?utf-8?B?bERoQ2EvczNjRE9OTkovZ1k0V1hIT2JOM0R5NUh1YTdURTZhZUVZYmZ4QTZk?=
 =?utf-8?B?YWpRdDVJVWZSOFYyZjZKNWJpK21rS1RmcVRRQ1VJenVxN01FdEw0c2NlTXN3?=
 =?utf-8?B?MFF3WGxnSEZmWGUwTGxabFZQYlV2em5helFRUFVZZTBlRVd4aVkxWWZwbEpv?=
 =?utf-8?B?eHVIallqMm5KNWZLUElyc2VWcGRJb2t3b2ErTUlsUnBCQVp3dlBmQ0I5OSta?=
 =?utf-8?B?UVZWekN5UjUyT2hKeHZ1a0FoRUFVSGh1WGdTMlN2UlA1S2YycXlLdnhyNEtl?=
 =?utf-8?B?Y3dCTFJnWVc4RXp3WklYNnBUQyt6RXUxUWZjWDBNZ0NweVc4aVJKc3c1L0Rn?=
 =?utf-8?B?U2wyazg3Q0pXU1pyTk55WVhhZFVXVFpXc1FYcHVYdDA4TTdWTG1Sak1ZYkcy?=
 =?utf-8?B?NmFDTGcrVmNLNkhoYy9RODZ0MmtSWEpueTFZRktmeFZSTmFMUi9NbDRBejVa?=
 =?utf-8?B?cTFOeHBkVC94cm15eDVqb0J1MXVTSytYSjhXUkpORFY2eHNYV3U3cmFxVEd6?=
 =?utf-8?B?U0xndnQ2R0p2RCtoeEx0M05QUmZxOCtLTjhOVDI4MElQSVFBMG9VZFZKaDJt?=
 =?utf-8?B?cHZOZjh5Y3lTRXN1dTN6aFo5dXZ6ci9nam9QQVNEdUphYTRFM1hKMS9QdDRK?=
 =?utf-8?B?ZXBVYjVLRlhYTVVSWU9SdEhxa0I5dHhWalBHb0VXdE1QcU1DMWZSTDFsT2ty?=
 =?utf-8?B?ZnBhY2M4YzZhR1RhYTcyZTF1Q2ZiTTBtYmlTRVlSM2liNWI1WHlYNGpia2RZ?=
 =?utf-8?B?RTI4Qy96YzlQN24ybU90SzFzSUpqRFNkeGhoNFJSUmV1Wkcwc25GU0JPVDZ2?=
 =?utf-8?B?eHhjQmZRN01zamVPcTRBQ3p5cGVTQmZCazJKcFl6UWNWbzhXWldLYjJ6NDQ3?=
 =?utf-8?B?dzJ2cWRvbjNrQ3g0RDVRd0V1ckZ0WDF4VmJzTXJLV29iSGdGQU5UTk5TcVpl?=
 =?utf-8?B?T3EzWTdqak1RTXBRZmNHUWhJb1hRaFpIS2FiMXNpUXlsc28rYkZkKzRYeWVG?=
 =?utf-8?B?YThiN3hEeDZPaDhtaktkMXdZNk1LQXVZVmNaa3ltZXMwMXNmZW9pWEQ0N2R1?=
 =?utf-8?B?cnN3Sk5EOHJ0d0ZIeXVSUklPOVRhMXdESGlhUnZKMVNnK1Zvdmh3K29iZndH?=
 =?utf-8?B?ZklEU0ZVYlVMeFdHSnFGSnhGT3poT241V3VjN3U0SGxaa0lWTFNrRlltMks0?=
 =?utf-8?Q?5HToHfvK8kWyGg8ull1o3eA=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RERoMVpET3EwUm9iRTBKanhGWDh6ODArY29NMHdOSGJaWjNNVmtzcmgxY3Ay?=
 =?utf-8?B?aUpmWHZ4R3IyWTRDUDdMWWthWTJ1RjZNKzA3NTMwL01ucmZ1cS9YbGhtbjVD?=
 =?utf-8?B?SmgwOHpQRi9QSkNXcTNVaXB1U0U0dDNLMzV2SjhqeEhMN3NOeGRPSUdMYjZ4?=
 =?utf-8?B?bVVDSFRVTVdXN25YUy9DSlVvdVRiSHRSYlk4MEtVK2lhK3lWZmR5YkJVYXFL?=
 =?utf-8?B?Z0VTSkl4enZYWUswUy9QTVNrNm1MUWdlUTNBeEdaVTVNZjJwQ3RTYjdhRmZv?=
 =?utf-8?B?NWZ3RHJKcHB0cFRINXA2VTc4OXYvL1pybDcwT0tUT0JpekoxQzlxSXFhSmph?=
 =?utf-8?B?dUNCV3orY2R3QVdKNHF6WmFtaHRtd1JzQTZFZGpuckc0ODh2TE1RR3J6NUMx?=
 =?utf-8?B?S09xWVRxTURlNW9xb2szQ3F6Q0NFSlBpRFZLbFJHKzNZL2Q2MENPaTh3eUsv?=
 =?utf-8?B?Zi9RSDVuNURoVFY1blhGQWJFcGcyQXNuUFhIenFkMWtYWUhwS2ljOUYxNnk3?=
 =?utf-8?B?SU5NeXRoeW5tWkpobzlFN3NraDEwSGxmMGRMVGtScjM3aHlad2I2U21HUXh0?=
 =?utf-8?B?NjUxQnd5eW5RV2V6bVk5eHpORUR2ZFdVdlU3MmFlN2NxUmhTMjErUFZFOVll?=
 =?utf-8?B?bFpRUHBNRkFEa0tldGluWGFmT3ZzVmpoL3A1eGFGRjdIdzJ3TTFTVjNVSWgw?=
 =?utf-8?B?REpZTEQ5b2tkdXFCSkVTQ1VVY0Z2ZjRqbThSUFd6Wi9SMUkyVnNJeUZ0VW85?=
 =?utf-8?B?WjV3OVU0SEdHT25YVVFNL01zdk5SZmhSNHg4ejUvY21BQWdiYVZobGZkalhY?=
 =?utf-8?B?Nks3K25uV3RCOS9DK2Q1aFEwMlFFT29wZ1lqRWxqSnVuaG5uYUlEQVk2eWxS?=
 =?utf-8?B?SWd3akROdmNYOFJydllDd2l6SHlZZksrbHFOeVNSdlpmaEhwYW1ROVlCeTJ1?=
 =?utf-8?B?c3EwUHNvR0NtUEROWWJ5cHdXVVdrTUQzN3lJUUYxUEp6WTBzb1lDaFNWMCs3?=
 =?utf-8?B?VXhCWDRkZFlCZVB3ZFNJNnA1Z1UwNnRtY29VUlU1TTRHTjQ4dFRLbTZtUGJN?=
 =?utf-8?B?L0hBeGExa1NUQnV6TGNrSE1JZzJGeDZNWXg3Y2JyMklZZng3UHJwZVQrUDk1?=
 =?utf-8?B?Zll6NndTb1RFU0tQNE55eG5jN2RsdEFYalBXZG1PaEFmUDlYd1kramRVSVor?=
 =?utf-8?B?S0hoZ08zclpPckxHZ3piYmVwUm5saEh3Vy9qTTdXbGs4R3JvVjRRcGNIVXY3?=
 =?utf-8?B?bURUTUdDd1NsdzdCK1RyQjJJWXZBSm9DTFU3djNCdDU3dyt6clNHOXhKV29W?=
 =?utf-8?Q?pWqbSgSRT35q4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c56219c-009b-471b-a596-08dbf03b326f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 17:55:24.5957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5s4Mx1Zu8A2vR0aRre0wYZT8xV8lUk+jCItFyggMaPiGQpxQD/JlnNlYBl8mmKISsvO1SQVSoa7dR4I6mLXAF5el+vRohKDKf+WNfxbjsvwrjdFRI3MJIvG/k9ZgUo+b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7726
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-28_20,2023-11-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311280143
X-Proofpoint-GUID: GWurYeJBfS9Zkdjw0dimmhMonHc_5RCG
X-Proofpoint-ORIG-GUID: GWurYeJBfS9Zkdjw0dimmhMonHc_5RCG
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 28 Nov 2023 09:59:25 -0800 (PST)

Hi Greg,

On 28/11/23 9:58 pm, Greg Kroah-Hartman wrote:
> On Tue, Nov 28, 2023 at 05:09:52AM -0800, Harshit Mogalapalli wrote:
>> In edac_pci_main_kobj_setup() when dev_root is NULL,
>> kobject_init_and_add() is not called.
>>
>>          if (err) { // err = -ENODEV;
>>                  edac_dbg(1, "Failed to register '.../edac/pci'\n");
>>                  goto kobject_init_and_add_fail; // call to kobject_put()
>>          }
>>
>> This will cause a runtime warning in kobject_put() if the above happens.
>> Warning:
>> "kobject: '%s' (%p): is not initialized, yet kobject_put() is being called."
>>
>> Fix the error handling to avoid the above possible situation.
>>
>> Fixes: cb4a0bec0bb9 ("EDAC/sysfs: move to use bus_get_dev_root()")
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>> ---
>> This is based on static analysis with Smatch and only compile tested.
>> ---
>>   drivers/edac/edac_pci_sysfs.c | 14 ++++++++------
>>   1 file changed, 8 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/edac/edac_pci_sysfs.c b/drivers/edac/edac_pci_sysfs.c
>> index 901d4cd3ca38..71a0d4b9c2cf 100644
>> --- a/drivers/edac/edac_pci_sysfs.c
>> +++ b/drivers/edac/edac_pci_sysfs.c
>> @@ -370,12 +370,14 @@ static int edac_pci_main_kobj_setup(void)
>>   
>>   	/* Instanstiate the pci object */
>>   	dev_root = bus_get_dev_root(edac_subsys);
>> -	if (dev_root) {
>> -		err = kobject_init_and_add(edac_pci_top_main_kobj,
>> -					   &ktype_edac_pci_main_kobj,
>> -					   &dev_root->kobj, "pci");
>> -		put_device(dev_root);
>> -	}
>> +	if (!dev_root)
>> +		goto kzalloc_fail;
>> +
>> +	err = kobject_init_and_add(edac_pci_top_main_kobj,
>> +				   &ktype_edac_pci_main_kobj,
>> +				   &dev_root->kobj, "pci");
>> +	put_device(dev_root);
>> +
>>   	if (err) {
>>   		edac_dbg(1, "Failed to register '.../edac/pci'\n");
>>   		goto kobject_init_and_add_fail;
>> -- 
>> 2.39.3
>>
> 
> Hi,
> 
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
> 
> You are receiving this message because of the following common error(s)
> as indicated below:
> 
> - This looks like a new version of a previously submitted patch, but you
>    did not list below the --- line any changes from the previous version.
>    Please read the section entitled "The canonical patch format" in the
>    kernel file, Documentation/process/submitting-patches.rst for what
>    needs to be done here to properly describe this.
> 
> - You have marked a patch with a "Fixes:" tag for a commit that is in an
>    older released kernel, yet you do not have a cc: stable line in the
>    signed-off-by area at all, which means that the patch will not be
>    applied to any older kernel releases.  To properly fix this, please
>    follow the documented rules in the
>    Documentation/process/stable-kernel-rules.rst file for how to resolve
>    this.
> 
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.

No, this is a similar bug but in the edac_pci_sysfs.c file instead of 
the edac_device_sysfs.c.

Let me resend these two patches as a patchset and change the subject to 
make it more obvious(EDAC/pci_sysfs, EDAC/device_sysfs in title).  And 
add a CC stable tag.

Thanks,
Harshit

> 
> thanks,
> 
> greg k-h's patch email bot