Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
References: <e939c924-1dfa-4a6a-9309-2430f19467f5@paulmck-laptop>
 <87wmu2ywrk.ffs@tglx>
User-agent: mu4e 1.4.10; emacs 27.2
From:   Ankur Arora <ankur.a.arora@oracle.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     paulmck@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Ankur Arora <ankur.a.arora@oracle.com>,
        linux-kernel@vger.kernel.org, peterz@infradead.org,
        torvalds@linux-foundation.org, linux-mm@kvack.org, x86@kernel.org,
        akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com,
        bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org,
        bristot@kernel.org, mathieu.desnoyers@efficios.com,
        geert@linux-m68k.org, glaubitz@physik.fu-berlin.de,
        anton.ivanov@cambridgegreys.com, mattst88@gmail.com,
        krypton@ulrich-teichert.org, David.Laight@aculab.com,
        richard@nod.at, mjguzik@gmail.com,
        Simon Horman <horms@verge.net.au>,
        Julian Anastasov <ja@ssi.bg>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [RFC PATCH 47/86] rcu: select PREEMPT_RCU if PREEMPT
In-reply-to: <87wmu2ywrk.ffs@tglx>
Date:   Tue, 28 Nov 2023 10:30:53 -0800
Message-ID: <87plztvig2.fsf@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qOuO/plPViPwQ0B+Ieqm/alrmWaqq1KSjxy2fwF50xOdtZBfjt48a1ORFCMQ?=
 =?us-ascii?Q?IfzyxiGfcdxR1bj1UxMjcmFK9hyK77K/IsSo2AajJcEd4cL0hhOJR2XkQVAe?=
 =?us-ascii?Q?PDATAvaYmKNbUXvVqvFyS1C0giihm3XQgBToV5IU1KdVG8m8Craj06hLDHUZ?=
 =?us-ascii?Q?iqSUxm5fqhTop02m+qzmshLpw2rdpcPzIsdYBlrFEwXSoQFCG9UCgjni8C0W?=
 =?us-ascii?Q?7/uIQ7mJSCnUp8bsqL27QGHQkqig//UOLxG8ocikqft+Vo7djWWdnrK+DEyG?=
 =?us-ascii?Q?qLmPsGhvHMBlNxfEsA/o1Fygl7i5G/Fq9VMJRXxRgaB5rjVjrVyvirARdCY3?=
 =?us-ascii?Q?MDSnfBZVi1sitasFmFKBEJ+pT/IKT71dlsx+ngeW4J1Q4yeSlKTrmOCuuR/V?=
 =?us-ascii?Q?ytYlpaLjcBmBPebhUP2hrzWZWsWsBr8UOa12I7UiMOx1k7I3Zs6gF8+CK8X2?=
 =?us-ascii?Q?8GM7BZjP6EJXdYTJUNX+Vl5XbLUbH5jE+Hd7m1Yd5vnDB3kYyq7XeJM/m05G?=
 =?us-ascii?Q?quO8HPWQtSkimr1yFhuzByrhtLegLWjaS3OloAlP6JwzzJQlD5/cvbJMk0qe?=
 =?us-ascii?Q?KCI07MgyuQm/1D64N7jOgviAUZruUhmOfGVsegMzuMRObGwraH0A/FCn1Zpu?=
 =?us-ascii?Q?T55u+nk+cNfVRy2goAOxfMHvg9vgbFM0HWFe7IJo7Dx2ff0b/xltWt3p+6kC?=
 =?us-ascii?Q?MS86RgawoKU1keULuqfyvOHhQGG9nBnjtF/iPQC9nUpzJ+ERPO4nMIv7Cfx6?=
 =?us-ascii?Q?BRRmOnyQ3Okx8yRMwxYj0j6Rg7tDg+v5qIlUW3Dg7O3gdWyEvvnBgbl4SRj4?=
 =?us-ascii?Q?t4mA2H8QI3rjqvKsB0ueDyMVL8jqWHip2BcVyJzEsoNL6AjT21WTuBhiM0r0?=
 =?us-ascii?Q?HB3TVMBazR1sTIYpxS8wkkDLh9avhUF7pGsxJdZsSj0TBTfIWEQM25r6tlV3?=
 =?us-ascii?Q?/krdKWR1SpKP+hjnK5+t4pcGKaoeLKanywNxhekcTamvWfYYCsfpZZpFqb52?=
 =?us-ascii?Q?TYZL5FI0kTjPt8ayAmufVQmQS/JtB6x2w1yCNSgen4iKU6OVxbnfeCLt6hGs?=
 =?us-ascii?Q?zZMtJt2+MvnyEc0AVbA7lVa7n1YKr+IU7qEVHec+ZBlZSs9o5LEfVaotVli8?=
 =?us-ascii?Q?yPx/oFLZQbq1h2poZLHtfGFO7/Z+9Ys/p3iMI3eLXYiKwW6i2eBS6KrSnzuE?=
 =?us-ascii?Q?yrCQKcUh+qJJ0jYeiqGor7/goM26Wg5owHRGpr58Oz9RYJha2GJXZFjypZXe?=
 =?us-ascii?Q?lXUMWjFL8p1LVGJwuT3+ki3aMq2g5XDKSr1swnISrInTYwO7vJO1WJb8LtTb?=
 =?us-ascii?Q?HqqF2i7XMARTBIeG9+x5al3GeAVe9UaU4+CKwmlxzJLCY2b8lClNmunOGH5V?=
 =?us-ascii?Q?f9lND/lC44Pl69VGLDpsKtvzo/XFA7osE+r+Wkm6gtN6jlzrAhYdZfvbiAsa?=
 =?us-ascii?Q?RmV7SODOMn3FJAhAOJEb9KC1LelOBqOlXqaqLGyY9S9WD5yNrKS/9AhLZ+Nr?=
 =?us-ascii?Q?edF2CNDmHdym+aMB2OCValqcrGSa5LvNZic9Mob1Zl5BMRC6EbeHxSW4M1k2?=
 =?us-ascii?Q?rNeA9nJe9zn2z2u/HqB1BEOPVQ434mfTVpeSU+2VikESYyAx9YgZsJ29SwV2?=
 =?us-ascii?Q?Hw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?PBaNtVubPq0OWM6Hb7yV1K/WW9HCpm7jVpNv1ZzUXqAqggGWBUMFbAPLD/nQ?=
 =?us-ascii?Q?m6bNPNj26suSx2xKieDqfXRcZzFN422PYr5nsYOLR9hkQ94JLnXKtK8A3GB3?=
 =?us-ascii?Q?ZP/3vftu2fjx7WlN9qiJ/AMQ1zyMJDR+eIXhEocJICoy9zFR8PGvWhky5rpS?=
 =?us-ascii?Q?YAKI3rlR2rKWPdlbxbuJ9n5Fmsg4524QCiuJ+cGqZPq3YRWp1hKzgOymWJuD?=
 =?us-ascii?Q?fWaQ9hKK/Cava8i32jRpnEszpQMGB9NfnVGIPzNcsgzedffKAfMBsbe0dkfk?=
 =?us-ascii?Q?iSjoBr7BdtI8DuBNlOseBvNeMdhG1X/CR9gQBvae2lN4VAL+PWpMHGWmdSbJ?=
 =?us-ascii?Q?X8nTzEUpJI8K1+SsTHP4yXNOl28+xMPxYgF+b+2SrxHInt8+XO84RGiMf+3j?=
 =?us-ascii?Q?wATV0EZ2jnarXKVGjMUy1fTe61pIdQ3BDp7588hfzL924vp+e0wfeYdEd9pr?=
 =?us-ascii?Q?9lCTiEBXpbenTvRm8rRGGu8/zaQ5dVAEsXDTJiIvclax+IoKUaEmuojEMNMD?=
 =?us-ascii?Q?HCN9tVB6Iz+Pv14Rkk7byOqFtyUNzYu7WsJ8TBnj6oyGMczb3gvRhHnqwO7G?=
 =?us-ascii?Q?WVSHpSELCgsrsH4ujMZ9yXU3djjQ/rdrteaWcJZ+5JyJ6rkxpj2Jr5trqYX4?=
 =?us-ascii?Q?s+RTUly0npEla2AHyxdS34pbaSkbz/DmP04pWCVG0a8TVBzL6a4BZY2H+1So?=
 =?us-ascii?Q?z57GqZRGR6wJm6QPMVRXPnu77OVD+L2WWPPwhWL2H1uGb4B/sWIyxusyoCj9?=
 =?us-ascii?Q?R1KtDaT6JmMcKJ9y5ROs2hnCyf7LoraPBR5HoNQioH/XjNK4zy+sQLNj7i9J?=
 =?us-ascii?Q?jANLraxMphwB7CwqL9rGwx13zkHg8vgPnoWMquiJqdMXsBIq0HXPqzz7H9ed?=
 =?us-ascii?Q?jVPewHKUWzUVdJO35dXPz+jmQqGajV6yTclXGOIkMA/adWGW9mPRDMp0UNxn?=
 =?us-ascii?Q?0YpJPFJqhlFHYJJaDH0Jb03qcJPFDslCpgP9c9KTS4bXIqWsTTLOaGHh/X83?=
 =?us-ascii?Q?cwYpl7XteBUOABqeT//lMwsN8EHAhF+n+kKkBF8M6nxNb7VQfhI2o1F8apfB?=
 =?us-ascii?Q?5iHhQap42m89ZsoKAmia6sOooxVLC/e5QfaAiNqYUWZXeteP9Kf5J434IMWe?=
 =?us-ascii?Q?Bvlx12h4EzUU7MWDL1vEQJj41VEmL5+SgVepUAFXLLQ4L+Pqp5YRCaR2iwzZ?=
 =?us-ascii?Q?JkdEsc+lac1Gl3NKsn+yh+Rmxwpd1T8wo/YwQV9ZxVJPMdnPHG91G8Z5dFEX?=
 =?us-ascii?Q?FBStfEtZEcK6b+nyfleeD7l/5SvgrYq4VnQmA1Z+xQnV1nFy7BUW+lUUMTG6?=
 =?us-ascii?Q?ce7BrTwfVO707Sh7MHuPiNlEFZJuN+obLKs/s6OVbYz4FKZZ+GRgCs1vGOeO?=
 =?us-ascii?Q?0jfvmElMZ2ZaZ662ou0ikcpz+2gxtjV1XKrC+JbAUUM6+TbOLcT2/mR6A+FW?=
 =?us-ascii?Q?oHp8UGFgn/L/Bq5VrAwpbhFABOsMYixwK/tJt4b8xYCea4KBRmgCt51NO8Nt?=
 =?us-ascii?Q?HnarEC1aylWFAQA6U7q5VMANs9Stit19iCbE7mHHCDH7O5n/jG8R5izdI8iO?=
 =?us-ascii?Q?CPsf07KC1JKHd4/BEc9T/fTxVziJMuNkKCPpnxmwKoxgYKrvqIZzoh0TalD2?=
 =?us-ascii?Q?VI9tWxEcOpHZrlIIOS3ZQ9g=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a4ce1b7-d480-4dde-c884-08dbf04028f6
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 18:30:56.0400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5JXLDBA4PLXcG1za6vgWYswBtFI1cYUiKVUTCqRbMucx0wqJgyxjOO1XgHcrFU3KikJYCD0lvyJ0DDuNSAYFRx3vklMNSIKTiAZcZ6oTjwU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6224
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-28_21,2023-11-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxscore=0
 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=728
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311280148
X-Proofpoint-GUID: QvSzIFae0VoYBC3lXGgyFo0--WNH65EN
X-Proofpoint-ORIG-GUID: QvSzIFae0VoYBC3lXGgyFo0--WNH65EN
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 10:33:16 -0800 (PST)


Thomas Gleixner <tglx@linutronix.de> writes:

> Paul!
>
> On Tue, Nov 21 2023 at 07:19, Paul E. McKenney wrote:
>> On Tue, Nov 21, 2023 at 10:00:59AM -0500, Steven Rostedt wrote:
>>> Right now, the use of cond_resched() is basically a whack-a-mole game where
>>> we need to whack all the mole loops with the cond_resched() hammer. As
>>> Thomas said, this is backwards. It makes more sense to just not preempt in
>>> areas that can cause pain (like holding a mutex or in an RCU critical
>>> section), but still have the general kernel be fully preemptable.
>>
>> Which is quite true, but that whack-a-mole game can be ended without
>> getting rid of build-time selection of the preemption model.  Also,
>> that whack-a-mole game can be ended without eliminating all calls to
>> cond_resched().
>
> Which calls to cond_resched() should not be eliminated?
>
> They all suck and keeping some of them is just counterproductive as
> again people will sprinkle them all over the place for the very wrong
> reasons.

And, as Thomas alludes to here, cond_resched() is not always cost free.
Needing to call cond_resched() forces us to restructure hot paths in
ways that results in worse performance/complex code.

One example is clear_huge_page(), where removing the need to call
cond_resched() every once in a while allows the processor to optimize
differently.

  *Milan*     mm/clear_huge_page   x86/clear_huge_page   change
                          (GB/s)                (GB/s)

  pg-sz=2MB                14.55                 19.29    +32.5%
  pg-sz=1GB                19.34                 49.60   +156.4%

(See https://lore.kernel.org/all/20230830184958.2333078-1-ankur.a.arora@oracle.com/)

And, that's one of the simpler examples from mm. We do this kind of arbitrary
batching all over the place.

Or see the filemap_read() example that Linus gives here:
 https://lore.kernel.org/lkml/CAHk-=whpYjm_AizQij6XEfTd7xvGjrVCx5gzHcHm=2Xijt+Kyg@mail.gmail.com/#t

Thanks
--
ankur