Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <05e44249-8686-4e0d-856d-46a344127589@amd.com>
Date:   Tue, 28 Nov 2023 12:33:31 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [bug report] x86/split_lock: Make life miserable for split
 lockers
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        Joerg Roedel <jroedel@suse.com>
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <6bc08e77-812f-4e9e-938a-6a13263ce9d1@moroto.mountain>
 <ZWYl+ymwSRKzD+NL@agluck-desk3>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Autocrypt: addr=thomas.lendacky@amd.com; keydata=
 xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1
 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn
 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN
 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb
 aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez
 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA
 udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6
 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg
 hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U
 NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj
 a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK
 CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAl/aLz0FCQ7wZDQACgkQ
 3v+a5E8wTVPgshAA7Zj/5GzvGTU7CLInlWP/jx85hGPxmMODaTCkDqz1c3NOiWn6c2OT/6cM
 d9bvUKyh9HZHIeRKGELMBIm/9Igi6naMp8LwXaIf5pw466cC+S489zI3g+UZvwzgAR4fUVaI
 Ao6/Xh/JsRE/r5a36l7mDmxvh7xYXX6Ej/CselZbpONlo2GLPX+WAJItBO/PquAhfwf0b6n5
 zC89ats5rdvEc8sGHaUzZpSteWnk39tHKtRGTPBSFWLo8x76IIizTFxyto8rbpD8j8rppaT2
 ItXIjRDeCOvYcnOOJKnzh+Khn7l8t3OMaa8+3bHtCV7esaPfpHWNe3cVbFLsijyRUq4ue5yU
 QnGf/A5KFzDeQxJbFfMkRtHZRKlrNIpDAcNP3UJdel7i593QB7LcLPvGJcUfSVF76opA9aie
 JXadBwtKMU25J5Q+GhfjNK+czTMKPq12zzdahvp61Y/xsEaIGCvxXw9whkC5SQ2Lq9nFG8mp
 sAKrtWXsEPDDbuvdK/ZMBaWiaFr92lzdutqph8KdXdO91FFnkAJgmOI8YpqT9MmmOMV4tunW
 0XARjz+QqvlaM7q5ABQszmPDkPFewtUN/5dMD8HGEvSMvNpy/nw2Lf0vuG/CgmjFUCv4CTFJ
 C28NmOcbqqx4l75TDZBZTEnwcEAfaTc7BA/IKpCUd8gSglAQ18fOwU0EVo1liQEQAL7ybY01
 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb
 r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I
 bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2
 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO
 lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9
 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M
 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8
 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob
 pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+
 LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe
 /5rkTzBNUwUCYSZsLQUJDvBnJAAKCRDe/5rkTzBNU+brD/43/I+JCxmbYnrhn78J835hKn56
 OViy/kWYBzYewz0acMi+wqGqhhvZipDCPECtjadJMiSBmJ5RAnenSr/2isCXPg0Vmq3nzv+r
 eT9qVYiLfWdRiXiYbUWsKkKUrFYo47TZ2dBrxYEIW+9g98JM28TiqVKjIUymvU6Nmf6k+qS/
 Z1JtrbzABtOTsmWWyOqgobQL35jABARqFu3pv2ixu5tvuXqCTd2OCy51FVvnflF3X2xkUZWP
 ylHhk+xXAaUQTNxeHC/CPlvHWaoFJTcjSvdaPhSbibrjQdwZsS5N+zA3/CF4JwlI+apMBzZn
 otdWTawrt/IQQSpJisyHzo8FasAUgNno7k1kuc72OD5FZ7uVba9nPobSxlX3iX3rNePxKJdb
 HPzDZTOPRxaRL4pKVnndF2luKsXw+ly7IInf0DrddVtb2647SJ7dKTvvQpzXN9CmdkL13hC5
 ouvZ49PlXeelyims7MU0l2Oi1o718SCSVHzISJG7Ef6OrdvlRC3hTk5BDgphAV/+8g7BuGF+
 6irTe/qtb/1CMFFtcqDorjI3hkc10N0jzPOsjS8bhpwKeUwGsgvXWGEqwlEDs2rswfAU/tGZ
 7L30CgQ9itbxnlaOz1LkKOTuuxx4A+MDMCHbUMAAP9Eoh/L1ZU0z71xDyJ53WPBd9Izfr9wJ
 1NhFSLKvfA==
In-Reply-To: <ZWYl+ymwSRKzD+NL@agluck-desk3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3dCVWsyVlkyNVJ1b1JOZVAwTVNmaVpCcU5nUzhzd25BV2dzSlBQaS9pZEJ4?=
 =?utf-8?B?OTdsZVA0ekRSVVRERHR4Tk1EejM1ZlRDQVJxbnBWTitoZC9BZGE0TXFGVndQ?=
 =?utf-8?B?aXAvL1NOeGUrb2JSek4wd1NPN0IzcU9TMVd1ekkwdkVpalR2RWdGSFV0a0pT?=
 =?utf-8?B?c1dJQ0R4QVhpZEtqdkYyRkc4RXl5Z0NCQk5hVGc5bmxsQTE4TFFoODI0dzlo?=
 =?utf-8?B?Z3U0bnh2M0VhdHV5Z21nK2FSVUpJN3Y5T0UyZUE2ekgxbGdZRWNNcFk2alhG?=
 =?utf-8?B?M0JSVnFRcFBUSkdiV3MwK2l1L0lWNEpCUjNBR09VWFNmWGRQbERoYnpBZVNn?=
 =?utf-8?B?L212ZXpkYXdTclU2aUx3QXE3MlUzYzZsT1ZiMGRlZ3ZCVWJpeG1vK1F2SHdO?=
 =?utf-8?B?L0hqOWM2R1o0cFkrSGtHa3V5Z1pOZ2k1azlMK2VlbktNNEkyRlUxTWRUWnMr?=
 =?utf-8?B?dkwvNlQ2dXA1NkR5N016ODEzUUlNeXI2N05iOHJLVTI4dmdpUXVHNlU4Zm15?=
 =?utf-8?B?c2dQRDRhelk3a0ZDdTNPQlBwNWFUUXVRZjJMdHJET3lFQndISmtVWHZuT2pY?=
 =?utf-8?B?R3pyK2xHRmFYWkhPK0dXaEtnQVlsOStwc2VFb1l5ZTFEazZUcURUTlBVMlBo?=
 =?utf-8?B?bm1VOGlSV2tvQzN4b3dabitnSlZ4U1c2aTlKbXhrbkxhdE9QcHFUVjRGVDQ4?=
 =?utf-8?B?WFBaeUkweUdKY3hwZFRnRXpOUnhaQndmMk9qc0ZxdUZjTFVYaC9aYjFrQldS?=
 =?utf-8?B?VXdQYWkwU0p1bXpBSndqZ1pNWmg2bE5yejdnZlhYSFZtTUpVSFRLeFVGSHNz?=
 =?utf-8?B?NkNBTnozcVUvbVRSMmVsQVRmK3ZjVlhOSWZkK3NYSm1VbmpyTSs0WmRQRlU4?=
 =?utf-8?B?QlAyVmNKY2EvaGt0ZmptVlZuaVJZbkJZZ0kwbUlaKzhsOGprbktOekxodUd6?=
 =?utf-8?B?Nk9OVkJ3enl6NjJ6VHhwc2JIRXZ1M1JzV2cvelN2Y054SHVzOStIdkpIVGMy?=
 =?utf-8?B?RXlYTTR6RFlsSjhWKzZha1F5UWNZYytkUTJGTmJOTFBCc3hDT2JJd0JVMFMz?=
 =?utf-8?B?SVpqbWJaVkNaN1FUVGxlWjZIbXpaZWRGdXhWWFFsd1ZQM1g5YTRESEswMUsv?=
 =?utf-8?B?T0EzcUJMQjJqMEVUM1JVd25GcjVRNEVXcDJCdE0xYlZjeEZTcStQaklmM29C?=
 =?utf-8?B?YzhGVVliSGdweGRuOFd1YnJTT1dmSi9zUFAxeEp1ekhVQU85S3hDSnNMekNX?=
 =?utf-8?B?UlF6K3ljSERtZUw0TGVvRjAxODZYblJOMkdIK2hBeWpBcThuRkJxVXVmY09F?=
 =?utf-8?B?WEtRSW5IVTZjNVpsWi9lMUhIM0k3TVp6bnAxejBTb2NQNnYxQmtxSXZhU2Zh?=
 =?utf-8?B?N25TRjgzZ0FtQ0V2MmVmK2o0bFA1NGo0VjQ4N2oyeXc3WUduUGdzNHR4YWgr?=
 =?utf-8?B?aE1BSE9IaDRySlJ5eVB0SkI5Snp0UHNzTUNScDBRVmhUeDg5N2kwa1hTUlNX?=
 =?utf-8?B?ejNMdGJ6aFoxdnVsUG5ZOVVwM0dtRlExR2h4YkZYa0hUVklwMStESmhXSloy?=
 =?utf-8?B?QlR2WUVERHlZU3hVK1krSkRpWkcrK0NRNzFNcDZYbG5CeGpKRmpJOU5QbE1O?=
 =?utf-8?B?UVZGdXlGYTNrS3BRKzlMOHRYTDhKYjUrQ3cwZEU4UGVxeFFPdEtIZEU5b0Zl?=
 =?utf-8?B?WXRrOE1ZYVlIeGhBbzA5Q3N3N0hnV042VHBCK05FalRUREx1T09mM0d1M3g2?=
 =?utf-8?B?Mnk4L0YyaDVIRi93dW96UUltOE5JMWluN2ZicStDOG1tOW5FQ0ZtQmJoYnR2?=
 =?utf-8?B?T2l4QlZZYXh6Y0I2blFwa2tGWnlHNTVWSm5JSTlCMkRzajN4VDdTaXNMVENo?=
 =?utf-8?B?ZGh5YUlhU0JGRnRQRGQ0UVVabUdQbzRRL2pvUE8zKy9OcWN0Mkc5cGZ3cWZY?=
 =?utf-8?B?SFIxOFM5RUpUZ2hVRFBQV1FleU92c00yb29CUEM0bmc4WDRuQjBDRWhoc0hT?=
 =?utf-8?B?L3pMRUUxTFdKTlFoVTBodzVLYmxnaUF3V1haN01qU2kvYjQyR0JJWUJmd05I?=
 =?utf-8?B?VXFRakMwUkY5T3RkdEtmQUNLMkJRQWlSMWxqMFFSbVljb2s2dlUyNmZYSWVp?=
 =?utf-8?Q?KxP6wHqTGMwpWsCSjxi6LOHoz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7f12181-741c-4ccd-83b0-08dbf0408716
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 18:33:33.9308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: USmFNxBetaYw5SCP6tEfLz/R8xCT3VENvRm30cnv7U7OZo4q3Ah4Uu+5ClnhDlxeOeYpTOACSi2slSiLq7Zr+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8149
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 28 Nov 2023 10:33:54 -0800 (PST)

+Joerg

On 11/28/23 11:40, Tony Luck wrote:
> On Tue, Nov 28, 2023 at 04:12:24PM +0300, Dan Carpenter wrote:
>> Hello Tony Luck,
>>
>> The patch b041b525dab9: "x86/split_lock: Make life miserable for
>> split lockers" from Mar 10, 2022 (linux-next), leads to the following
>> Smatch static checker warning:
>>
>> 	arch/x86/kernel/cpu/intel.c:1179 split_lock_warn()
>> 	warn: sleeping in atomic context
>>
>> arch/x86/kernel/cpu/intel.c
>>      1158 static void split_lock_warn(unsigned long ip)
>>      1159 {
>>      1160         struct delayed_work *work;
>>      1161         int cpu;
>>      1162
>>      1163         if (!current->reported_split_lock)
>>      1164                 pr_warn_ratelimited("#AC: %s/%d took a split_lock trap at address: 0x%lx\n",
>>      1165                                     current->comm, current->pid, ip);
>>      1166         current->reported_split_lock = 1;
>>      1167
>>      1168         if (sysctl_sld_mitigate) {
>>      1169                 /*
>>      1170                  * misery factor #1:
>>      1171                  * sleep 10ms before trying to execute split lock.
>>      1172                  */
>>      1173                 if (msleep_interruptible(10) > 0)
>>      1174                         return;
>>      1175                 /*
>>      1176                  * Misery factor #2:
>>      1177                  * only allow one buslocked disabled core at a time.
>>      1178                  */
>> --> 1179                 if (down_interruptible(&buslock_sem) == -EINTR)
>>      1180                         return;
>>      1181                 work = &sl_reenable_unlock;
>>      1182         } else {
>>      1183                 work = &sl_reenable;
>>      1184         }
>>      1185
>>      1186         cpu = get_cpu();
>>      1187         schedule_delayed_work_on(cpu, work, 2);
>>      1188
>>      1189         /* Disable split lock detection on this CPU to make progress */
>>      1190         sld_update_msr(false);
>>      1191         put_cpu();
>>      1192 }
>>
>> The call tree is:
>>
>> kernel_exc_vmm_communication() <- disables preempt
>> -> vc_raw_handle_exception()
>>     -> vc_forward_exception()
>>        -> exc_alignment_check()
>>           -> __exc_alignment_check()
>>              -> handle_user_split_lock()
>>                 -> split_lock_warn()
>>
>> I think maybe the mismatch is that kernel_exc_vmm_communication() calls
>> irqentry_nmi_enter(regs); which disable preemption but exc_alignment_check()
>> does local_irq_enable() which doesn't enable it.
> 
> I think we need some arch/x86/kernel/sev.c expertise to explain the
> preemption requirements in that stack trace. Adding Tom Lendacky.

Adding Joerg as the original developer of this code.

I believe that irqentry_nmi_enter() is used so that we are ensured that 
the kernel can't be interrupted while using the per-CPU GHCB when entered 
from kernel-mode in order to avoid nested #VCs (except for an NMI). Joerg 
might have further insights since there was a lot of discussion around 
these changes.

I'm not sure if is possible, but I wonder if irqentry_nmi_exit() can be 
issued before forwarding the exception - or even delay forwarding the 
exception until after irqentry_nmi_exit().

Thanks,
Tom

> 
>> Also why does arch/x86 not have a dedicated mailing list?
> 
> Good question. X86 was once the default architecture. So everything went to
> linux-kernel@vger.kernel.org. I'll add that to Cc: for this. But maybe
> it's time for an x86 specific list?
> 
>> regards,
>> dan carpenter
> 
> -Tony