Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Shinas Rasheed <srasheed@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Haseeb Gani <hgani@marvell.com>,
        Vimlesh Kumar <vimleshk@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com" <mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device
 unload control net API
Thread-Topic: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device
 unload control net API
Thread-Index: AQHaIU3Pn4kUrPqSikaGSVeLinDUmrCPBp8AgAAaVCCAAMvsAIAALJUw
Date:   Tue, 28 Nov 2023 19:08:26 +0000
Message-ID: <PH0PR18MB4734B57CC289557366F68A47C7BCA@PH0PR18MB4734.namprd18.prod.outlook.com>
References: <20231127162135.2529363-1-srasheed@marvell.com>
        <20231127162135.2529363-2-srasheed@marvell.com>
        <20231127184306.68c2d517@kernel.org>
        <PH0PR18MB4734281BD887FD9AFD64B2DEC7BCA@PH0PR18MB4734.namprd18.prod.outlook.com>
 <20231128082712.223c4590@kernel.org>
In-Reply-To: <20231128082712.223c4590@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3kQcKvI1sgDANt5qpVFm8oogxyhMfd20Ht1zHTUfc3UcD9/NOYzlU9dgy966?=
 =?us-ascii?Q?MstRLZbeYgL2MS7Q+yEy5LV17LeUawsgDRKXB8oNDYnB6X7z51Sbf9Mce24g?=
 =?us-ascii?Q?Awuy7mdK6fxke3K+ZoEgeyR3FnQyiiVcSlUGkmB+hgRhYk15scV5t6Cidjiu?=
 =?us-ascii?Q?+RTmLhlGorCFQwwNsfY4dpzueQLiVzWlk3G8h8hlPbejpzJ3wzn8kOM51H56?=
 =?us-ascii?Q?lcdg3SgUVOT3u2jsAFLpzLC8fdzcIexuz5GIwkMOhlv+kcCkCgMsJIW82W6X?=
 =?us-ascii?Q?zeX8rbMvPdqSNfKh6yhX2aj70GLgHeO0c43K9GJaTvyOIsdkERjOdslO0JVb?=
 =?us-ascii?Q?C3imNRG1ddCl7pT0m1kEWRhzNBjlBWQwfWDNKLrbrd02iG0AjYnIdCEw9igM?=
 =?us-ascii?Q?FwWmcuJ+5dSFbC5oKdFmYbLRGSJgNqGl0MECFeFFLkb8RiX5uEO3gPNf9ZYj?=
 =?us-ascii?Q?vStUn1I8SOtvO3YAUZD+t+jhlzZhiwqWmtCnXEirp9XsGDAo0fTHJeD/3YS3?=
 =?us-ascii?Q?6r1a1KavRWNtzPLLWyBp8Z3eDRjgHKKwcHEFPSehZWqCo3EGaVGVcN0Q06UF?=
 =?us-ascii?Q?vk6fMKe512lzLfNZ6G7u7k9K0qSjgO5U8M9ItvwSSmjk/bgviN3tN65Jva53?=
 =?us-ascii?Q?0OOYMVYBLETd/lDA3U0+u+251j5hZ8zeRv7FD/g/8xEbVHJAQoFwe3SkmMYf?=
 =?us-ascii?Q?Q8usCH1f3qWI3oQbbb5v3SseEPFq9fz75nFXcczmIoLMCXPVNdWvX1Dy6Pi4?=
 =?us-ascii?Q?RDbxjmuZxAvmcTGtCk4PHvxMnlP3s4LwbWMo0mfz+yZVfbBJhgqsE40tDKPL?=
 =?us-ascii?Q?xtIiXQIAwauuPRz76c5Yl5BrfKc1U7LOScUCbXP6FJIfHGT3Mk/7JrfoqAtq?=
 =?us-ascii?Q?+juGhkRT2s0iwsDsqxDd4E9ChsgpxyNRbrS/DKi3LHdx3dTLCjfVcwjWZ1HQ?=
 =?us-ascii?Q?FtCuFZbWcQ7kBgDb6Ej91RPzTBHk+rOpA/9XD/5YFneKZAJXKlsEoDWBKTSX?=
 =?us-ascii?Q?rTiVbkzsPcIBxjF48iiFqZQF76mnwP81gwt3I1ePjpKXwdFpgM5CZfPQ5SBE?=
 =?us-ascii?Q?5HJgjljvrNXn4cMvYPArcz3XoEIH97edO8rhQFyMSQ0c4ftgDcW/Xkb5DW3Y?=
 =?us-ascii?Q?KZ17Ub68cgTYBWCZft4RfFTmicanpcGARr1DG6U6kcRvnd1Qg75Uppp7hBAC?=
 =?us-ascii?Q?ZIJ+sRQGPfwf74I+m0cmc2gpz8I4RhfDpy1BN1cOdkv9JjpiNjB7JuBLGnCn?=
 =?us-ascii?Q?kSp36OM+5wjo2Y6aTn48WUxwBycFPLU+1M1cK/HLoDV8f1gwdOSsbSCEVLRL?=
 =?us-ascii?Q?L24/DgDfzQDt6tFtKmTBZEFaXjzEY+NlcjO7oPmaoYkZ06wwhB1WMT5tsLQ1?=
 =?us-ascii?Q?XNl60/M8eMDpUdZpBqP16Att63MCuxor+el1kLLpD89bTDOALoWV2Ftd0rB2?=
 =?us-ascii?Q?aeStanNPLNdgmuzV7Gjhpg7Twimu66WezpPLvGOtMpf36OZ3v1fM6LPdnr+T?=
 =?us-ascii?Q?qQFwFLMnuBMBGeDZFJ5xgiUFLT+QhOhEiSLNFQwilbU/N7FdgIHrIDKd/DLe?=
 =?us-ascii?Q?2Z/Rt3XYiEXMcJ/1ysFPDbnSrpGok2SZXk1Ogst4?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4734.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de926288-ab31-431d-e4ef-08dbf0456655
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 19:08:26.2946
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DfP8DNI035q+V9jG+6ldclGt3rxcs/vCmGxwTIywJ45M1OM+k+yxAv5Trt5vZS0CXi/H9DzSwg/X6LjKHImSsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR18MB5442
X-Proofpoint-GUID: zD5bFow0qBQsTXsaSs7oacHfpEUsHAgq
X-Proofpoint-ORIG-GUID: zD5bFow0qBQsTXsaSs7oacHfpEUsHAgq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-28_21,2023-11-27_01,2023-05-22_02
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 11:08:44 -0800 (PST)


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, November 28, 2023 9:57 PM
> To: Shinas Rasheed <srasheed@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Haseeb Gani
> On Tue, 28 Nov 2023 04:22:11 +0000 Shinas Rasheed wrote:
> > > On Mon, 27 Nov 2023 08:21:34 -0800 Shinas Rasheed wrote:
> > > > Device unload control net function should inform firmware
> > >
> > > What is "control net" again?
> >
> > Control net is just a software layer which is used by the host driver
> > as well as the firmware to communicate with each other, given in the
> > source file octep_ctrl_net.c and the corresponding octep_ctrl_net.h
> > interface, which is already part of upstreamed driver.
>=20
> Yes, I think it went in before I had time to nack it.
> I'm strongly against using the IP stack to talk to FW,
> if you read the ML you would know it.
>=20
> No new patches to octep_ctrl_net will be accepted.

Control net doesn't use the IP stack at all. It's a simple producer-consume=
r based ring mechanism using PCIe BAR4 memory. Sorry maybe the nomenclature=
 suggests something of that nature.