Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4079319rdh; Tue, 28 Nov 2023 11:11:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtXVYaE6AkI/KJoML6Ljq+XNdM+tebi8W7fTE4op+cakD9BAROstD5p2Bpne+iLnFhRU3J X-Received: by 2002:a05:6a00:130f:b0:6cb:a60c:1d with SMTP id j15-20020a056a00130f00b006cba60c001dmr15889769pfu.17.1701198701415; Tue, 28 Nov 2023 11:11:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701198701; cv=none; d=google.com; s=arc-20160816; b=dKbO5is34zzfqxGcio1gJr9pfgdvjk+QO6tA4N5u3FoidsjKg7GKwJ/f9ohhzz7wsa rQWcpQc7oQ6u0p/vfN7+VXlawIA5VmE9zNZH44zpuXNUOvCNIJv90X08zi2f049gZE1A CjJV4ySnsbFQvXv46jlERc1QXcrUz5/tLDDCV8gnT0fzTfEHZCOJZUcTOHSgUxCpfhLL JtqDQLWMU8WXznZvttCKXvfvoyblBpLi7s4PH7mybdSi2NzKMgcTTojNLhvPmXKLVjUk DeHbscfaQdRoPPsbEC/fYi4DQNa2FW/71pEgl7WeAntwKiokigmMlesw9m5Ri46adFxm p+Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=ds2wGK5h8NrsZ7RSJzlWmRs/SKkhVnx+D5T3iR0H8Ug=; fh=3oN2KO07eS2H2r3nWFFMGMP33xw62YFZFj2sSfVhHEU=; b=l/MlFIUcadFiLSA8NFN1bWvyfxNu9vIMBwEAGEaDsKTGbls9KywEWIteFkW0Sg48h4 oORzI/3aiv/7yEtmsRGORPZrPSJqp+oDj/LKbvqxTW37svpQiIXue87mXqP6/d7qPM/w Ngk8Xfkd4u7MXavqQANk+wMEDZ4eQqi5AwFfkNu25RRmBm7rczTbdJyRjWnOzbeL53hs dk4fIwkDk7oRu7iVc5eAM9wZ5ok2E9MsTfNQ4cg8ovdTUVI1BtezswmIGw9NDw5lPYaz mQeVxVyOk7MGVMep2UMttKpoRnV4vkCNl0PqZowTSvTDK4Fw+2sQtOGWs3eUsKNnThRE KlFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Rjh2Nw7D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x16-20020a62fb10000000b006cc01aa0480si8386093pfm.370.2023.11.28.11.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 11:11:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Rjh2Nw7D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 19D2E8040EEB; Tue, 28 Nov 2023 11:11:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346160AbjK1TLa (ORCPT + 99 others); Tue, 28 Nov 2023 14:11:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjK1TL3 (ORCPT ); Tue, 28 Nov 2023 14:11:29 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D838B198D for ; Tue, 28 Nov 2023 11:11:35 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-7b38ff8a517so30716239f.1 for ; Tue, 28 Nov 2023 11:11:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1701198695; x=1701803495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ds2wGK5h8NrsZ7RSJzlWmRs/SKkhVnx+D5T3iR0H8Ug=; b=Rjh2Nw7DM8VD9Yo8VC3swR78YGlDv44QgTblrVrS+duL4xPFq4iMPrr1L2Sl4bDIRn DQs9cAxqg8kNrmB75cwiA3dhBWMt7ua4uUpnYYIV8GAzSlFpWebHSQnhUqfQMMKFGryc yPEHc+eTevyJs14J8X4uycqEpx1/7d+cgf3UWKjRlA215XuzOfdqGTE642ge1iQQcWTk S+/TNqNGHu3W/WBAG42UeMat2vJLe9HBI3PVud6KeuVxDYe8/qzaiIncGjXkXZccxzTB RZnVprDwc35pJsQdzjiIIFXlUneYHPlgt+nX+ltEiBwtCKm91Ogl47RLvOKa3DdQtfd7 URvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701198695; x=1701803495; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ds2wGK5h8NrsZ7RSJzlWmRs/SKkhVnx+D5T3iR0H8Ug=; b=qQX5GBjT/4XpyyOGU6xJ8j/0LKsKJ/yA/+rWmztZyGIH43qadtJYrNPEFhbawvlxaC Fpmzy9ML4WPimW+QjXXfH1lWSvyyMSA7AP7jeWxdOjmmfXYjMgvWxymcDT4T+bXDBFzk aSx/H9PHL7nVS/+a6AvnmP/YFLpB9csld53TdhfwR/brhk/JMWzN+LnIlpA4zm16D6MC uRYjKQL1M3pvTtnVrX/CPMTmsN9OWFtg7kI178bcLdEbbI5c+zPlrsPJ32fwnYev34pz OcbiyURG2PRCaPjb0qimpO4KrlqFohBX7Y3FzGLBXRHYJDDfmyPAZc+nZVpB63E2NTt9 Eg5Q== X-Gm-Message-State: AOJu0YyrVdFvTc8IeBpfdoaypl3WnjRnd+LKpmt2nFUWShlAkm1WX1+/ Zru1uv6TH3y75DcgEUo4wqxJA3Ug2bnSImruJCnTdQ== X-Received: by 2002:a92:503:0:b0:35c:acbd:3d3e with SMTP id q3-20020a920503000000b0035cacbd3d3emr9388102ile.3.1701198694797; Tue, 28 Nov 2023 11:11:34 -0800 (PST) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id a23-20020a056638005700b00466a2a9e5b0sm2366823jap.32.2023.11.28.11.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 11:11:34 -0800 (PST) From: Jens Axboe To: hch@lst.de, ming.lei@redhat.com, Yu Kuai Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com In-Reply-To: <20231128123027.971610-1-yukuai1@huaweicloud.com> References: <20231128123027.971610-1-yukuai1@huaweicloud.com> Subject: Re: [PATCH v4 0/2] block: warn once for each partition in bio_check_ro() Message-Id: <170119869379.128043.13576945712245414307.b4-ty@kernel.dk> Date: Tue, 28 Nov 2023 12:11:33 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-7edf1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 11:11:40 -0800 (PST) On Tue, 28 Nov 2023 20:30:25 +0800, Yu Kuai wrote: > Changes in v4: > - remove the patch to add 'bd_flags', and add a new field 'bool > bd_ro_warned' in patch 2. 'bd_flags' will be added once 'bd_inode' is > removed from other thread. > > Changes in v3: > - add patch 1 from Ming, swap bd_inode layout with bd_openers and > bd_size_lock; > - change bd_flags from u32 to u16 in patch 2, prevent to affect layout of > other fields; > > [...] Applied, thanks! [1/2] block: move .bd_inode into 1st cacheline of block_device commit: fad907cffd4bde7384812cf32fcf69becab805cc [2/2] block: warn once for each partition in bio_check_ro() commit: 67d995e069535c32829f5d368d919063492cec6e Best regards, -- Jens Axboe